* [PATCH] vhost: remove dependency on PCI library
@ 2026-08-31 7:41 David Marchand
2026-09-01 7:00 ` [PATCH v2] " David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2026-08-31 7:41 UTC (permalink / raw)
To: dev; +Cc: Maxime Coquelin, Chenbo Xia, Jiayu Hu, Sunil Pai G
Since the async datapath code switched to dmadev, there is no reason to
depend on the pci library.
Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/vhost/meson.build | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build
index 6a24981d10..64698182cd 100644
--- a/lib/vhost/meson.build
+++ b/lib/vhost/meson.build
@@ -44,4 +44,4 @@ headers = files(
driver_sdk_headers = files(
'vdpa_driver.h',
)
-deps += ['ethdev', 'cryptodev', 'hash', 'pci', 'dmadev']
+deps += ['ethdev', 'cryptodev', 'hash', 'dmadev']
--
2.54.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* [PATCH v2] vhost: remove dependency on PCI library
2026-08-31 7:41 [PATCH] vhost: remove dependency on PCI library David Marchand
@ 2026-09-01 7:00 ` David Marchand
2026-09-01 8:00 ` Bruce Richardson
0 siblings, 1 reply; 4+ messages in thread
From: David Marchand @ 2026-09-01 7:00 UTC (permalink / raw)
To: dev; +Cc: Maxime Coquelin, Chenbo Xia, Sunil Pai G, Jiayu Hu
Since the async datapath code switched to dmadev, there is no reason to
depend on the pci library.
Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
Changes since v1:
- fixed "internal" dependencies of examples,
---
examples/vdpa/meson.build | 1 +
examples/vhost/meson.build | 1 +
lib/vhost/meson.build | 2 +-
3 files changed, 3 insertions(+), 1 deletion(-)
diff --git a/examples/vdpa/meson.build b/examples/vdpa/meson.build
index 45f8a6fa31..3a319dd539 100644
--- a/examples/vdpa/meson.build
+++ b/examples/vdpa/meson.build
@@ -12,6 +12,7 @@ if not is_linux
endif
deps += 'vhost'
+deps += 'pci'
allow_experimental_apis = true
sources = files(
'main.c',
diff --git a/examples/vhost/meson.build b/examples/vhost/meson.build
index e938be8f45..1cf061c597 100644
--- a/examples/vhost/meson.build
+++ b/examples/vhost/meson.build
@@ -13,6 +13,7 @@ endif
deps += 'vhost'
deps += 'dmadev'
+deps += 'pci'
allow_experimental_apis = true
sources = files(
'main.c',
diff --git a/lib/vhost/meson.build b/lib/vhost/meson.build
index 6a24981d10..64698182cd 100644
--- a/lib/vhost/meson.build
+++ b/lib/vhost/meson.build
@@ -44,4 +44,4 @@ headers = files(
driver_sdk_headers = files(
'vdpa_driver.h',
)
-deps += ['ethdev', 'cryptodev', 'hash', 'pci', 'dmadev']
+deps += ['ethdev', 'cryptodev', 'hash', 'dmadev']
--
2.54.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* Re: [PATCH v2] vhost: remove dependency on PCI library
2026-09-01 7:00 ` [PATCH v2] " David Marchand
@ 2026-09-01 8:00 ` Bruce Richardson
2026-09-01 8:17 ` David Marchand
0 siblings, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2026-09-01 8:00 UTC (permalink / raw)
To: David Marchand; +Cc: dev, Maxime Coquelin, Chenbo Xia, Sunil Pai G, Jiayu Hu
On Tue, Sep 01, 2026 at 09:00:24AM +0200, David Marchand wrote:
> Since the async datapath code switched to dmadev, there is no reason to
> depend on the pci library.
>
> Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path")
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
> Changes since v1:
> - fixed "internal" dependencies of examples,
>
> ---
> examples/vdpa/meson.build | 1 +
> examples/vhost/meson.build | 1 +
> lib/vhost/meson.build | 2 +-
> 3 files changed, 3 insertions(+), 1 deletion(-)
>
No objection to this patch, but rather than changing this now, would we not
be better just waiting to see what happens with the sync datapath itself?
If it gets removed from vhost lib, then a larger cleanup is likely which
should encompass these changes and more.
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: [PATCH v2] vhost: remove dependency on PCI library
2026-09-01 8:00 ` Bruce Richardson
@ 2026-09-01 8:17 ` David Marchand
0 siblings, 0 replies; 4+ messages in thread
From: David Marchand @ 2026-09-01 8:17 UTC (permalink / raw)
To: Bruce Richardson; +Cc: dev, Maxime Coquelin, Chenbo Xia, Sunil Pai G, Jiayu Hu
On Tue, 1 Sept 2026 at 10:00, Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Tue, Sep 01, 2026 at 09:00:24AM +0200, David Marchand wrote:
> > Since the async datapath code switched to dmadev, there is no reason to
> > depend on the pci library.
> >
> > Fixes: 53d3f4778c1d ("vhost: integrate dmadev in asynchronous data-path")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > ---
> > Changes since v1:
> > - fixed "internal" dependencies of examples,
> >
> > ---
> > examples/vdpa/meson.build | 1 +
> > examples/vhost/meson.build | 1 +
> > lib/vhost/meson.build | 2 +-
> > 3 files changed, 3 insertions(+), 1 deletion(-)
> >
> No objection to this patch, but rather than changing this now, would we not
> be better just waiting to see what happens with the sync datapath itself?
*a*sync I guess.
> If it gets removed from vhost lib, then a larger cleanup is likely which
> should encompass these changes and more.
On second thought, I agree, it is not worth having as a simple
(backportable) fix, it is only an internal dependency.
I don't mind merging it in the series
https://patchwork.dpdk.org/project/dpdk/list/?series=39064&state=*
--
David Marchand
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-09-01 8:17 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-31 7:41 [PATCH] vhost: remove dependency on PCI library David Marchand
2026-09-01 7:00 ` [PATCH v2] " David Marchand
2026-09-01 8:00 ` Bruce Richardson
2026-09-01 8:17 ` David Marchand
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox