[dpdk-dev] [PATCH v1] examples/ptp_tap_relay_sw: fix build inclusion

[dpdk-dev] [PATCH v1] examples/ptp_tap_relay_sw: fix build inclusion

[jerinj]

From: Jerin Jacob <jerinj@marvell.com>

The ptp_tap_relay_sw example was not building because
examples/meson.build was not updated to wire up this directory.

Fixes: bec00deaa8fb ("examples/ptp_tap_relay_sw: add PTP transparent clock relay")
Cc: stable@dpdk.org

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
---
 examples/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/examples/meson.build b/examples/meson.build
index 25d9c88457..ab82cf5fbd 100644
--- a/examples/meson.build
+++ b/examples/meson.build
@@ -43,6 +43,7 @@ all_examples = [
         'packet_ordering',
         'pipeline',
         'ptpclient',
+        'ptp_tap_relay_sw',
         'qos_meter',
         'qos_sched',
         'rxtx_callbacks',
-- 
2.54.0

Re: [dpdk-dev] [PATCH v1] examples/ptp_tap_relay_sw: fix build inclusion

[David Marchand]

On Wed, 2 Sept 2026 at 10:25, <jerinj@marvell.com> wrote:
>
> From: Jerin Jacob <jerinj@marvell.com>
>
> The ptp_tap_relay_sw example was not building because
> examples/meson.build was not updated to wire up this directory.

Ouch, the whole example looks like dead code.
I wonder how it was tested by the author...
The series that introduced it has no trace of touching
examples/meson.build in the v6, v7 and v8 iterations :-(.


>
> Fixes: bec00deaa8fb ("examples/ptp_tap_relay_sw: add PTP transparent clock relay")
> Cc: stable@dpdk.org
>
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>

The fix lgtm.
For the record, it is the only dead example at this point in time in DPDK.


-- 
David Marchand

Re: [dpdk-dev] [PATCH v1] examples/ptp_tap_relay_sw: fix build inclusion

[Bruce Richardson]

On Wed, Sep 02, 2026 at 11:09:02AM +0200, David Marchand wrote:
> On Wed, 2 Sept 2026 at 10:25, <jerinj@marvell.com> wrote:
> >
> > From: Jerin Jacob <jerinj@marvell.com>
> >
> > The ptp_tap_relay_sw example was not building because
> > examples/meson.build was not updated to wire up this directory.
> 
> Ouch, the whole example looks like dead code.
> I wonder how it was tested by the author...
> The series that introduced it has no trace of touching
> examples/meson.build in the v6, v7 and v8 iterations :-(.
> 
> 
> >
> > Fixes: bec00deaa8fb ("examples/ptp_tap_relay_sw: add PTP transparent clock relay")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> 
> The fix lgtm.
> For the record, it is the only dead example at this point in time in DPDK.
> 
It's not dead code, since it was buildable before when it was named using
"examples=" parameter. The list of all examples is only used when
"-Dexamples=all" is passed, so we are just missing this examples from
automated build testing using the "all" param.

Re: [dpdk-dev] [PATCH v1] examples/ptp_tap_relay_sw: fix build inclusion

[Bruce Richardson]

On Wed, Sep 02, 2026 at 01:55:23PM +0530, jerinj@marvell.com wrote:
> From: Jerin Jacob <jerinj@marvell.com>
> 
> The ptp_tap_relay_sw example was not building because
> examples/meson.build was not updated to wire up this directory.
> 
> Fixes: bec00deaa8fb ("examples/ptp_tap_relay_sw: add PTP transparent clock relay")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Jerin Jacob <jerinj@marvell.com>
> ---
>  examples/meson.build | 1 +
>  1 file changed, 1 insertion(+)
> 
> diff --git a/examples/meson.build b/examples/meson.build
> index 25d9c88457..ab82cf5fbd 100644
> --- a/examples/meson.build
> +++ b/examples/meson.build
> @@ -43,6 +43,7 @@ all_examples = [
>          'packet_ordering',
>          'pipeline',
>          'ptpclient',
> +        'ptp_tap_relay_sw',
>          'qos_meter',
>          'qos_sched',
>          'rxtx_callbacks',

Minor nit, the ptp_tap_relay_sw line should be before ptpclient rather than
after, as word breaks or underscores count before "a" alphabetically,
rather than being skipped.

Otherwise:
Acked-by: Bruce Richardson <bruce.richardson@intel.com>


> -- 
> 2.54.0
> 

[dpdk-dev] [PATCH v2] examples/ptp_tap_relay_sw: fix build inclusion

[jerinj]

From: Jerin Jacob <jerinj@marvell.com>

The ptp_tap_relay_sw example was not building because
examples/meson.build was not updated to wire up this directory.

Fixes: bec00deaa8fb ("examples/ptp_tap_relay_sw: add PTP transparent clock relay")
Cc: stable@dpdk.org

Signed-off-by: Jerin Jacob <jerinj@marvell.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
v2:
- fix the order in meson file(Bruce)

 examples/meson.build | 1 +
 1 file changed, 1 insertion(+)

diff --git a/examples/meson.build b/examples/meson.build
index 25d9c88457..7d2b7716c1 100644
--- a/examples/meson.build
+++ b/examples/meson.build
@@ -42,6 +42,7 @@ all_examples = [
         'ntb',
         'packet_ordering',
         'pipeline',
+        'ptp_tap_relay_sw',
         'ptpclient',
         'qos_meter',
         'qos_sched',
-- 
2.54.0