[PATCH] common/cnxk: fix duplicate mbox alloc in NPA aura pool init

[PATCH] common/cnxk: fix duplicate mbox alloc in NPA aura pool init

[Amiya Ranjan Mohakud]

npa_aura_pool_init() allocates the pool init mbox message twice on
non-CN20K platforms. The if/else block at line 106-111 allocates via
the model-specific branch, but the original unconditional allocation
at line 112 was not removed when the CN20K branch was added. This
overwrites pool_init_req, and the orphaned first message is sent to
the AF with uninitialized aura_id, ctype, and op fields, which can
trigger any undesired behavior on CN10K.

Remove the duplicate allocation.

Fixes: 143a419edf35 ("common/cnxk: use new NPA aq enq mbox for CN20K")
Cc: asekhar@marvell.com
Cc: stable@dpdk.org

Signed-off-by: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
---
 drivers/common/cnxk/roc_npa.c | 1 -
 1 file changed, 1 deletion(-)

diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
index 4a3e96a97a..87f7637e9f 100644
--- a/drivers/common/cnxk/roc_npa.c
+++ b/drivers/common/cnxk/roc_npa.c
@@ -110,7 +110,6 @@ npa_aura_pool_init(struct mbox *m_box, uint32_t aura_id, struct npa_aura_s *aura
 	} else {
 		pool_init_req = mbox_alloc_msg_npa_aq_enq(mbox);
 	}
-	pool_init_req = mbox_alloc_msg_npa_aq_enq(mbox);
 	if (pool_init_req == NULL)
 		goto exit;
 	pool_init_req->aura_id = aura_id;
-- 
2.39.5 (Apple Git-154)

Re: [PATCH] common/cnxk: fix duplicate mbox alloc in NPA aura pool init

[Amiya Ranjan Mohakud]

[-- Attachment #1: Type: text/plain, Size: 1517 bytes --]

Recheck-request: iol-intel-Performance

Thanks
Amiya


On Fri, 4 Sept 2026 at 14:52, Amiya Ranjan Mohakud <
amiyaranjan.mohakud@gmail.com> wrote:

> npa_aura_pool_init() allocates the pool init mbox message twice on
> non-CN20K platforms. The if/else block at line 106-111 allocates via
> the model-specific branch, but the original unconditional allocation
> at line 112 was not removed when the CN20K branch was added. This
> overwrites pool_init_req, and the orphaned first message is sent to
> the AF with uninitialized aura_id, ctype, and op fields, which can
> trigger any undesired behavior on CN10K.
>
> Remove the duplicate allocation.
>
> Fixes: 143a419edf35 ("common/cnxk: use new NPA aq enq mbox for CN20K")
> Cc: asekhar@marvell.com
> Cc: stable@dpdk.org
>
> Signed-off-by: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
> ---
>  drivers/common/cnxk/roc_npa.c | 1 -
>  1 file changed, 1 deletion(-)
>
> diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
> index 4a3e96a97a..87f7637e9f 100644
> --- a/drivers/common/cnxk/roc_npa.c
> +++ b/drivers/common/cnxk/roc_npa.c
> @@ -110,7 +110,6 @@ npa_aura_pool_init(struct mbox *m_box, uint32_t
> aura_id, struct npa_aura_s *aura
>         } else {
>                 pool_init_req = mbox_alloc_msg_npa_aq_enq(mbox);
>         }
> -       pool_init_req = mbox_alloc_msg_npa_aq_enq(mbox);
>         if (pool_init_req == NULL)
>                 goto exit;
>         pool_init_req->aura_id = aura_id;
> --
> 2.39.5 (Apple Git-154)
>
>

[-- Attachment #2: Type: text/html, Size: 2431 bytes --]

Re: [PATCH] common/cnxk: fix duplicate mbox alloc in NPA aura pool init

[Amiya Ranjan Mohakud]

[-- Attachment #1: Type: text/plain, Size: 1842 bytes --]

Hi Team

The change-set has no relation to the intel performance test which is
failing. Could someone pls guide on how to get rid of this, get it reviewed
and merged?

Thanks
Amiya


On Wed, 9 Sept 2026 at 16:26, Amiya Ranjan Mohakud <
amiyaranjan.mohakud@gmail.com> wrote:

> Recheck-request: iol-intel-Performance
>
> Thanks
> Amiya
>
>
> On Fri, 4 Sept 2026 at 14:52, Amiya Ranjan Mohakud <
> amiyaranjan.mohakud@gmail.com> wrote:
>
>> npa_aura_pool_init() allocates the pool init mbox message twice on
>> non-CN20K platforms. The if/else block at line 106-111 allocates via
>> the model-specific branch, but the original unconditional allocation
>> at line 112 was not removed when the CN20K branch was added. This
>> overwrites pool_init_req, and the orphaned first message is sent to
>> the AF with uninitialized aura_id, ctype, and op fields, which can
>> trigger any undesired behavior on CN10K.
>>
>> Remove the duplicate allocation.
>>
>> Fixes: 143a419edf35 ("common/cnxk: use new NPA aq enq mbox for CN20K")
>> Cc: asekhar@marvell.com
>> Cc: stable@dpdk.org
>>
>> Signed-off-by: Amiya Ranjan Mohakud <amiyaranjan.mohakud@gmail.com>
>> ---
>>  drivers/common/cnxk/roc_npa.c | 1 -
>>  1 file changed, 1 deletion(-)
>>
>> diff --git a/drivers/common/cnxk/roc_npa.c b/drivers/common/cnxk/roc_npa.c
>> index 4a3e96a97a..87f7637e9f 100644
>> --- a/drivers/common/cnxk/roc_npa.c
>> +++ b/drivers/common/cnxk/roc_npa.c
>> @@ -110,7 +110,6 @@ npa_aura_pool_init(struct mbox *m_box, uint32_t
>> aura_id, struct npa_aura_s *aura
>>         } else {
>>                 pool_init_req = mbox_alloc_msg_npa_aq_enq(mbox);
>>         }
>> -       pool_init_req = mbox_alloc_msg_npa_aq_enq(mbox);
>>         if (pool_init_req == NULL)
>>                 goto exit;
>>         pool_init_req->aura_id = aura_id;
>> --
>> 2.39.5 (Apple Git-154)
>>
>>

[-- Attachment #2: Type: text/html, Size: 3543 bytes --]