* [PATCH] net/txgbe: fix FDIR devarg integer width
@ 2026-09-09 17:39 Zhang Tengfei
2026-09-09 20:42 ` Stephen Hemminger
0 siblings, 1 reply; 2+ messages in thread
From: Zhang Tengfei @ 2026-09-09 17:39 UTC (permalink / raw)
To: Jiawen Wu, Zaiyu Wang, Stephen Hemminger; +Cc: dev, stable, Zhang Tengfei
txgbe_handle_devarg() stores a uint16_t through extra_args, but
pballoc and drop_queue were u8. Setting pkt-filter-size overwrote
the adjacent drop_queue default.
Fixes: 7e18be9beef2 ("net/txgbe: add device arguments for FDIR")
Cc: stable@dpdk.org
Signed-off-by: Zhang Tengfei <zhtfdev@gmail.com>
---
drivers/net/txgbe/txgbe_ethdev.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/txgbe/txgbe_ethdev.c b/drivers/net/txgbe/txgbe_ethdev.c
index 4d2746371b..814840b3f5 100644
--- a/drivers/net/txgbe/txgbe_ethdev.c
+++ b/drivers/net/txgbe/txgbe_ethdev.c
@@ -533,8 +533,8 @@ txgbe_parse_devargs(struct rte_eth_dev *dev)
u16 ffe_pre = 8;
u16 ffe_post = 44;
/* FDIR args */
- u8 pballoc = 0;
- u8 drop_queue = 127;
+ u16 pballoc = 0;
+ u16 drop_queue = 127;
/* New devargs for amberlite config */
u16 tx_headwb = 1;
u16 tx_headwb_size = 16;
--
2.55.0
^ permalink raw reply related [flat|nested] 2+ messages in thread* Re: [PATCH] net/txgbe: fix FDIR devarg integer width
2026-09-09 17:39 [PATCH] net/txgbe: fix FDIR devarg integer width Zhang Tengfei
@ 2026-09-09 20:42 ` Stephen Hemminger
0 siblings, 0 replies; 2+ messages in thread
From: Stephen Hemminger @ 2026-09-09 20:42 UTC (permalink / raw)
To: Zhang Tengfei; +Cc: Jiawen Wu, Zaiyu Wang, dev, stable
On Thu, 10 Sep 2026 01:39:46 +0800
Zhang Tengfei <zhtfdev@gmail.com> wrote:
> txgbe_handle_devarg() stores a uint16_t through extra_args, but
> pballoc and drop_queue were u8. Setting pkt-filter-size overwrote
> the adjacent drop_queue default.
>
> Fixes: 7e18be9beef2 ("net/txgbe: add device arguments for FDIR")
> Cc: stable@dpdk.org
>
> Signed-off-by: Zhang Tengfei <zhtfdev@gmail.com>
> ---
Applied to next-net.
Review saw another issue in devarg handling, sent followup patch for that.
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-09 20:42 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-09 17:39 [PATCH] net/txgbe: fix FDIR devarg integer width Zhang Tengfei
2026-09-09 20:42 ` Stephen Hemminger
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox