DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Artem Novikov <naa@amicon.ru>
To: <bruce.richardson@intel.com>, <anatoly.burakov@intel.com>
Cc: <dev@dpdk.org>, <naa@amicon.ru>, <rrv@amicon.ru>,
	<lvc-project@linuxtesting.org>, <ting.xu@intel.com>,
	<stable@dpdk.org>
Subject: [PATCH] net/ice: remove unreachable DCF scheduler branch
Date: Mon, 14 Sep 2026 13:03:50 +0300	[thread overview]
Message-ID: <20260914100350.53842-1-naa@amicon.ru> (raw)

Non-leaf node validation rejects any non-NULL WFQ weight mode before
checking the SP priority count. Therefore the later else-if branch
cannot be reached, because wfq_weight_mode is guaranteed to be NULL at
that point.

Remove the dead branch to avoid keeping an impossible validation path in
the DCF scheduler parameter checks.

Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")
Cc: stable@dpdk.org
Cc: ting.xu@intel.com

Signed-off-by: Artem Novikov <naa@amicon.ru>
---
 drivers/net/intel/ice/ice_dcf_sched.c | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/drivers/net/intel/ice/ice_dcf_sched.c b/drivers/net/intel/ice/ice_dcf_sched.c
index 795b6e683d..5895407331 100644
--- a/drivers/net/intel/ice/ice_dcf_sched.c
+++ b/drivers/net/intel/ice/ice_dcf_sched.c
@@ -188,12 +188,6 @@ ice_dcf_node_param_check(struct ice_dcf_hw *hw, uint32_t node_id,
 				RTE_TM_ERROR_TYPE_NODE_PARAMS_N_SP_PRIORITIES;
 			error->message = "SP priority not supported";
 			return -EINVAL;
-		} else if (params->nonleaf.wfq_weight_mode &&
-			   !(*params->nonleaf.wfq_weight_mode)) {
-			error->type =
-				RTE_TM_ERROR_TYPE_NODE_PARAMS_WFQ_WEIGHT_MODE;
-			error->message = "WFP should be byte mode";
-			return -EINVAL;
 		}
 
 		return 0;
-- 
2.43.0


             reply	other threads:[~2026-09-14 11:49 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-14 10:03 Artem Novikov [this message]
2026-09-14 11:18 ` [PATCH] net/ice: remove unreachable DCF scheduler branch Bruce Richardson
2026-10-05 15:20   ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260914100350.53842-1-naa@amicon.ru \
    --to=naa@amicon.ru \
    --cc=anatoly.burakov@intel.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --cc=lvc-project@linuxtesting.org \
    --cc=rrv@amicon.ru \
    --cc=stable@dpdk.org \
    --cc=ting.xu@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox