From: Bruce Richardson <bruce.richardson@intel.com>
To: <dev@dpdk.org>
Cc: <anatoly.burakov@intel.com>, <stable@dpdk.org>
Subject: Re: [PATCH] net/ice: remove unreachable DCF scheduler branch
Date: Mon, 5 Oct 2026 16:20:14 +0100 [thread overview]
Message-ID: <asPALjjwfL70P0gj@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <aqfX8267lXdvGhXd@bricha3-mobl1.ger.corp.intel.com>
On Mon, Sep 14, 2026 at 12:18:11PM +0100, Bruce Richardson wrote:
> On Mon, Sep 14, 2026 at 01:03:50PM +0300, Artem Novikov wrote:
> > Non-leaf node validation rejects any non-NULL WFQ weight mode before
> > checking the SP priority count. Therefore the later else-if branch
> > cannot be reached, because wfq_weight_mode is guaranteed to be NULL at
> > that point.
> >
> > Remove the dead branch to avoid keeping an impossible validation path in
> > the DCF scheduler parameter checks.
> >
> > Fixes: 3a6bfc37eaf4 ("net/ice: support QoS config VF bandwidth in DCF")
> > Cc: stable@dpdk.org
> > Cc: ting.xu@intel.com
> >
> > Signed-off-by: Artem Novikov <naa@amicon.ru>
> > ---
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
prev parent reply other threads:[~2026-10-05 15:20 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-14 10:03 [PATCH] net/ice: remove unreachable DCF scheduler branch Artem Novikov
2026-09-14 11:18 ` Bruce Richardson
2026-10-05 15:20 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=asPALjjwfL70P0gj@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox