From: Stephen Hemminger <stephen@networkplumber.org>
To: Raslan Darawsheh <rasland@nvidia.com>
Cc: David Marchand <david.marchand@redhat.com>,
dev@dpdk.org, stable@dpdk.org,
Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>,
Bing Zhao <bingz@nvidia.com>, Ori Kam <orika@nvidia.com>,
Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>
Subject: Re: [PATCH 1/2] net/mlx5: fix promiscuous inconsistency on port start
Date: Wed, 23 Sep 2026 08:44:05 -0700 [thread overview]
Message-ID: <20260923084405.6f0123c2@phoenix.local> (raw)
In-Reply-To: <4deac670-704e-4529-8b15-2289ec77616a@nvidia.com>
On Mon, 31 Aug 2026 18:40:48 +0300
Raslan Darawsheh <rasland@nvidia.com> wrote:
> Hi,
>
>
> On 31/07/2026 12:23 PM, David Marchand wrote:
> > The kernel netdev promiscuous or all multicast mode could be enabled
> > before DPDK starts the port. This would cause an inconsistency between
> > the kernel state and DPDK's expected state
> > (dev->data->promiscuous / dev->data->all_multicast).
> >
> > Add mlx5_os_get_promisc() and mlx5_os_get_allmulti() to query the
> > current kernel state via netlink. On port start, compare the kernel
> > state with DPDK's state and sync if they differ.
> >
> > On Windows, these getters always return false as there seems to be no
> > API for getting the states.
> >
> > Fixes: dd4bb90bc3cb ("net/mlx5: use Netlink to enable promisc/allmulti mode")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
>
> Series applied to next-net-mlx,
>
> Kindest regards
> Raslan Darawsheh
>
AI review found that there is potential issue if tcpdump is used on kernel side.
963565124c reset promiscuous modes on close — behaviorally deliberate, but the
condition is kernel state only, not "did DPDK set this." If an operator had
promiscuous mode on independently (tcpdump, a bridge port), closing a DPDK port
clears it and disrupts that unrelated user. Kernel promiscuity is refcounted
internally, but a netlink flag-set overrides that accounting rather than
decrementing it. Scoping to modes DPDK actually enabled would be safer.
prev parent reply other threads:[~2026-09-23 15:44 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 9:23 [PATCH 1/2] net/mlx5: fix promiscuous inconsistency on port start David Marchand
2026-07-31 9:23 ` [PATCH 2/2] net/mlx5: reset promiscuous modes on device close David Marchand
2026-08-25 8:17 ` Dariusz Sosnowski
2026-08-24 11:33 ` [PATCH 1/2] net/mlx5: fix promiscuous inconsistency on port start David Marchand
2026-08-25 8:17 ` Dariusz Sosnowski
2026-08-31 15:40 ` Raslan Darawsheh
2026-09-23 15:44 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260923084405.6f0123c2@phoenix.local \
--to=stephen@networkplumber.org \
--cc=adrien.mazarguil@6wind.com \
--cc=bingz@nvidia.com \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=orika@nvidia.com \
--cc=rasland@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox