From: David Marchand <david.marchand@redhat.com>
To: Dariusz Sosnowski <dsosnowski@nvidia.com>,
Viacheslav Ovsiienko <viacheslavo@nvidia.com>
Cc: dev@dpdk.org, stable@dpdk.org, Bing Zhao <bingz@nvidia.com>,
Ori Kam <orika@nvidia.com>, Suanming Mou <suanmingm@nvidia.com>,
Matan Azrad <matan@nvidia.com>,
Adrien Mazarguil <adrien.mazarguil@6wind.com>,
Nelio Laranjeiro <nelio.laranjeiro@6wind.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH 1/2] net/mlx5: fix promiscuous inconsistency on port start
Date: Mon, 24 Aug 2026 13:33:32 +0200 [thread overview]
Message-ID: <CAJFAV8xri+thHo6sBbFNBNxWMZ_yRB-RX5eaoros8aNTCecdCw@mail.gmail.com> (raw)
In-Reply-To: <20260731092332.3833632-1-david.marchand@redhat.com>
On Fri, 31 Jul 2026 at 11:24, David Marchand <david.marchand@redhat.com> wrote:
>
> The kernel netdev promiscuous or all multicast mode could be enabled
> before DPDK starts the port. This would cause an inconsistency between
> the kernel state and DPDK's expected state
> (dev->data->promiscuous / dev->data->all_multicast).
>
> Add mlx5_os_get_promisc() and mlx5_os_get_allmulti() to query the
> current kernel state via netlink. On port start, compare the kernel
> state with DPDK's state and sync if they differ.
>
> On Windows, these getters always return false as there seems to be no
> API for getting the states.
>
> Fixes: dd4bb90bc3cb ("net/mlx5: use Netlink to enable promisc/allmulti mode")
> Cc: stable@dpdk.org
>
> Signed-off-by: David Marchand <david.marchand@redhat.com>
Review please?
--
David Marchand
next prev parent reply other threads:[~2026-08-24 11:33 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-31 9:23 [PATCH 1/2] net/mlx5: fix promiscuous inconsistency on port start David Marchand
2026-07-31 9:23 ` [PATCH 2/2] net/mlx5: reset promiscuous modes on device close David Marchand
2026-08-25 8:17 ` Dariusz Sosnowski
2026-08-24 11:33 ` David Marchand [this message]
2026-08-25 8:17 ` [PATCH 1/2] net/mlx5: fix promiscuous inconsistency on port start Dariusz Sosnowski
2026-08-31 15:40 ` Raslan Darawsheh
2026-09-23 15:44 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=CAJFAV8xri+thHo6sBbFNBNxWMZ_yRB-RX5eaoros8aNTCecdCw@mail.gmail.com \
--to=david.marchand@redhat.com \
--cc=adrien.mazarguil@6wind.com \
--cc=bingz@nvidia.com \
--cc=dev@dpdk.org \
--cc=dsosnowski@nvidia.com \
--cc=matan@nvidia.com \
--cc=nelio.laranjeiro@6wind.com \
--cc=orika@nvidia.com \
--cc=stable@dpdk.org \
--cc=suanmingm@nvidia.com \
--cc=thomas@monjalon.net \
--cc=viacheslavo@nvidia.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox