DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>
Subject: [PATCH 1/2] net/nfp: remove redundant link up/down stubs
Date: Thu, 24 Sep 2026 09:09:23 -0700	[thread overview]
Message-ID: <20260924161104.335111-2-stephen@networkplumber.org> (raw)
In-Reply-To: <20260924161104.335111-1-stephen@networkplumber.org>

The VF ops nfp_netvf_set_link_up() and nfp_netvf_set_link_down() only
return -ENOTSUP. rte_eth_dev_set_link_up() and its down counterpart
already return -ENOTSUP when the dev_ops entry is NULL, so leaving the
fields unset gives the same result to the application.

These are VF-only; the PF table in nfp_ethdev.c keeps its real
implementations.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/nfp/nfp_ethdev_vf.c | 15 ---------------
 1 file changed, 15 deletions(-)

diff --git a/drivers/net/nfp/nfp_ethdev_vf.c b/drivers/net/nfp/nfp_ethdev_vf.c
index d81a5052b9..1ed86cfc9f 100644
--- a/drivers/net/nfp/nfp_ethdev_vf.c
+++ b/drivers/net/nfp/nfp_ethdev_vf.c
@@ -144,19 +144,6 @@ nfp_netvf_stop(struct rte_eth_dev *dev)
 	return 0;
 }
 
-static int
-nfp_netvf_set_link_up(struct rte_eth_dev *dev __rte_unused)
-{
-	return -ENOTSUP;
-}
-
-/* Set the link down. */
-static int
-nfp_netvf_set_link_down(struct rte_eth_dev *dev __rte_unused)
-{
-	return -ENOTSUP;
-}
-
 /* Reset and stop device. The device can not be restarted. */
 static int
 nfp_netvf_close(struct rte_eth_dev *dev)
@@ -203,8 +190,6 @@ static const struct eth_dev_ops nfp_netvf_eth_dev_ops = {
 	.dev_configure          = nfp_net_configure,
 	.dev_start              = nfp_netvf_start,
 	.dev_stop               = nfp_netvf_stop,
-	.dev_set_link_up        = nfp_netvf_set_link_up,
-	.dev_set_link_down      = nfp_netvf_set_link_down,
 	.dev_close              = nfp_netvf_close,
 	.promiscuous_enable     = nfp_net_promisc_enable,
 	.promiscuous_disable    = nfp_net_promisc_disable,
-- 
2.53.0


  reply	other threads:[~2026-09-24 16:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 16:09 [PATCH 0/2] remove redundant stubs Stephen Hemminger
2026-09-24 16:09 ` Stephen Hemminger [this message]
2026-09-24 16:09 ` [PATCH 2/2] net/cnxk: remove redundant IP reassembly conf get stubs Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924161104.335111-2-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox