DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Stephen Hemminger <stephen@networkplumber.org>
To: dev@dpdk.org
Cc: Stephen Hemminger <stephen@networkplumber.org>,
	Nithin Dabilpuram <ndabilpuram@marvell.com>,
	Kiran Kumar K <kirankumark@marvell.com>,
	Sunil Kumar Kori <skori@marvell.com>,
	Satha Rao <skoteshwar@marvell.com>,
	Harman Kalra <hkalra@marvell.com>
Subject: [PATCH 2/2] net/cnxk: remove redundant IP reassembly conf get stubs
Date: Thu, 24 Sep 2026 09:09:24 -0700	[thread overview]
Message-ID: <20260924161104.335111-3-stephen@networkplumber.org> (raw)
In-Reply-To: <20260924161104.335111-1-stephen@networkplumber.org>

cn10k_nix_reassembly_conf_get() and cn20k_nix_reassembly_conf_get() only
return -ENOTSUP, and they are the only writers of
cnxk_eth_dev_ops.ip_reassembly_conf_get in the tree. The field has no
initialiser in cnxk_eth_dev_ops, so dropping the assignments leaves it
NULL and rte_eth_ip_reassembly_conf_get() returns -ENOTSUP as before.

The sibling ip_reassembly_conf_set and ip_reassembly_capability_get ops
are real implementations and are left alone.

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/cnxk/cn10k_ethdev.c | 10 ----------
 drivers/net/cnxk/cn20k_ethdev.c | 10 ----------
 2 files changed, 20 deletions(-)

diff --git a/drivers/net/cnxk/cn10k_ethdev.c b/drivers/net/cnxk/cn10k_ethdev.c
index bcf4e23286..3f987a8195 100644
--- a/drivers/net/cnxk/cn10k_ethdev.c
+++ b/drivers/net/cnxk/cn10k_ethdev.c
@@ -645,15 +645,6 @@ cn10k_nix_reassembly_capability_get(struct rte_eth_dev *eth_dev,
 	return rc;
 }
 
-static int
-cn10k_nix_reassembly_conf_get(struct rte_eth_dev *eth_dev,
-		struct rte_eth_ip_reassembly_params *conf)
-{
-	RTE_SET_USED(eth_dev);
-	RTE_SET_USED(conf);
-	return -ENOTSUP;
-}
-
 static int
 cn10k_nix_reassembly_conf_set(struct rte_eth_dev *eth_dev,
 			      const struct rte_eth_ip_reassembly_params *conf)
@@ -883,7 +874,6 @@ nix_eth_dev_ops_override(void)
 		cn10k_nix_timesync_read_tx_timestamp;
 	cnxk_eth_dev_ops.ip_reassembly_capability_get =
 			cn10k_nix_reassembly_capability_get;
-	cnxk_eth_dev_ops.ip_reassembly_conf_get = cn10k_nix_reassembly_conf_get;
 	cnxk_eth_dev_ops.ip_reassembly_conf_set = cn10k_nix_reassembly_conf_set;
 	cnxk_eth_dev_ops.eth_rx_descriptor_dump = cn10k_rx_descriptor_dump;
 }
diff --git a/drivers/net/cnxk/cn20k_ethdev.c b/drivers/net/cnxk/cn20k_ethdev.c
index 9fac027650..c1a7916e6f 100644
--- a/drivers/net/cnxk/cn20k_ethdev.c
+++ b/drivers/net/cnxk/cn20k_ethdev.c
@@ -629,15 +629,6 @@ cn20k_nix_reassembly_capability_get(struct rte_eth_dev *eth_dev,
 	return 0;
 }
 
-static int
-cn20k_nix_reassembly_conf_get(struct rte_eth_dev *eth_dev,
-			      struct rte_eth_ip_reassembly_params *conf)
-{
-	RTE_SET_USED(eth_dev);
-	RTE_SET_USED(conf);
-	return -ENOTSUP;
-}
-
 static int
 cn20k_nix_reassembly_conf_set(struct rte_eth_dev *eth_dev,
 			      const struct rte_eth_ip_reassembly_params *conf)
@@ -928,7 +919,6 @@ nix_eth_dev_ops_override(void)
 	cnxk_eth_dev_ops.timesync_disable = cn20k_nix_timesync_disable;
 	cnxk_eth_dev_ops.timesync_read_tx_timestamp = cn20k_nix_timesync_read_tx_timestamp;
 	cnxk_eth_dev_ops.ip_reassembly_capability_get = cn20k_nix_reassembly_capability_get;
-	cnxk_eth_dev_ops.ip_reassembly_conf_get = cn20k_nix_reassembly_conf_get;
 	cnxk_eth_dev_ops.ip_reassembly_conf_set = cn20k_nix_reassembly_conf_set;
 	cnxk_eth_dev_ops.eth_rx_descriptor_dump = cn20k_rx_descriptor_dump;
 }
-- 
2.53.0


      parent reply	other threads:[~2026-09-24 16:18 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-24 16:09 [PATCH 0/2] remove redundant stubs Stephen Hemminger
2026-09-24 16:09 ` [PATCH 1/2] net/nfp: remove redundant link up/down stubs Stephen Hemminger
2026-09-24 16:09 ` Stephen Hemminger [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20260924161104.335111-3-stephen@networkplumber.org \
    --to=stephen@networkplumber.org \
    --cc=dev@dpdk.org \
    --cc=hkalra@marvell.com \
    --cc=kirankumark@marvell.com \
    --cc=ndabilpuram@marvell.com \
    --cc=skori@marvell.com \
    --cc=skoteshwar@marvell.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox