From: Ciara Loftus <ciara.loftus@intel.com>
To: dev@dpdk.org
Cc: anurag.mandal@intel.com, Ciara Loftus <ciara.loftus@intel.com>
Subject: [PATCH] net/iavf: fix dead store on reset path
Date: Fri, 25 Sep 2026 08:58:32 +0000 [thread overview]
Message-ID: <20260925085832.6780-1-ciara.loftus@intel.com> (raw)
When dev_start fails during reset recovery, the code defers the start
to the next link-up event and resets ret to 0 to avoid treating this
as an error. This is redundant since ret is unconditionally
overwritten by the return value of iavf_post_reset_reconfig()
immediately after. Remove the dead assignment.
Fixes: 9aac2219dc2a ("net/iavf: defer device start when PF VSI not ready")
Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
---
drivers/net/intel/iavf/iavf_ethdev.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c
index a8daa507bb..7915aef348 100644
--- a/drivers/net/intel/iavf/iavf_ethdev.c
+++ b/drivers/net/intel/iavf/iavf_ethdev.c
@@ -3513,7 +3513,6 @@ iavf_handle_hw_reset(struct rte_eth_dev *dev, bool vf_initiated_reset)
ret);
vf->start_pending = true;
dev->data->dev_started = 0;
- ret = 0;
}
}
--
2.43.0
next reply other threads:[~2026-09-25 8:58 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 8:58 Ciara Loftus [this message]
2026-09-25 12:04 ` [PATCH] net/iavf: fix dead store on reset path Burakov, Anatoly
2026-09-25 14:33 ` Loftus, Ciara
2026-09-25 14:52 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260925085832.6780-1-ciara.loftus@intel.com \
--to=ciara.loftus@intel.com \
--cc=anurag.mandal@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox