From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Ciara Loftus <ciara.loftus@intel.com>, <dev@dpdk.org>
Cc: <anurag.mandal@intel.com>
Subject: Re: [PATCH] net/iavf: fix dead store on reset path
Date: Fri, 25 Sep 2026 14:04:48 +0200 [thread overview]
Message-ID: <fc8d48f2-d451-4113-8c25-ba1df670cff7@intel.com> (raw)
In-Reply-To: <20260925085832.6780-1-ciara.loftus@intel.com>
On 9/25/2026 10:58 AM, Ciara Loftus wrote:
> When dev_start fails during reset recovery, the code defers the start
> to the next link-up event and resets ret to 0 to avoid treating this
> as an error. This is redundant since ret is unconditionally
> overwritten by the return value of iavf_post_reset_reconfig()
> immediately after. Remove the dead assignment.
>
> Fixes: 9aac2219dc2a ("net/iavf: defer device start when PF VSI not ready")
>
> Signed-off-by: Ciara Loftus <ciara.loftus@intel.com>
> ---
I wouldn't really qualify this as a bug fix except maybe static analysis
tools might flag it so perhaps having a Fixes tag is worth it.
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2026-09-25 12:05 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-25 8:58 [PATCH] net/iavf: fix dead store on reset path Ciara Loftus
2026-09-25 12:04 ` Burakov, Anatoly [this message]
2026-09-25 14:33 ` Loftus, Ciara
2026-09-25 14:52 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=fc8d48f2-d451-4113-8c25-ba1df670cff7@intel.com \
--to=anatoly.burakov@intel.com \
--cc=anurag.mandal@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox