From: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
To: dev@dpdk.org
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Carolyn Wyborny <carolyn.wyborny@intel.com>,
Piotr Kwapulinski <piotr.kwapulinski@intel.com>,
Jedrzej Jagielski <jedrzej.jagielski@intel.com>,
stable@dpdk.org,
Sandeep Penigalapati <sandeep.penigalapati@intel.com>
Subject: [PATCH] net/ixgbe: fix null dereference on EEPROM write for E610
Date: Mon, 28 Sep 2026 12:50:54 -0400 [thread overview]
Message-ID: <20260928165054.20913-1-sandeep.penigalapati@intel.com> (raw)
E610 does not support EEPROM writes and leaves eeprom.ops.write_buffer
as NULL. ixgbe_set_eeprom() calls this pointer without checking it,
causing a NULL pointer dereference when a set-eeprom request is issued
on an E610 port.
Check the op for NULL and return -ENOTSUP instead.
Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device")
Cc: stable@dpdk.org
Signed-off-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
---
drivers/net/intel/ixgbe/ixgbe_ethdev.c | 3 +++
1 file changed, 3 insertions(+)
diff --git a/drivers/net/intel/ixgbe/ixgbe_ethdev.c b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
index 78e19f94c0..c653951858 100644
--- a/drivers/net/intel/ixgbe/ixgbe_ethdev.c
+++ b/drivers/net/intel/ixgbe/ixgbe_ethdev.c
@@ -7370,6 +7370,9 @@ ixgbe_set_eeprom(struct rte_eth_dev *dev,
in_eeprom->magic = hw->vendor_id | (hw->device_id << 16);
+ if (eeprom->ops.write_buffer == NULL)
+ return -ENOTSUP;
+
return eeprom->ops.write_buffer(hw, first, length, data);
}
--
2.27.0
next reply other threads:[~2026-09-28 9:48 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 16:50 Sandeep Penigalapati [this message]
2026-09-28 10:36 ` [PATCH] net/ixgbe: fix null dereference on EEPROM write for E610 Bruce Richardson
2026-09-28 20:12 ` [PATCH v2] " Sandeep Penigalapati
2026-09-28 13:14 ` Bruce Richardson
2026-09-28 13:44 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928165054.20913-1-sandeep.penigalapati@intel.com \
--to=sandeep.penigalapati@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=carolyn.wyborny@intel.com \
--cc=dev@dpdk.org \
--cc=jedrzej.jagielski@intel.com \
--cc=piotr.kwapulinski@intel.com \
--cc=stable@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox