From: Bruce Richardson <bruce.richardson@intel.com>
To: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH v2] net/ixgbe: fix null dereference on EEPROM write for E610
Date: Mon, 28 Sep 2026 14:44:41 +0100 [thread overview]
Message-ID: <arpvScl2Kh_nt2cj@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <arpoI5ltCdcblnwI@bricha3-mobl1.ger.corp.intel.com>
On Mon, Sep 28, 2026 at 02:14:11PM +0100, Bruce Richardson wrote:
> On Mon, Sep 28, 2026 at 04:12:53PM -0400, Sandeep Penigalapati wrote:
> > E610 does not support EEPROM writes and leaves eeprom.ops.write_buffer
> > as NULL. ixgbe_set_eeprom() calls this pointer without checking it,
> > causing a NULL pointer dereference when a set-eeprom request is issued
> > on an E610 port.
> >
> > Check the op for NULL and return -ENOTSUP instead.
> >
> > Fixes: 316637762a5f ("net/ixgbe/base: enable E610 device")
> > Cc: stable@dpdk.org
> >
> > Signed-off-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
Applied to dpdk-next-net-intel.
Thanks,
/Bruce
prev parent reply other threads:[~2026-09-28 13:44 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 16:50 [PATCH] net/ixgbe: fix null dereference on EEPROM write for E610 Sandeep Penigalapati
2026-09-28 10:36 ` Bruce Richardson
2026-09-28 20:12 ` [PATCH v2] " Sandeep Penigalapati
2026-09-28 13:14 ` Bruce Richardson
2026-09-28 13:44 ` Bruce Richardson [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=arpvScl2Kh_nt2cj@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=sandeep.penigalapati@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox