From: Omar Munchaev <omarmunchaev@gmail.com>
To: dev@dpdk.org
Cc: Omar Munchaev <omar.munchaev@gmail.com>,
stable@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>,
Anatoly Burakov <anatoly.burakov@intel.com>
Subject: [PATCH] net/ice: fix missing type casts for flex descriptors
Date: Tue, 29 Sep 2026 00:27:58 +0700 [thread overview]
Message-ID: <20260928172759.3369704-1-omar.munchaev@gmail.com> (raw)
When ice driver was ported to use the common Rx descriptor format,
some type casts were missed. Add them.
Fixes: e70342ba90a83 ("net/ice: use common Rx queue structure")
Cc: stable@dpdk.org
Signed-off-by: Omar Munchaev <omar.munchaev@gmail.com>
---
drivers/net/intel/ice/ice_rxtx.c | 20 ++++++++++----------
1 file changed, 10 insertions(+), 10 deletions(-)
diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c
index b333444cbf..882af80833 100644
--- a/drivers/net/intel/ice/ice_rxtx.c
+++ b/drivers/net/intel/ice/ice_rxtx.c
@@ -2698,7 +2698,7 @@ ice_fdir_setup_rx_resources(struct ice_pf *pf)
}
/* Allocate RX hardware ring descriptors. */
- ring_size = sizeof(union ice_32byte_rx_desc) * ICE_FDIR_NUM_RX_DESC;
+ ring_size = sizeof(union ci_rx_flex_desc) * ICE_FDIR_NUM_RX_DESC;
ring_size = RTE_ALIGN(ring_size, ICE_DMA_MEM_ALIGN);
rz = rte_eth_dma_zone_reserve(dev, "fdir_rx_ring",
@@ -2718,7 +2718,7 @@ ice_fdir_setup_rx_resources(struct ice_pf *pf)
rxq->rx_ring_phys_addr = rz->iova;
memset(rz->addr, 0, ICE_FDIR_NUM_RX_DESC *
- sizeof(union ice_32byte_rx_desc));
+ sizeof(union ci_rx_flex_desc));
rxq->rx_flex_ring = (union ci_rx_flex_desc *)rz->addr;
/*
@@ -4464,15 +4464,15 @@ ice_set_default_ptype_table(struct rte_eth_dev *dev)
static inline int
ice_check_fdir_programming_status(struct ci_rx_queue *rxq)
{
- volatile union ice_32byte_rx_desc *rxdp;
- uint64_t qword1;
- uint32_t rx_status;
- uint32_t error;
- uint32_t id;
+ volatile union ci_rx_flex_desc *rxdp;
+ uint16_t qword1;
+ uint16_t rx_status;
+ uint16_t error;
+ uint16_t id;
int ret = -EAGAIN;
- rxdp = (volatile union ice_32byte_rx_desc *)&rxq->rx_flex_ring[rxq->rx_tail];
- qword1 = rte_le_to_cpu_64(rxdp->wb.qword1.status_error_len);
+ rxdp = &rxq->rx_flex_ring[rxq->rx_tail];
+ qword1 = rte_le_to_cpu_16(rxdp->wb.status_error0);
rx_status = (qword1 & ICE_RXD_QW1_STATUS_M)
>> ICE_RXD_QW1_STATUS_S;
@@ -4497,7 +4497,7 @@ ice_check_fdir_programming_status(struct ci_rx_queue *rxq)
ret = -EINVAL;
}
err:
- rxdp->wb.qword1.status_error_len = 0;
+ rxdp->wb.status_error0 = 0;
rxq->rx_tail++;
if (unlikely(rxq->rx_tail == rxq->nb_rx_desc))
rxq->rx_tail = 0;
--
2.55.0
next reply other threads:[~2026-09-29 5:42 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-28 17:27 Omar Munchaev [this message]
2026-09-28 17:27 ` [PATCH] net/ice: use macros to get field values Omar Munchaev
2026-10-06 14:30 ` Burakov, Anatoly
2026-10-06 15:06 ` Bruce Richardson
2026-10-06 15:09 ` Bruce Richardson
2026-10-06 14:21 ` [PATCH] net/ice: fix missing type casts for flex descriptors Burakov, Anatoly
2026-10-06 14:31 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260928172759.3369704-1-omar.munchaev@gmail.com \
--to=omarmunchaev@gmail.com \
--cc=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=omar.munchaev@gmail.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox