Re: [PATCH] net/ice: use macros to get field values

[Bruce Richardson <bruce.richardson@intel.com>]

On Tue, Oct 06, 2026 at 04:30:00PM +0200, Burakov, Anatoly wrote:
> On 9/28/2026 7:27 PM, Omar Munchaev wrote:
> > Currently, in ice_check_fdir_programming_status,
> > descriptor fields are accessed through direct
> > bit mask manipulation and shifts.
> > The ice driver has macros for this, so rewrite the function
> > to use FIELD_GET macros instead.
> > 
> > Signed-off-by: Omar Munchaev <omar.munchaev@gmail.com>
> > ---
> >   drivers/net/intel/ice/ice_rxtx.c | 37 ++++++++++++--------------------
> >   1 file changed, 14 insertions(+), 23 deletions(-)
> > 
> > diff --git a/drivers/net/intel/ice/ice_rxtx.c b/drivers/net/intel/ice/ice_rxtx.c
> > index 882af80833..f14e5e56b5 100644
> > --- a/drivers/net/intel/ice/ice_rxtx.c
> > +++ b/drivers/net/intel/ice/ice_rxtx.c
> > @@ -4465,36 +4465,27 @@ static inline int
> >   ice_check_fdir_programming_status(struct ci_rx_queue *rxq)
> >   {
> >   	volatile union ci_rx_flex_desc *rxdp;
> > -	uint16_t qword1;
> > -	uint16_t rx_status;
> > -	uint16_t error;
> > -	uint16_t id;
> > +	uint32_t stat_err, error, id
> 
> Missing semicolon, so the build fails. Please run
> `devtools/test-meson-builds.sh` script before submission. When submitting
> new versions of the patch, you should increment the version, and the
> patchset also does not have proper threading. Please refer to contribution
> guidelines[1] for how to do this correctly.
> 
> [1] https://core.dpdk.org/contribute/
> 
> That said, the rest of it looks fine to me, so the semicolon issue can be
> fixed on apply.
> 
> Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
> 
Given the missing semicolon, I decided to ask AI to review this patch
before I committed the patch with the small fix. It flags one logic issue
with it:

  Finding: FDIR successes are reported as timeouts. In ice_rxtx.c:4469, ret
  starts as -EAGAIN and is never set to 0 when a completed descriptor has no
  error. The caller treats -EAGAIN as “keep waiting” (ice_rxtx.c:4550), so it
  consumes the successful completion, continues polling, and eventually
  returns -ETIMEDOUT. Set ret = 0 when DD is present and both failure checks
  pass.

This finding looks right to me. ret is set to -EAGAIN at line 4469 and set
to a zero value nowhere else in the function.

/Bruce