From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: Yipeng Wang <yipeng1.wang@intel.com>,
Sameh Gobriel <sameh.gobriel@intel.com>,
Bruce Richardson <bruce.richardson@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>,
Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: [PATCH] hash: fix GFNI helpers for building with -O0
Date: Wed, 30 Sep 2026 10:49:08 +0200 [thread overview]
Message-ID: <20260930084908.72055-1-david.marchand@redhat.com> (raw)
Similarly to commit da31ef54c865 ("hash: fix GFNI stubs export"),
fix "internal" helpers used by public inline helpers by removing the
incorrect __rte_internal annotation.
The issue is usually not seen as those helpers get inlined under
standard compiler optimization level, but it becomes visible when
building with -O0.
Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
lib/hash/rte_thash_x86_gfni.h | 3 ---
1 file changed, 3 deletions(-)
diff --git a/lib/hash/rte_thash_x86_gfni.h b/lib/hash/rte_thash_x86_gfni.h
index 69973503fd..e5abdf2474 100644
--- a/lib/hash/rte_thash_x86_gfni.h
+++ b/lib/hash/rte_thash_x86_gfni.h
@@ -13,7 +13,6 @@
*/
#include <rte_bitops.h>
-#include <rte_compat.h>
#include <rte_vect.h>
#ifdef __cplusplus
@@ -29,7 +28,6 @@ extern "C" {
#define RTE_THASH_PERM_MSK_2 0xf0f0f0f0f0f0f0f0
#define RTE_THASH_REWIND_MSK 0x0000000000113377
-__rte_internal
static inline void
__rte_thash_xor_reduce(__m512i xor_acc, uint32_t *val_1, uint32_t *val_2)
{
@@ -64,7 +62,6 @@ __rte_thash_xor_reduce(__m512i xor_acc, uint32_t *val_1, uint32_t *val_2)
#endif
}
-__rte_internal
static inline __m512i
__rte_thash_gfni(const uint64_t *mtrx, const uint8_t *tuple,
const uint8_t *secondary_tuple, int len)
--
2.54.0
next reply other threads:[~2026-09-30 8:49 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-30 8:49 David Marchand [this message]
2026-09-30 8:53 ` [PATCH] hash: fix GFNI helpers for building with -O0 Bruce Richardson
2026-09-30 9:17 ` David Marchand
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20260930084908.72055-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=sameh.gobriel@intel.com \
--cc=vladimir.medvedkin@intel.com \
--cc=yipeng1.wang@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox