[PATCH] hash: fix GFNI helpers for building with -O0

[PATCH] hash: fix GFNI helpers for building with -O0

[David Marchand]

Similarly to commit da31ef54c865 ("hash: fix GFNI stubs export"),
fix "internal" helpers used by public inline helpers by removing the
incorrect __rte_internal annotation.

The issue is usually not seen as those helpers get inlined under
standard compiler optimization level, but it becomes visible when
building with -O0.

Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation")

Signed-off-by: David Marchand <david.marchand@redhat.com>
---
 lib/hash/rte_thash_x86_gfni.h | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/lib/hash/rte_thash_x86_gfni.h b/lib/hash/rte_thash_x86_gfni.h
index 69973503fd..e5abdf2474 100644
--- a/lib/hash/rte_thash_x86_gfni.h
+++ b/lib/hash/rte_thash_x86_gfni.h
@@ -13,7 +13,6 @@
  */
 
 #include <rte_bitops.h>
-#include <rte_compat.h>
 #include <rte_vect.h>
 
 #ifdef __cplusplus
@@ -29,7 +28,6 @@ extern "C" {
 #define RTE_THASH_PERM_MSK_2		0xf0f0f0f0f0f0f0f0
 #define RTE_THASH_REWIND_MSK		0x0000000000113377
 
-__rte_internal
 static inline void
 __rte_thash_xor_reduce(__m512i xor_acc, uint32_t *val_1, uint32_t *val_2)
 {
@@ -64,7 +62,6 @@ __rte_thash_xor_reduce(__m512i xor_acc, uint32_t *val_1, uint32_t *val_2)
 #endif
 }
 
-__rte_internal
 static inline __m512i
 __rte_thash_gfni(const uint64_t *mtrx, const uint8_t *tuple,
 	const uint8_t *secondary_tuple, int len)
-- 
2.54.0

Re: [PATCH] hash: fix GFNI helpers for building with -O0

[Bruce Richardson]

On Wed, Sep 30, 2026 at 10:49:08AM +0200, David Marchand wrote:
> Similarly to commit da31ef54c865 ("hash: fix GFNI stubs export"),
> fix "internal" helpers used by public inline helpers by removing the
> incorrect __rte_internal annotation.
> 
> The issue is usually not seen as those helpers get inlined under
> standard compiler optimization level, but it becomes visible when
> building with -O0.
> 
> Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation")
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  lib/hash/rte_thash_x86_gfni.h | 3 ---
>  1 file changed, 3 deletions(-)
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH] hash: fix GFNI helpers for building with -O0

[David Marchand]

On Wed, 30 Sept 2026 at 10:53, Bruce Richardson
<bruce.richardson@intel.com> wrote:
>
> On Wed, Sep 30, 2026 at 10:49:08AM +0200, David Marchand wrote:
> > Similarly to commit da31ef54c865 ("hash: fix GFNI stubs export"),
> > fix "internal" helpers used by public inline helpers by removing the
> > incorrect __rte_internal annotation.
> >
> > The issue is usually not seen as those helpers get inlined under
> > standard compiler optimization level, but it becomes visible when
> > building with -O0.
> >
> > Fixes: 4fd8c4cb0de1 ("hash: add new Toeplitz hash implementation")
> >
> > Signed-off-by: David Marchand <david.marchand@redhat.com>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks.


-- 
David Marchand