From: Marat Khalili <qm2k21@gmail.com>
To: Konstantin Ananyev <konstantin.ananyev@huawei.com>,
Marat Khalili <qm2k21@gmail.com>
Cc: dev@dpdk.org, stephen@networkplumber.org
Subject: [PATCH 7/9] bpf: reformat packet callback unload diagram
Date: Sun, 11 Oct 2026 18:21:55 +0000 [thread overview]
Message-ID: <20261011182158.124246-8-qm2k21@gmail.com> (raw)
In-Reply-To: <20261011182158.124246-1-qm2k21@gmail.com>
Reformat the CP-DP synchronization sequence diagram in bpf_pkt.c by
removing unnecessary vertical lines and re-centering arrow labels.
This comment-only commit is intentionally kept separate to make the
diff of the preceding semantic change more readable.
Signed-off-by: Marat Khalili <qm2k21@gmail.com>
---
lib/bpf/bpf_pkt.c | 22 +++++++++-------------
1 file changed, 9 insertions(+), 13 deletions(-)
diff --git a/lib/bpf/bpf_pkt.c b/lib/bpf/bpf_pkt.c
index 7ae64ed7d0..ea7e240494 100644
--- a/lib/bpf/bpf_pkt.c
+++ b/lib/bpf/bpf_pkt.c
@@ -52,27 +52,23 @@
* | | | | | |
* | |<---------------------- fetch callback -----------------------|
* | | | | | |
- * | | |<------------- store 1 -----------------------|
+ * | | |<------------------ store 1 ------------------|
* | | | | | |
* |-- remove callback -->| | | | rte_smp_mb()
* | | | | | |
* | | | |<------ fetch non-NULL --------|
* | | | | | |
- * |------------------- store NULL --------------------->| | |
- * | | | | | |
- * rte_smp_mb() | | | | |
- * | | | | | |
- * +-while use is 1 | | | | if cb not NULL-+
- * | | | | | | | |
- * | +------------ fetch 1 -------------->| | |<-- execute --+ |
- * | | | | | | BPF program | |
- * | | | | | | +-+
+ * |------------------- store NULL --------------------->| | if cb not NULL-+
+ * | | | | | | |
+ * rte_smp_mb() | | | |<-- execute --+ |
+ * | | | | | BPF program | |
+ * +-while use is 1 | | | | +-+
* | | | | | | |
- * | | | | | | rte_smp_rmb()
+ * | +------------ fetch 1 -------------->| | | rte_smp_rmb()
* | | | | | | |
- * +-+ | |<------------- store 0 -----------------------|
+ * +-+ | |<------------------ store 0 ------------------|
* | | | | | |
- * |------------- fetch 0 --------------->| | | |
+ * |-------------- fetch 0 -------------->| | | |
* | | | | | |
* |----------------- destroy BPF program and cleanup ----------------->| |
* | | | | | |
--
2.43.0
next prev parent reply other threads:[~2026-10-11 18:23 UTC|newest]
Thread overview: 33+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-11 18:21 [PATCH 0/9] bpf: clean up and document ethdev callback synchronization Marat Khalili
2026-10-11 18:21 ` [PATCH 1/9] bpf: document packet callback unload sequence Marat Khalili
2026-10-11 18:21 ` [PATCH 2/9] bpf: document ethdev callback threading limitations Marat Khalili
2026-10-11 18:21 ` [PATCH 3/9] bpf: reject Tx callback installation with MT_LOCKFREE Marat Khalili
2026-10-11 18:21 ` [PATCH 4/9] bpf: add callback flag to skip multi-thread check Marat Khalili
2026-10-11 19:48 ` Stephen Hemminger
2026-10-11 20:12 ` Marat Khalili
2026-10-11 18:21 ` [PATCH 5/9] bpf: remove redundant memory barrier on unload Marat Khalili
2026-10-11 19:50 ` Stephen Hemminger
2026-10-11 20:14 ` Marat Khalili
2026-10-11 18:21 ` [PATCH 6/9] bpf: simplify callback inuse tracking to boolean flag Marat Khalili
2026-10-11 19:51 ` Stephen Hemminger
2026-10-11 20:17 ` Marat Khalili
2026-10-11 18:21 ` Marat Khalili [this message]
2026-10-11 18:21 ` [PATCH 8/9] bpf: use relaxed stores for callback inuse tracking Marat Khalili
2026-10-11 19:52 ` Stephen Hemminger
2026-10-11 20:24 ` Marat Khalili
2026-10-11 18:21 ` [PATCH 9/9] bpf: make callback handle atomic with relaxed access Marat Khalili
2026-10-11 19:54 ` Stephen Hemminger
2026-10-11 20:31 ` Marat Khalili
2026-10-11 20:29 ` [RFC] bpf: fix callback unload with concurrent Tx burst Stephen Hemminger
2026-10-12 21:09 ` [PATCH v2 0/9] bpf: clean up and document ethdev callback synchronization Marat Khalili
2026-10-12 21:09 ` [PATCH v2 1/9] bpf: document packet callback unload sequence Marat Khalili
2026-10-12 21:09 ` [PATCH v2 2/9] bpf: document ethdev callback threading limitations Marat Khalili
2026-10-12 21:44 ` Stephen Hemminger
2026-10-12 21:09 ` [PATCH v2 3/9] bpf: reject Tx callback installation with MT_LOCKFREE Marat Khalili
2026-10-12 21:09 ` [PATCH v2 4/9] bpf: remove redundant memory barrier on unload Marat Khalili
2026-10-12 21:09 ` [PATCH v2 5/9] bpf: simplify callback inuse tracking to boolean flag Marat Khalili
2026-10-12 21:09 ` [PATCH v2 6/9] bpf: reformat packet callback unload diagram Marat Khalili
2026-10-12 21:09 ` [PATCH v2 7/9] bpf: use relaxed accesses for callback inuse tracking Marat Khalili
2026-10-12 21:09 ` [PATCH v2 8/9] bpf: make callback handle atomic with relaxed access Marat Khalili
2026-10-12 21:09 ` [PATCH v2 9/9] bpf: add callback flag to skip multi-thread check Marat Khalili
2026-10-13 16:55 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261011182158.124246-8-qm2k21@gmail.com \
--to=qm2k21@gmail.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox