From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>, stable@dpdk.org
Subject: [RFC PATCH 02/12] build: fix ignoring requested driver when class is disabled
Date: Fri, 16 Oct 2026 11:59:40 +0100 [thread overview]
Message-ID: <20261016105950.273068-3-bruce.richardson@intel.com> (raw)
In-Reply-To: <20261016105950.273068-1-bruce.richardson@intel.com>
When a whole driver class is disabled due to missing dependencies, we
are silently ignoring the fact that the user may have requested drivers
of that class and therefore that the build configuration should fail.
This can be seen by configuring a build with parameters
"-Denable_drivers=event/sw -Ddisable_libs=eventdev". With eventdev
disabled, all event drivers are never considered and no error from this
misconfiguration results.
Fix this by adding a check for requested drivers when disabling a whole
class of devices.
Fixes: 70b6941e4e22 ("build: check drivers class dependencies early")
Cc: stable@dpdk.org
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/meson.build | 8 ++++++++
1 file changed, 8 insertions(+)
diff --git a/drivers/meson.build b/drivers/meson.build
index 02adf51173..b761e19be5 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -119,6 +119,14 @@ foreach subpath:subdirs
endif
message('Disabling @1@/* drivers: missing internal dependency "@0@"'
.format(d, class))
+ # error out if a driver in this class was explicitly requested,
+ # i.e. not via wildcard, since it can now never be built.
+ foreach drv_path : get_option('enable_drivers').split(',')
+ if drv_path.startswith(class + '/')
+ error('Cannot build explicitly requested driver "@0@".\n'.format(drv_path)
+ +'\tReason: missing internal dependency "@0@"'.format(d))
+ endif
+ endforeach
break
endif
endforeach
--
2.53.0
next prev parent reply other threads:[~2026-10-16 11:00 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-16 10:59 [RFC PATCH 00/12] Add config-time dependency tracking Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 01/12] build: fix name of base library object Bruce Richardson
2026-10-16 10:59 ` Bruce Richardson [this message]
2026-10-16 10:59 ` [RFC PATCH 03/12] build: prevent overlap of enable and disable lists Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 04/12] build: add direct support for optional dependencies Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 05/12] net/bond: rename directory for consistency Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 06/12] build: add script to generate dependencies list Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 07/12] build: use recursive addition for enabled libraries option Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 08/12] build: use recursive addition for enabled drivers option Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 09/12] build: improve error reporting for unbuildable components Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 10/12] build: add EAL common directory to global include list Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 11/12] build: make EAL an explicit dependency Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 12/12] build: simplify mandatory library lists Bruce Richardson
2026-10-16 14:35 ` [RFC PATCH 00/12] Add config-time dependency tracking David Marchand
2026-10-16 14:44 ` Bruce Richardson
2026-10-16 14:51 ` David Marchand
2026-10-16 15:42 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261016105950.273068-3-bruce.richardson@intel.com \
--to=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox