DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: dev@dpdk.org
Cc: Bruce Richardson <bruce.richardson@intel.com>
Subject: [RFC PATCH 08/12] build: use recursive addition for enabled drivers option
Date: Fri, 16 Oct 2026 11:59:46 +0100	[thread overview]
Message-ID: <20261016105950.273068-9-bruce.richardson@intel.com> (raw)
In-Reply-To: <20261016105950.273068-1-bruce.richardson@intel.com>

As with the libraries, recursively add dependencies of the enabled
drivers to the build list to enable building with, for example, just
--enable_drivers=net/mlx5 or --enable_drivers=net/cpfl.

Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
 drivers/meson.build | 21 ++++++++++++---------
 1 file changed, 12 insertions(+), 9 deletions(-)

diff --git a/drivers/meson.build b/drivers/meson.build
index cb71bc8231..fe514a0b15 100644
--- a/drivers/meson.build
+++ b/drivers/meson.build
@@ -71,23 +71,26 @@ foreach driver_option : ['disable_drivers', 'enable_drivers']
 endforeach
 
 disable_drivers = run_command(list_dir_globs, disable_drivers, check: true).stdout().split()
-enable_drivers = run_command(list_dir_globs, enable_drivers, check: true).stdout().split()
-foreach d:enable_drivers
+requested_drivers = run_command(list_dir_globs, enable_drivers, check: true).stdout().split()
+foreach d:requested_drivers
     if disable_drivers.contains(d)
         error('Driver "@0@" is in both "enable_drivers" and "disable_drivers".'.format(d))
     endif
 endforeach
-require_drivers = true
-if enable_drivers.length() == 0
-    require_drivers = false
-    enable_drivers = run_command(list_dir_globs, '**', check: true).stdout().split()
-endif
+require_drivers = requested_drivers.length() != 0
 
 # these drivers must always be enabled, otherwise the build breaks
 always_enable = ['bus/pci', 'bus/vdev']
 # we always need a mempool driver, and ring is default, so make it mandatory
 always_enable += ['mempool/ring']
-enable_drivers += always_enable
+
+# expand the requested drivers to also include the drivers they depend on; with
+# no drivers requested every driver is wanted, so no list is needed
+enable_drivers = []
+if require_drivers
+    enable_drivers = run_command(resolve_deps_cmd, dpdk_deps_graph, '--drivers',
+            requested_drivers + always_enable, check: true).stdout().strip().split(',')
+endif
 
 default_cflags = machine_args
 default_cflags += ['-DALLOW_EXPERIMENTAL_API']
@@ -200,7 +203,7 @@ foreach subpath:subdirs
             name = name.split('/')[1]
         endif
 
-        if not enable_drivers.contains(drv_path)
+        if require_drivers and not enable_drivers.contains(drv_path)
             build = false
             reason = 'not in enabled drivers build config'
         elif disable_drivers.contains(drv_path)
-- 
2.53.0


  parent reply	other threads:[~2026-10-16 11:01 UTC|newest]

Thread overview: 17+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-16 10:59 [RFC PATCH 00/12] Add config-time dependency tracking Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 01/12] build: fix name of base library object Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 02/12] build: fix ignoring requested driver when class is disabled Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 03/12] build: prevent overlap of enable and disable lists Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 04/12] build: add direct support for optional dependencies Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 05/12] net/bond: rename directory for consistency Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 06/12] build: add script to generate dependencies list Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 07/12] build: use recursive addition for enabled libraries option Bruce Richardson
2026-10-16 10:59 ` Bruce Richardson [this message]
2026-10-16 10:59 ` [RFC PATCH 09/12] build: improve error reporting for unbuildable components Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 10/12] build: add EAL common directory to global include list Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 11/12] build: make EAL an explicit dependency Bruce Richardson
2026-10-16 10:59 ` [RFC PATCH 12/12] build: simplify mandatory library lists Bruce Richardson
2026-10-16 14:35 ` [RFC PATCH 00/12] Add config-time dependency tracking David Marchand
2026-10-16 14:44   ` Bruce Richardson
2026-10-16 14:51     ` David Marchand
2026-10-16 15:42       ` Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20261016105950.273068-9-bruce.richardson@intel.com \
    --to=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox