[PATCH] eventdev/vector: fix adapter slot search

[PATCH] eventdev/vector: fix adapter slot search

[Stephen Hemminger]

Building with clang and enabling option to find unreachable code
found this bug.

The loop looking for a free adapter slot returned EEXIST as soon
as it found a used slot, so only one adapter could be created per
event queue.

Keep searching; the existing check after the loop reports when
all slots are in use.

Fixes: e12c3754da7a ("eventdev/vector: introduce event vector adapter")
Cc: stable@dpdk.org

Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
---
 drivers/net/qede/base/ecore_dev.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c
index e895dee405..6e76ac9c2f 100644
--- a/drivers/net/qede/base/ecore_dev.c
+++ b/drivers/net/qede/base/ecore_dev.c
@@ -1544,7 +1544,7 @@ static u32 ecore_hw_bar_size(struct ecore_hwfn *p_hwfn,
 	if (ECORE_IS_CMT(p_hwfn->p_dev)) {
 		DP_INFO(p_hwfn,
 			"BAR size not configured. Assuming BAR size of 256kB for GRC and 512kB for DB\n");
-		val = BAR_ID_0 ? 256 * 1024 : 512 * 1024;
+		val = bar_id == BAR_ID_0 ? 256 * 1024 : 512 * 1024;
 	} else {
 		DP_INFO(p_hwfn,
 			"BAR size not configured. Assuming BAR size of 512kB for GRC and 512kB for DB\n");
-- 
2.53.0

Re: [EXTERNAL] [PATCH] eventdev/vector: fix adapter slot search

[Pavan Nikhilesh Bhagavatula]

>Building with clang and enabling option to find unreachable code
>found this bug.
>
>The loop looking for a free adapter slot returned EEXIST as soon
>as it found a used slot, so only one adapter could be created per
>event queue.
>
>Keep searching; the existing check after the loop reports when
>all slots are in use.
>
>Fixes: e12c3754da7a ("eventdev/vector: introduce event vector adapter")

Incorrect fixes hash. The above hash has the following changes:

 MAINTAINERS                                        |   6 +
 config/rte_config.h                                |   1 +
 doc/api/doxy-api-index.md                          |   1 +
 doc/guides/eventdevs/features/default.ini          |   7 +
 .../prog_guide/eventdev/event_vector_adapter.rst   | 240 +++++++++++
 doc/guides/prog_guide/eventdev/eventdev.rst        |  10 +-
 doc/guides/prog_guide/eventdev/index.rst           |   1 +
 doc/guides/rel_notes/release_25_07.rst             |  10 +
 lib/eventdev/event_vector_adapter_pmd.h            |  88 ++++
 lib/eventdev/eventdev_pmd.h                        |  36 ++
 lib/eventdev/meson.build                           |   3 +
 lib/eventdev/rte_event_vector_adapter.c            | 472 ++++++++++++++++++++
 lib/eventdev/rte_event_vector_adapter.h            | 476 +++++++++++++++++++++
 lib/eventdev/rte_eventdev.c                        |  22 +
 lib/eventdev/rte_eventdev.h                        |  10 +

 Thanks,
 Pavan.

>Cc: stable@dpdk.org
>
>Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
>---
> drivers/net/qede/base/ecore_dev.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/net/qede/base/ecore_dev.c b/drivers/net/qede/base/ecore_dev.c
>index e895dee405..6e76ac9c2f 100644
>--- a/drivers/net/qede/base/ecore_dev.c
>+++ b/drivers/net/qede/base/ecore_dev.c
>@@ -1544,7 +1544,7 @@ static u32 ecore_hw_bar_size(struct ecore_hwfn *p_hwfn,
>        if (ECORE_IS_CMT(p_hwfn->p_dev)) {
>                DP_INFO(p_hwfn,
>                        "BAR size not configured. Assuming BAR size of 256kB for GRC and 512kB for DB\n");
>-               val = BAR_ID_0 ? 256 * 1024 : 512 * 1024;
>+               val = bar_id == BAR_ID_0 ? 256 * 1024 : 512 * 1024;
>        } else {
>                DP_INFO(p_hwfn,
>                        "BAR size not configured. Assuming BAR size of 512kB for GRC and 512kB for DB\n");
>--
>2.53.0