From: David Marchand <david.marchand@redhat.com>
To: dev@dpdk.org
Cc: sriram.yagnaraman@ericsson.com, jgrajcia@cisco.com,
thomas@monjalon.net, stephen@networkplumber.org
Subject: [PATCH] net/memif: fix use after free on listener socket close
Date: Wed, 4 Nov 2026 17:41:53 +0100 [thread overview]
Message-ID: <20261104164153.1674329-1-david.marchand@redhat.com> (raw)
memif_socket_remove_device() calls rte_intr_callback_unregister() on
the listener socket interrupt handle. If memif_listener_handler() is
active at that point, the unregister returns -EAGAIN and the code
proceeds to close and free the handle while the handler is still
running.
Use rte_intr_callback_unregister_sync() which retries until the
handler completes.
Fixes: 7281511c2cfa ("net/memif: fix some interrupt FD leaks")
Signed-off-by: David Marchand <david.marchand@redhat.com>
---
drivers/net/memif/memif_socket.c | 4 ++--
1 file changed, 2 insertions(+), 2 deletions(-)
diff --git a/drivers/net/memif/memif_socket.c b/drivers/net/memif/memif_socket.c
index 971964133c..d672ad9f64 100644
--- a/drivers/net/memif/memif_socket.c
+++ b/drivers/net/memif/memif_socket.c
@@ -1198,8 +1198,8 @@ memif_socket_remove_device(struct rte_eth_dev *dev)
socket->filename);
}
if (pmd->role != MEMIF_ROLE_CLIENT) {
- rte_intr_callback_unregister(socket->intr_handle, memif_listener_handler,
- socket);
+ rte_intr_callback_unregister_sync(socket->intr_handle,
+ memif_listener_handler, socket);
rte_intr_fd_close(socket->intr_handle);
rte_intr_instance_free(socket->intr_handle);
}
--
2.56.0
next reply other threads:[~2026-11-04 16:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 16:41 David Marchand [this message]
2026-11-05 8:32 ` [PATCH] net/memif: fix use after free on listener socket close Stephen Hemminger
2026-11-06 14:57 ` [PATCH v2] " David Marchand
2026-11-09 22:13 ` Stephen Hemminger
2026-11-10 7:43 ` David Marchand
2026-11-10 14:36 ` Stephen Hemminger
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261104164153.1674329-1-david.marchand@redhat.com \
--to=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=sriram.yagnaraman@ericsson.com \
--cc=stephen@networkplumber.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox