From: Stephen Hemminger <stephen@networkplumber.org>
To: David Marchand <david.marchand@redhat.com>
Cc: dev@dpdk.org, Sriram Yagnaraman <sriram.yagnaraman@ericsson.com>,
Jakub Grajciar <jgrajcia@cisco.com>,
Thomas Monjalon <thomas@monjalon.net>
Subject: Re: [PATCH v2] net/memif: fix use after free on listener socket close
Date: Tue, 10 Nov 2026 06:36:50 -0800 [thread overview]
Message-ID: <20261110063650.38e0ab72@phoenix.local> (raw)
In-Reply-To: <CAJFAV8w0gWA+jJmTcFOeJTi1S+j5+rSq9Ltn+aWn59yJu0Oy5g@mail.gmail.com>
On Tue, 10 Nov 2026 08:43:28 +0100
David Marchand <david.marchand@redhat.com> wrote:
> On Mon, 9 Nov 2026 at 23:14, Stephen Hemminger
> <stephen@networkplumber.org> wrote:
> >
> > On Fri, 6 Nov 2026 15:57:29 +0100
> > David Marchand <david.marchand@redhat.com> wrote:
> >
> > > memif_socket_remove_device() calls rte_intr_callback_unregister() on
> > > the listener socket interrupt handle. If memif_listener_handler() is
> > > active at that point, the unregister returns -EAGAIN and the code
> > > proceeds to close and free the handle while the handler is still
> > > running.
> > >
> > > Use rte_intr_callback_unregister_sync() which retries until the
> > > handler completes.
> > >
> > > Fixes: 7281511c2cfa ("net/memif: fix some interrupt FD leaks")
> > >
> > > Signed-off-by: David Marchand <david.marchand@redhat.com>
> > > Reviewed-by: Stephen Hemminger <stephen@networkplumber.org>
> > > ---
> > > Changes since v1:
> > > - added missing _sync in other call,
> >
> >
> > Applied to next-net but dropped the Fixes line since that commit
> > is after the last release. Fixes is not necessary during the merge
> > cycle.
>
> I disagree.
>
> Fixes: tag are not *only* for backport purpose.
> Those tags also give useful information when looking back in git
> history, to understand why change X is done.
Makes sense, just don't cc stable
prev parent reply other threads:[~2026-11-10 14:36 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-11-04 16:41 [PATCH] net/memif: fix use after free on listener socket close David Marchand
2026-11-05 8:32 ` Stephen Hemminger
2026-11-06 14:57 ` [PATCH v2] " David Marchand
2026-11-09 22:13 ` Stephen Hemminger
2026-11-10 7:43 ` David Marchand
2026-11-10 14:36 ` Stephen Hemminger [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20261110063650.38e0ab72@phoenix.local \
--to=stephen@networkplumber.org \
--cc=david.marchand@redhat.com \
--cc=dev@dpdk.org \
--cc=jgrajcia@cisco.com \
--cc=sriram.yagnaraman@ericsson.com \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox