* [PATCH] net/mlx5: dump flow create error message @ 2018-02-06 12:52 Xueming Li 2018-02-06 13:22 ` Nélio Laranjeiro 0 siblings, 1 reply; 5+ messages in thread From: Xueming Li @ 2018-02-06 12:52 UTC (permalink / raw) To: Nelio Laranjeiro; +Cc: Xueming Li, dev, Shahaf Shuler Add error message dump when flow create error happened. Signed-off-by: Xueming Li <xuemingl@mellanox.com> --- drivers/net/mlx5/mlx5_flow.c | 1 + 1 file changed, 1 insertion(+) diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c index e38452ef3..ea90556d0 100644 --- a/drivers/net/mlx5/mlx5_flow.c +++ b/drivers/net/mlx5/mlx5_flow.c @@ -1890,6 +1890,7 @@ priv_flow_create(struct priv *priv, DEBUG("Flow created %p", (void *)flow); return flow; exit: + ERROR("Flow create error: %s", error->message); for (i = 0; i != hash_rxq_init_n; ++i) { if (parser.queue[i].ibv_attr) rte_free(parser.queue[i].ibv_attr); -- 2.13.3 ^ permalink raw reply related [flat|nested] 5+ messages in thread
* Re: [PATCH] net/mlx5: dump flow create error message 2018-02-06 12:52 [PATCH] net/mlx5: dump flow create error message Xueming Li @ 2018-02-06 13:22 ` Nélio Laranjeiro 2018-02-06 14:20 ` Xueming(Steven) Li 0 siblings, 1 reply; 5+ messages in thread From: Nélio Laranjeiro @ 2018-02-06 13:22 UTC (permalink / raw) To: Xueming Li; +Cc: Nelio Laranjeiro, dev, Shahaf Shuler On Tue, Feb 06, 2018 at 08:52:53PM +0800, Xueming Li wrote: > Add error message dump when flow create error happened. > > Signed-off-by: Xueming Li <xuemingl@mellanox.com> > --- > drivers/net/mlx5/mlx5_flow.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/drivers/net/mlx5/mlx5_flow.c b/drivers/net/mlx5/mlx5_flow.c > index e38452ef3..ea90556d0 100644 > --- a/drivers/net/mlx5/mlx5_flow.c > +++ b/drivers/net/mlx5/mlx5_flow.c > @@ -1890,6 +1890,7 @@ priv_flow_create(struct priv *priv, > DEBUG("Flow created %p", (void *)flow); > return flow; > exit: > + ERROR("Flow create error: %s", error->message); > for (i = 0; i != hash_rxq_init_n; ++i) { > if (parser.queue[i].ibv_attr) > rte_free(parser.queue[i].ibv_attr); > -- > 2.13.3 Hi Xueming, Can you move this debug message to mlx5_flow_create(). Thanks, -- Nélio Laranjeiro 6WIND ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/mlx5: dump flow create error message 2018-02-06 13:22 ` Nélio Laranjeiro @ 2018-02-06 14:20 ` Xueming(Steven) Li 2018-02-07 6:50 ` Nélio Laranjeiro 0 siblings, 1 reply; 5+ messages in thread From: Xueming(Steven) Li @ 2018-02-06 14:20 UTC (permalink / raw) To: Nélio Laranjeiro; +Cc: Nelio Laranjeiro, dev@dpdk.org, Shahaf Shuler Hi Nelio, > -----Original Message----- > From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > Sent: Tuesday, February 6, 2018 9:22 PM > To: Xueming(Steven) Li <xuemingl@mellanox.com> > Cc: Nelio Laranjeiro <notifications@github.com>; dev@dpdk.org; Shahaf > Shuler <shahafs@mellanox.com> > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: dump flow create error message > > On Tue, Feb 06, 2018 at 08:52:53PM +0800, Xueming Li wrote: > > Add error message dump when flow create error happened. > > > > Signed-off-by: Xueming Li <xuemingl@mellanox.com> > > --- > > drivers/net/mlx5/mlx5_flow.c | 1 + > > 1 file changed, 1 insertion(+) > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > b/drivers/net/mlx5/mlx5_flow.c index e38452ef3..ea90556d0 100644 > > --- a/drivers/net/mlx5/mlx5_flow.c > > +++ b/drivers/net/mlx5/mlx5_flow.c > > @@ -1890,6 +1890,7 @@ priv_flow_create(struct priv *priv, > > DEBUG("Flow created %p", (void *)flow); > > return flow; > > exit: > > + ERROR("Flow create error: %s", error->message); > > for (i = 0; i != hash_rxq_init_n; ++i) { > > if (parser.queue[i].ibv_attr) > > rte_free(parser.queue[i].ibv_attr); > > -- > > 2.13.3 > > Hi Xueming, > > Can you move this debug message to mlx5_flow_create(). This function also called by control flow and fdir functions, here should be the best place. > > Thanks, > > -- > Nélio Laranjeiro > 6WIND ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/mlx5: dump flow create error message 2018-02-06 14:20 ` Xueming(Steven) Li @ 2018-02-07 6:50 ` Nélio Laranjeiro 2018-02-13 17:11 ` Thomas Monjalon 0 siblings, 1 reply; 5+ messages in thread From: Nélio Laranjeiro @ 2018-02-07 6:50 UTC (permalink / raw) To: Xueming(Steven) Li; +Cc: Nelio Laranjeiro, dev@dpdk.org, Shahaf Shuler On Tue, Feb 06, 2018 at 02:20:28PM +0000, Xueming(Steven) Li wrote: > Hi Nelio, > > > -----Original Message----- > > From: Nélio Laranjeiro [mailto:nelio.laranjeiro@6wind.com] > > Sent: Tuesday, February 6, 2018 9:22 PM > > To: Xueming(Steven) Li <xuemingl@mellanox.com> > > Cc: Nelio Laranjeiro <notifications@github.com>; dev@dpdk.org; Shahaf > > Shuler <shahafs@mellanox.com> > > Subject: Re: [dpdk-dev] [PATCH] net/mlx5: dump flow create error message > > > > On Tue, Feb 06, 2018 at 08:52:53PM +0800, Xueming Li wrote: > > > Add error message dump when flow create error happened. > > > > > > Signed-off-by: Xueming Li <xuemingl@mellanox.com> > > > --- > > > drivers/net/mlx5/mlx5_flow.c | 1 + > > > 1 file changed, 1 insertion(+) > > > > > > diff --git a/drivers/net/mlx5/mlx5_flow.c > > > b/drivers/net/mlx5/mlx5_flow.c index e38452ef3..ea90556d0 100644 > > > --- a/drivers/net/mlx5/mlx5_flow.c > > > +++ b/drivers/net/mlx5/mlx5_flow.c > > > @@ -1890,6 +1890,7 @@ priv_flow_create(struct priv *priv, > > > DEBUG("Flow created %p", (void *)flow); > > > return flow; > > > exit: > > > + ERROR("Flow create error: %s", error->message); > > > for (i = 0; i != hash_rxq_init_n; ++i) { > > > if (parser.queue[i].ibv_attr) > > > rte_free(parser.queue[i].ibv_attr); > > > -- > > > 2.13.3 > > > > Hi Xueming, > > > > Can you move this debug message to mlx5_flow_create(). > > This function also called by control flow and fdir functions, > here should be the best place. Make sense, Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> Thanks, -- Nélio Laranjeiro 6WIND ^ permalink raw reply [flat|nested] 5+ messages in thread
* Re: [PATCH] net/mlx5: dump flow create error message 2018-02-07 6:50 ` Nélio Laranjeiro @ 2018-02-13 17:11 ` Thomas Monjalon 0 siblings, 0 replies; 5+ messages in thread From: Thomas Monjalon @ 2018-02-13 17:11 UTC (permalink / raw) To: Xueming(Steven) Li Cc: dev, Nélio Laranjeiro, Nelio Laranjeiro, Shahaf Shuler > > > > Add error message dump when flow create error happened. > > > > > > > > Signed-off-by: Xueming Li <xuemingl@mellanox.com> > > Acked-by: Nelio Laranjeiro <nelio.laranjeiro@6wind.com> Applied, thanks ^ permalink raw reply [flat|nested] 5+ messages in thread
end of thread, other threads:[~2018-02-13 17:11 UTC | newest] Thread overview: 5+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2018-02-06 12:52 [PATCH] net/mlx5: dump flow create error message Xueming Li 2018-02-06 13:22 ` Nélio Laranjeiro 2018-02-06 14:20 ` Xueming(Steven) Li 2018-02-07 6:50 ` Nélio Laranjeiro 2018-02-13 17:11 ` Thomas Monjalon
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox