dev.dpdk.org archive mirror
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Julien Cretin
	<julien.cretin-5/pgmGDL2QNYvNUnsyAbJwC/G2K4zDHf@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH] kni: fix missing backslash in Makefile
Date: Fri, 01 Aug 2014 21:28:53 +0200	[thread overview]
Message-ID: <2764645.XhU1T6HqyO@xps13> (raw)
In-Reply-To: <1406912161-5659-1-git-send-email-julien.cretin-5/pgmGDL2QNYvNUnsyAbJwC/G2K4zDHf@public.gmane.org>

Hi Julien,

2014-08-01 18:56, Julien Cretin:
> With GNU Make 3.81 on Ubuntu 14.04, I get:
> lib/librte_eal/linuxapp/kni/Makefile:49: *** unterminated call to function `shell': missing `)'.  Stop.
> 
> Signed-off-by: Julien Cretin <julien.cretin-5/pgmGDL2QNYvNUnsyAbJwC/G2K4zDHf@public.gmane.org>

> -UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature |
> +UBUNTU_KERNEL_CODE := $(shell cut -d' ' -f2 /proc/version_signature | \
>                          cut -d- -f1,2 | tr .- $(comma))

My fault, I forgot the backslash when splitting line.

Acked-by: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>

Applied.

Thanks for the quick test and report.
-- 
Thomas

      parent reply	other threads:[~2014-08-01 19:28 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2014-08-01 16:56 [PATCH] kni: fix missing backslash in Makefile Julien Cretin
     [not found] ` <1406912161-5659-1-git-send-email-julien.cretin-5/pgmGDL2QNYvNUnsyAbJwC/G2K4zDHf@public.gmane.org>
2014-08-01 19:28   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2764645.XhU1T6HqyO@xps13 \
    --to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
    --cc=dev-VfR2kkLFssw@public.gmane.org \
    --cc=julien.cretin-5/pgmGDL2QNYvNUnsyAbJwC/G2K4zDHf@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).