DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Marat Khalili <qm2k21@gmail.com>
To: dev@dpdk.org
Subject: Re: [PATCH v2] examples/rpcapd: demo version of packet capture daemon
Date: Mon, 21 Sep 2026 10:51:39 +0100	[thread overview]
Message-ID: <2801d980-791c-4552-a9cd-4ad705ebb196@gmail.com> (raw)
In-Reply-To: <20260920190007.1128720-1-stephen@networkplumber.org>

Very cool example, demonstrating many advanced DPDK features at once. In 
this regard, it really excels.

It could be however useful as a debug tool, and in this case having to 
deal with a secondary process is a hassle. Could we have this feature in 
dpdk-testpmd, instead or as well?

Otherwise, having seen the demonstration, I do not have many comments, 
except for a couple nits below.

On 20/09/2026 19:59, Stephen Hemminger wrote:
> This example adds RPCAP support over localhost TCP
> integrated with DPDK. It uses a secondary process that allows
> connections from using tcpdump defacto protocol rpcap.
>
> See: doc/guides/sample_app_ug/rpcapd.rst for more info
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> ---
> v2 - Build on Linux only
>     - add filter support
>     - fix lots of AI review feedback
>
>   MAINTAINERS                            |    2 +
>   doc/guides/rel_notes/release_26_11.rst |    4 +
>   doc/guides/sample_app_ug/index.rst     |    1 +
>   doc/guides/sample_app_ug/rpcapd.rst    |  216 ++++
>   examples/meson.build                   |    1 +
>   examples/rpcapd/main.c                 | 1430 ++++++++++++++++++++++++

main.c is a bit large and handles many different functions. It would be 
more readable if different aspects were handled by different files, or 
at least clearly marked sections of the file, with overall structure 
explained somewhere at the top.

>   examples/rpcapd/meson.build            |   19 +
>   examples/rpcapd/rpcap-protocol.h       |  127 +++
Could we just use one from libpcap?

  reply	other threads:[~2026-09-21  9:51 UTC|newest]

Thread overview: 21+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-09-08 21:07 [PATCH] examples/rpcapd: demo version of packet capture daemon Stephen Hemminger
2026-09-20 18:59 ` [PATCH v2] " Stephen Hemminger
2026-09-21  9:51   ` Marat Khalili [this message]
2026-09-21 15:57     ` Stephen Hemminger
2026-09-21 15:58     ` Stephen Hemminger
2026-09-21 16:43       ` Marat Khalili
2026-09-21 17:31         ` Stephen Hemminger
2026-09-21 17:53           ` Marat Khalili
2026-09-21 16:17     ` Stephen Hemminger
2026-09-22 18:45   ` Stephen Hemminger
2026-09-22 21:31 ` [PATCH v3] " Stephen Hemminger
2026-09-28 16:18   ` Marat Khalili
2026-09-28 17:24     ` Stephen Hemminger
2026-10-01  2:35 ` [PATCH v4 0/4] add rpcap remote " Stephen Hemminger
2026-10-01  2:35   ` [PATCH v4 1/4] pcapng: add API to read back capture mbuf header Stephen Hemminger
2026-10-01  2:35   ` [PATCH v4 2/4] app/rpcapd: remote pcap daemon Stephen Hemminger
2026-10-01 18:50     ` Marat Khalili
2026-10-01  2:35   ` [PATCH v4 3/4] app/rpcapd: add TLS support Stephen Hemminger
2026-10-01  2:35   ` [PATCH v4 4/4] app/rpcapd: add host list option Stephen Hemminger
2026-10-01 18:50   ` [PATCH v4 0/4] add rpcap remote capture daemon Marat Khalili
2026-10-01 23:00     ` Stephen Hemminger

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=2801d980-791c-4552-a9cd-4ad705ebb196@gmail.com \
    --to=qm2k21@gmail.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox