Re: [PATCH v4 0/4] add rpcap remote capture daemon

[Marat Khalili <qm2k21@gmail.com>]

>    pcapng: add API to read back capture mbuf header
Analysis with AI tells that there are some opportunities to make the 
fast path of lib/pcapng both lighter and less .pcapng-centric to make 
life of consumers that prefer other formats easier. It does not have to 
(probably even shouldn't) be a part of the current patchset though.
>    app/rpcapd: remote pcap daemon
Ideally forwarding captured data could run in a separate thread with 
minimum unnecessary syscalls, although it's hard to tell without 
benchmarks how much current design is slowed down by them.
>    app/rpcapd: add TLS support
This patch simultaneously adds authentication, but it's only required 
for non-loopback users. This is a common security vulnerability, not all 
loopback users can be trusted. So if we care about authentication at 
all, it should probably also be required for localhost users, at least 
by default.
>    app/rpcapd: add host list option
>
>   MAINTAINERS                            |   2 +
>   app/meson.build                        |   1 +
>   app/rpcapd/capture.c                   | 541 ++++++++++++++++
>   app/rpcapd/filter.c                    | 164 +++++
>   app/rpcapd/main.c                      | 840 +++++++++++++++++++++++++
>   app/rpcapd/meson.build                 |  40 ++
>   app/rpcapd/rpcap-protocol.h            | 146 +++++
>   app/rpcapd/rpcapd.h                    | 122 ++++
>   app/rpcapd/session.c                   | 292 +++++++++
>   app/rpcapd/sock.c                      | 365 +++++++++++
>   app/rpcapd/tls.c                       | 273 ++++++++
>   app/test/test_pcapng.c                 | 133 ++++
>   doc/guides/rel_notes/release_26_11.rst |  13 +
>   doc/guides/tools/index.rst             |   1 +
>   doc/guides/tools/rpcapd.rst            | 288 +++++++++
>   lib/pcapng/rte_pcapng.c                |  40 ++
>   lib/pcapng/rte_pcapng.h                |  46 ++
>   17 files changed, 3307 insertions(+)
>   create mode 100644 app/rpcapd/capture.c
>   create mode 100644 app/rpcapd/filter.c
>   create mode 100644 app/rpcapd/main.c
>   create mode 100644 app/rpcapd/meson.build
>   create mode 100644 app/rpcapd/rpcap-protocol.h
>   create mode 100644 app/rpcapd/rpcapd.h
>   create mode 100644 app/rpcapd/session.c
>   create mode 100644 app/rpcapd/sock.c
>   create mode 100644 app/rpcapd/tls.c
>   create mode 100644 doc/guides/tools/rpcapd.rst

With or without addressing any of the comments above,

Series-Acked-by: Marat Khalili <qm2k21@gmail.com>