From: Anatoly Burakov <anatoly.burakov@intel.com>
To: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: [PATCH v2 1/3] net/ice: remove unused flow handle from engines
Date: Wed, 21 Oct 2026 11:52:48 +0100 [thread overview]
Message-ID: <3cbd41baf2db930276ce43893a787ea65770e1ff.1792579964.git.anatoly.burakov@intel.com> (raw)
In-Reply-To: <869a70bf8e9bb8ce36de57ddb46ea2d44d7b9be9.1792577695.git.anatoly.burakov@intel.com>
The generic flow layer now assigns the parsed rule to `flow->rule`
after successful creation. Engine create callbacks no longer use the
flow handle, and all four implementations mark it as unused.
Remove the parameter from the callback type, declarations,
implementations and generic invocation.
Suggested-by: Bruce Richardson <bruce.richardson@intel.com>
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/intel/ice/ice_acl_filter.c | 1 -
drivers/net/intel/ice/ice_fdir_filter.c | 1 -
drivers/net/intel/ice/ice_generic_flow.c | 2 +-
drivers/net/intel/ice/ice_generic_flow.h | 1 -
drivers/net/intel/ice/ice_hash.c | 2 --
drivers/net/intel/ice/ice_switch_filter.c | 1 -
6 files changed, 1 insertion(+), 7 deletions(-)
diff --git a/drivers/net/intel/ice/ice_acl_filter.c b/drivers/net/intel/ice/ice_acl_filter.c
index 9414bb3f122..08695b554f1 100644
--- a/drivers/net/intel/ice/ice_acl_filter.c
+++ b/drivers/net/intel/ice/ice_acl_filter.c
@@ -505,7 +505,6 @@ ice_acl_hw_rem_conf(struct ice_pf *pf, struct acl_rule *rule, int32_t entry_idx)
static int
ice_acl_create_filter(struct ice_adapter *ad,
- struct rte_flow *flow __rte_unused,
void *meta,
struct rte_flow_error *error)
{
diff --git a/drivers/net/intel/ice/ice_fdir_filter.c b/drivers/net/intel/ice/ice_fdir_filter.c
index f4c886dded3..e3f2cf2e3dd 100644
--- a/drivers/net/intel/ice/ice_fdir_filter.c
+++ b/drivers/net/intel/ice/ice_fdir_filter.c
@@ -1537,7 +1537,6 @@ ice_fdir_entry_del(struct ice_pf *pf, struct ice_fdir_fltr_pattern *key)
static int
ice_fdir_create_filter(struct ice_adapter *ad,
- struct rte_flow *flow __rte_unused,
void *meta,
struct rte_flow_error *error)
{
diff --git a/drivers/net/intel/ice/ice_generic_flow.c b/drivers/net/intel/ice/ice_generic_flow.c
index 25aa7aa41e2..f5ae6f7d013 100644
--- a/drivers/net/intel/ice/ice_generic_flow.c
+++ b/drivers/net/intel/ice/ice_generic_flow.c
@@ -2269,7 +2269,7 @@ ice_parse_engine_create(struct ice_adapter *ad,
RTE_ASSERT(parser->engine->create != NULL);
- if (parser->engine->create(ad, flow, meta, error) != 0) {
+ if (parser->engine->create(ad, meta, error) != 0) {
ice_flow_rule_free(parser->engine, meta);
return false;
}
diff --git a/drivers/net/intel/ice/ice_generic_flow.h b/drivers/net/intel/ice/ice_generic_flow.h
index efb3ee9b695..ca0f7abe9aa 100644
--- a/drivers/net/intel/ice/ice_generic_flow.h
+++ b/drivers/net/intel/ice/ice_generic_flow.h
@@ -506,7 +506,6 @@ struct ice_flow_redirect {
typedef int (*engine_init_t)(struct ice_adapter *ad);
typedef void (*engine_uninit_t)(struct ice_adapter *ad);
typedef int (*engine_create_t)(struct ice_adapter *ad,
- struct rte_flow *flow,
void *meta,
struct rte_flow_error *error);
typedef int (*engine_destroy_t)(struct ice_adapter *ad,
diff --git a/drivers/net/intel/ice/ice_hash.c b/drivers/net/intel/ice/ice_hash.c
index fe66b1dd5a6..980abb58f3b 100644
--- a/drivers/net/intel/ice/ice_hash.c
+++ b/drivers/net/intel/ice/ice_hash.c
@@ -82,7 +82,6 @@ ice_hash_init(struct ice_adapter *ad);
static int
ice_hash_create(struct ice_adapter *ad,
- struct rte_flow *flow,
void *meta,
struct rte_flow_error *error);
@@ -1314,7 +1313,6 @@ ice_hash_add_raw_cfg(struct ice_adapter *ad,
static int
ice_hash_create(struct ice_adapter *ad,
- struct rte_flow *flow __rte_unused,
void *meta,
struct rte_flow_error *error)
{
diff --git a/drivers/net/intel/ice/ice_switch_filter.c b/drivers/net/intel/ice/ice_switch_filter.c
index 4dd4707c406..59e18269206 100644
--- a/drivers/net/intel/ice/ice_switch_filter.c
+++ b/drivers/net/intel/ice/ice_switch_filter.c
@@ -285,7 +285,6 @@ ice_pattern_match_item ice_switch_supported_pattern[] = {
static int
ice_switch_create(struct ice_adapter *ad,
- struct rte_flow *flow __rte_unused,
void *meta,
struct rte_flow_error *error)
{
--
2.52.0
next prev parent reply other threads:[~2026-10-21 10:52 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-10-21 10:15 [PATCH v1 1/2] net/ice: remove unused flow handle from engines Anatoly Burakov
2026-10-21 10:15 ` [PATCH v1 2/2] net/ice: rename flow metadata parameter to rule Anatoly Burakov
2026-10-21 10:23 ` Bruce Richardson
2026-10-21 10:17 ` [PATCH v1 1/2] net/ice: remove unused flow handle from engines Burakov, Anatoly
2026-10-21 10:19 ` Bruce Richardson
2026-10-21 10:52 ` Anatoly Burakov [this message]
2026-10-21 10:52 ` [PATCH v2 2/3] net/ice: rename flow metadata parameter to rule Anatoly Burakov
2026-10-21 16:24 ` Bruce Richardson
2026-10-21 10:52 ` [PATCH v2 3/3] net/ice: rename RSS flow configuration variables Anatoly Burakov
2026-10-21 16:25 ` Bruce Richardson
2026-10-22 11:50 ` [PATCH v2 1/3] net/ice: remove unused flow handle from engines Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=3cbd41baf2db930276ce43893a787ea65770e1ff.1792579964.git.anatoly.burakov@intel.com \
--to=anatoly.burakov@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox