Re: [PATCH v1 2/2] net/ice: rename flow metadata parameter to rule

[Bruce Richardson <bruce.richardson@intel.com>]

On Wed, Oct 21, 2026 at 11:15:02AM +0100, Anatoly Burakov wrote:
> Parsers now return the final engine-specific rule rather than temporary
> metadata. The generic flow layer passes this object to engine creation
> and stores it in `flow->rule`.
> 
> Rename the `meta` parameters and related local variables to reflect
> their role as persistent rules.
> 
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>  drivers/net/intel/ice/ice_acl_filter.c    | 36 +++++++++----------
>  drivers/net/intel/ice/ice_fdir_filter.c   |  8 ++---
>  drivers/net/intel/ice/ice_generic_flow.c  | 16 ++++-----
>  drivers/net/intel/ice/ice_generic_flow.h  |  6 ++--
>  drivers/net/intel/ice/ice_hash.c          | 42 +++++++++++------------
>  drivers/net/intel/ice/ice_switch_filter.c |  8 ++---
>  6 files changed, 58 insertions(+), 58 deletions(-)
> 
> diff --git a/drivers/net/intel/ice/ice_acl_filter.c b/drivers/net/intel/ice/ice_acl_filter.c
> index 08695b554f1..fdd841b062d 100644
> --- a/drivers/net/intel/ice/ice_acl_filter.c
> +++ b/drivers/net/intel/ice/ice_acl_filter.c
> @@ -505,11 +505,11 @@ ice_acl_hw_rem_conf(struct ice_pf *pf, struct acl_rule *rule, int32_t entry_idx)
>  
>  static int
>  ice_acl_create_filter(struct ice_adapter *ad,
> -		      void *meta,
> +		      void *rule,
>  		      struct rte_flow_error *error)
>  {
> -	struct acl_rule *rule = meta;
> -	struct ice_acl_conf *filter = &rule->conf;
> +	struct acl_rule *acl_rule = rule;
> +	struct ice_acl_conf *filter = &acl_rule->conf;

I dislike the churn that this rename causes. For this function can you not
name the parameter "acl_rule" or even just "_rule" to avoid renaming the
local variable?

>  	enum ice_fltr_ptype flow_type = filter->input.flow_type;
>  	struct ice_flow_action acts[1];
>  	struct ice_pf *pf = &ad->pf;
> @@ -538,7 +538,7 @@ ice_acl_create_filter(struct ice_adapter *ad,
>  	}
>  
>  	input->acl_fltr = true;
> -	ret = ice_acl_hw_set_conf(pf, input, acts, rule, flow_type, 0);
> +	ret = ice_acl_hw_set_conf(pf, input, acts, acl_rule, flow_type, 0);
>  	if (ret) {
>  		return rte_flow_error_set(error, -ret,
>  				   RTE_FLOW_ERROR_TYPE_HANDLE, NULL,
> @@ -547,29 +547,29 @@ ice_acl_create_filter(struct ice_adapter *ad,
<snip>