FW: BUG in IP FRAGMENTATION

FW: BUG in IP FRAGMENTATION

[Dey, Souvik]

Hi,
                In DPDK1.6 do we support overlapped fragments while doing reassembly. Also why we don't consider the first or last fragment to be out-of-order. Are this known limitations in DPDK or they are not working due to some bugs in the code ?

--
Regards,
Souvik

Re: FW: BUG in IP FRAGMENTATION

[Thomas Monjalon]

ME TOO, I HAVE A BUG WITH CAPS LOCK ;)

2014-10-15 11:06, Dey, Souvik:
> In DPDK1.6 do we support overlapped fragments while doing reassembly.
> Also why we don't consider the first or last fragment to be out-of-order.
> Are this known limitations in DPDK or they are not working due to some
> bugs in the code ?

Please test the latest version and explain how you see the bug.

Thanks
-- 
Thomas

Re: FW: BUG in IP FRAGMENTATION

[Dey, Souvik]

We have not directly tried to use the 1.7 code with fragmentation apis, but we did run through the 1.7 code and did not find any much difference between 1.6 and 1.7 code. 
I had wrongly mentioned out-of-order in my previous mail. Actually out-of-order is working fine but we are facing issues with overlapping and duplicate fragments.
 In the 1.7 fragmentation code also in file ip_frag_internals.c , function ip_frag_process we also see this comment

	/*
	 * errorneous packet: either exceeed max allowed number of fragments,
	 * or duplicate first/last fragment encountered.
	 */

Which indirectly suggest that the handling of duplicate first/last fragment is taken as error. Same with overlapping fragment we could not find any piece of code which will be doing it.

--
Regards,
Souvik

-----Original Message-----
From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org] 
Sent: Wednesday, October 15, 2014 4:54 PM
To: Dey, Souvik
Cc: dev-VfR2kkLFssw@public.gmane.org; Patil, PraveenKumar
Subject: Re: [dpdk-dev] FW: BUG in IP FRAGMENTATION

ME TOO, I HAVE A BUG WITH CAPS LOCK ;)

2014-10-15 11:06, Dey, Souvik:
> In DPDK1.6 do we support overlapped fragments while doing reassembly.
> Also why we don't consider the first or last fragment to be out-of-order.
> Are this known limitations in DPDK or they are not working due to some 
> bugs in the code ?

Please test the latest version and explain how you see the bug.

Thanks
--
Thomas

Re: FW: BUG in IP FRAGMENTATION

[Ananyev, Konstantin]

> -----Original Message-----
> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Dey, Souvik
> Sent: Wednesday, October 15, 2014 12:53 PM
> To: Thomas Monjalon
> Cc: dev-VfR2kkLFssw@public.gmane.org; Patil, PraveenKumar
> Subject: Re: [dpdk-dev] FW: BUG in IP FRAGMENTATION
> 
> We have not directly tried to use the 1.7 code with fragmentation apis, but we did run through the 1.7 code and did not find any much
> difference between 1.6 and 1.7 code.
> I had wrongly mentioned out-of-order in my previous mail. Actually out-of-order is working fine but we are facing issues with
> overlapping and duplicate fragments.
>  In the 1.7 fragmentation code also in file ip_frag_internals.c , function ip_frag_process we also see this comment
> 
> 	/*
> 	 * errorneous packet: either exceeed max allowed number of fragments,
> 	 * or duplicate first/last fragment encountered.
> 	 */
> 
> Which indirectly suggest that the handling of duplicate first/last fragment is taken as error. Same with overlapping fragment we could
> not find any piece of code which will be doing it.

Yes, that's right.
If we encounter a duplicate and/or overlapping fragment we treat it  as an error.

> 
> --
> Regards,
> Souvik
> 
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> Sent: Wednesday, October 15, 2014 4:54 PM
> To: Dey, Souvik
> Cc: dev-VfR2kkLFssw@public.gmane.org; Patil, PraveenKumar
> Subject: Re: [dpdk-dev] FW: BUG in IP FRAGMENTATION
> 
> ME TOO, I HAVE A BUG WITH CAPS LOCK ;)
> 
> 2014-10-15 11:06, Dey, Souvik:
> > In DPDK1.6 do we support overlapped fragments while doing reassembly.
> > Also why we don't consider the first or last fragment to be out-of-order.
> > Are this known limitations in DPDK or they are not working due to some
> > bugs in the code ?
> 
> Please test the latest version and explain how you see the bug.
> 
> Thanks
> --
> Thomas

Re: FW: BUG in IP FRAGMENTATION

[Dey, Souvik]

Any plans to support this in future in DPDK fragmentation code ?

-----Original Message-----
From: Ananyev, Konstantin [mailto:konstantin.ananyev-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org] 
Sent: Wednesday, October 15, 2014 5:49 PM
To: Dey, Souvik; Thomas Monjalon
Cc: dev-VfR2kkLFssw@public.gmane.org; Patil, PraveenKumar
Subject: RE: [dpdk-dev] FW: BUG in IP FRAGMENTATION



> -----Original Message-----
> From: dev [mailto:dev-bounces-VfR2kkLFssw@public.gmane.org] On Behalf Of Dey, Souvik
> Sent: Wednesday, October 15, 2014 12:53 PM
> To: Thomas Monjalon
> Cc: dev-VfR2kkLFssw@public.gmane.org; Patil, PraveenKumar
> Subject: Re: [dpdk-dev] FW: BUG in IP FRAGMENTATION
> 
> We have not directly tried to use the 1.7 code with fragmentation 
> apis, but we did run through the 1.7 code and did not find any much difference between 1.6 and 1.7 code.
> I had wrongly mentioned out-of-order in my previous mail. Actually 
> out-of-order is working fine but we are facing issues with overlapping and duplicate fragments.
>  In the 1.7 fragmentation code also in file ip_frag_internals.c , 
> function ip_frag_process we also see this comment
> 
> 	/*
> 	 * errorneous packet: either exceeed max allowed number of fragments,
> 	 * or duplicate first/last fragment encountered.
> 	 */
> 
> Which indirectly suggest that the handling of duplicate first/last 
> fragment is taken as error. Same with overlapping fragment we could not find any piece of code which will be doing it.

Yes, that's right.
If we encounter a duplicate and/or overlapping fragment we treat it  as an error.

> 
> --
> Regards,
> Souvik
> 
> -----Original Message-----
> From: Thomas Monjalon [mailto:thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org]
> Sent: Wednesday, October 15, 2014 4:54 PM
> To: Dey, Souvik
> Cc: dev-VfR2kkLFssw@public.gmane.org; Patil, PraveenKumar
> Subject: Re: [dpdk-dev] FW: BUG in IP FRAGMENTATION
> 
> ME TOO, I HAVE A BUG WITH CAPS LOCK ;)
> 
> 2014-10-15 11:06, Dey, Souvik:
> > In DPDK1.6 do we support overlapped fragments while doing reassembly.
> > Also why we don't consider the first or last fragment to be out-of-order.
> > Are this known limitations in DPDK or they are not working due to 
> > some bugs in the code ?
> 
> Please test the latest version and explain how you see the bug.
> 
> Thanks
> --
> Thomas