From: Thomas Monjalon <thomas.monjalon-pdR9zngts4EAvxtiuMwx3w@public.gmane.org>
To: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
Cc: dev-VfR2kkLFssw@public.gmane.org
Subject: Re: [PATCH v3] eal: Clean up export of per_lcore__socket_id
Date: Mon, 02 Mar 2015 19:41:50 +0100 [thread overview]
Message-ID: <5054941.fYjsyoJciO@xps13> (raw)
In-Reply-To: <D0158A423229094DA7ABF71CF2FA0DA3118DFF15-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
> > Theres no need to export this variable. Its set and queried from an API call
> > that doesn't exist in the hot path. Instead just export the rte_socket_id
> > symbol and make the variable private to protect it from type changes. We should
> > do this with the other exported variables too, but I think its too late in the
> > release cycle to do that.
> >
> > tested using distributor_autotest (which uses rte_socket_id), successfully.
> > Only tested on linux, as I don't currently have a bsd system spun up, but the
> > changes are symmetric, and should be fine
> >
> > Signed-off-by: Neil Horman <nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
>
> Acked-by: Cunming Liang <cunming.liang-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org>
Applied, thanks
prev parent reply other threads:[~2015-03-02 18:41 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2015-02-25 14:34 [PATCH] eal: Clean up export of per_lcore__socket_id Neil Horman
[not found] ` <1424874849-8973-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2015-02-25 23:54 ` Liang, Cunming
[not found] ` <D0158A423229094DA7ABF71CF2FA0DA3118DF024-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-02-26 0:42 ` Neil Horman
2015-02-26 12:48 ` [PATCH v2] " Neil Horman
[not found] ` <1424954906-15886-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2015-02-27 0:28 ` Liang, Cunming
2015-02-27 6:22 ` David Marchand
2015-02-27 12:33 ` [PATCH v3] " Neil Horman
[not found] ` <1425040393-31201-1-git-send-email-nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org>
2015-02-28 1:51 ` Liang, Cunming
[not found] ` <D0158A423229094DA7ABF71CF2FA0DA3118DFF15-E2R4CRU6q/6iAffOGbnezLfspsVTdybXVpNB7YpNyf8@public.gmane.org>
2015-03-02 18:41 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=5054941.fYjsyoJciO@xps13 \
--to=thomas.monjalon-pdr9zngts4eavxtiumwx3w@public.gmane.org \
--cc=dev-VfR2kkLFssw@public.gmane.org \
--cc=nhorman-2XuSBdqkA4R54TAoqtyWWQ@public.gmane.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox