* [PATCH 1/2] devtools: document test meson script config options @ 2022-12-06 12:23 Ferruh Yigit 2022-12-06 12:23 ` [PATCH 2/2] devtools: configure source repo to use as ABI reference Ferruh Yigit 2022-12-09 9:02 ` [PATCH v2 1/2] devtools: document test meson script config options David Marchand 0 siblings, 2 replies; 10+ messages in thread From: Ferruh Yigit @ 2022-12-06 12:23 UTC (permalink / raw) To: Thomas Monjalon, Bruce Richardson; +Cc: David Marchand, dev Document config options of script that can be provided by 'devel.config' config file. Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com> --- devtools/test-meson-builds.sh | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 3a308bc9af65..bbe90e2bde2e 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -12,6 +12,16 @@ PIPEFAIL="" set -o | grep -q pipefail && set -o pipefail && PIPEFAIL=1 srcdir=$(dirname $(readlink -f $0))/.. + +# Load config options: +# - DPDK_BUILD_TEST_DIR +# +# - DPDK_MESON_OPTIONS +# +# - DPDK_ABI_REF_DIR +# - DPDK_ABI_REF_VERSION +# +# - DPDK_BUILD_TEST_EXAMPLES . $srcdir/devtools/load-devel-config MESON=${MESON:-meson} -- 2.25.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH 2/2] devtools: configure source repo to use as ABI reference 2022-12-06 12:23 [PATCH 1/2] devtools: document test meson script config options Ferruh Yigit @ 2022-12-06 12:23 ` Ferruh Yigit 2022-12-08 18:14 ` [EXT] " Akhil Goyal 2022-12-09 8:22 ` David Marchand 2022-12-09 9:02 ` [PATCH v2 1/2] devtools: document test meson script config options David Marchand 1 sibling, 2 replies; 10+ messages in thread From: Ferruh Yigit @ 2022-12-06 12:23 UTC (permalink / raw) To: Thomas Monjalon, Bruce Richardson; +Cc: David Marchand, dev By default 'test-meson-builds.sh' script clones the repository which the script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') as a reference for ABI check. This patch enables selecting different repository to close for reference using 'DPDK_ABI_REF_SRC' environment variable. It is possible to put these variables to 'devel.config' config file, or provide via command line, like: ` DPDK_ABI_REF_SRC=~/dpdk-stable/ \ DPDK_ABI_REF_VERSION=v22.11.1 \ DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ ./devtools/test-meson-builds.sh ` When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did previously. Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that other repo as a new 'remote' to the exiting git repository. Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com> --- devtools/test-meson-builds.sh | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index bbe90e2bde2e..8a0ed92fcf0a 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -18,6 +18,7 @@ srcdir=$(dirname $(readlink -f $0))/.. # # - DPDK_MESON_OPTIONS # +# - DPDK_ABI_REF_SRC # - DPDK_ABI_REF_DIR # - DPDK_ABI_REF_VERSION # @@ -185,12 +186,13 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options] if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION if [ ! -d $abirefdir/$targetdir ]; then + abirefsrc=${DPDK_ABI_REF_SRC:-$srcdir} # clone current sources if [ ! -d $abirefdir/src ]; then git clone --local --no-hardlinks \ --single-branch \ -b $DPDK_ABI_REF_VERSION \ - $srcdir $abirefdir/src + $abirefsrc $abirefdir/src fi rm -rf $abirefdir/build -- 2.25.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* RE: [EXT] [PATCH 2/2] devtools: configure source repo to use as ABI reference 2022-12-06 12:23 ` [PATCH 2/2] devtools: configure source repo to use as ABI reference Ferruh Yigit @ 2022-12-08 18:14 ` Akhil Goyal 2022-12-08 19:43 ` Thomas Monjalon 2022-12-09 8:22 ` David Marchand 1 sibling, 1 reply; 10+ messages in thread From: Akhil Goyal @ 2022-12-08 18:14 UTC (permalink / raw) To: Ferruh Yigit, Thomas Monjalon, Bruce Richardson Cc: David Marchand, dev@dpdk.org > By default 'test-meson-builds.sh' script clones the repository which the > script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') > as a reference for ABI check. > > This patch enables selecting different repository to close for reference > using 'DPDK_ABI_REF_SRC' environment variable. > > It is possible to put these variables to 'devel.config' config file, or > provide via command line, like: > ` > DPDK_ABI_REF_SRC=~/dpdk-stable/ \ > DPDK_ABI_REF_VERSION=v22.11.1 \ > DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ > ./devtools/test-meson-builds.sh > ` > > When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did > previously. > > Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that > other repo as a new 'remote' to the exiting git repository. > > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com> > --- Acked-by: Akhil Goyal <gakhil@marvell.com> Worked for me, but I still needed to clone the dpdk-stable repo manually. I was hoping, test-meson-build.sh would do that by itself. Had it been a tag in same repo, it would have been straight forward as before. I would still suggest to add a tag v22.11.1 in main branch and all can use that instead of v22.11. The fix that we are talking about is a mandatory one for each one to use for ABI checks, dpdk-stable patches are not mandatory for the users. -Akhil ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [EXT] [PATCH 2/2] devtools: configure source repo to use as ABI reference 2022-12-08 18:14 ` [EXT] " Akhil Goyal @ 2022-12-08 19:43 ` Thomas Monjalon 2022-12-09 4:16 ` Akhil Goyal 0 siblings, 1 reply; 10+ messages in thread From: Thomas Monjalon @ 2022-12-08 19:43 UTC (permalink / raw) To: Ferruh Yigit, Bruce Richardson, Akhil Goyal; +Cc: David Marchand, dev@dpdk.org 08/12/2022 19:14, Akhil Goyal: > > By default 'test-meson-builds.sh' script clones the repository which the > > script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') > > as a reference for ABI check. > > > > This patch enables selecting different repository to close for reference > > using 'DPDK_ABI_REF_SRC' environment variable. > > > > It is possible to put these variables to 'devel.config' config file, or > > provide via command line, like: > > ` > > DPDK_ABI_REF_SRC=~/dpdk-stable/ \ > > DPDK_ABI_REF_VERSION=v22.11.1 \ > > DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ > > ./devtools/test-meson-builds.sh > > ` > > > > When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did > > previously. > > > > Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that > > other repo as a new 'remote' to the exiting git repository. > > > > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com> > > --- > > Acked-by: Akhil Goyal <gakhil@marvell.com> > > Worked for me, but I still needed to clone the dpdk-stable repo manually. > I was hoping, test-meson-build.sh would do that by itself. > Had it been a tag in same repo, it would have been straight forward as before. > I would still suggest to add a tag v22.11.1 in main branch and all can use that instead of v22.11. First, v22.11.1 exists already in dpdk-stable. Second, vXX.YY.z tags are supposed to be only in dpdk-stable. > The fix that we are talking about is a mandatory one for each one to use for ABI checks, > dpdk-stable patches are not mandatory for the users. You could have dpdk-stable as a remote in your main DPDK directory. If you don't want to do that, you could refer to the commit SHA1 of the fix I think. ^ permalink raw reply [flat|nested] 10+ messages in thread
* RE: [EXT] [PATCH 2/2] devtools: configure source repo to use as ABI reference 2022-12-08 19:43 ` Thomas Monjalon @ 2022-12-09 4:16 ` Akhil Goyal 0 siblings, 0 replies; 10+ messages in thread From: Akhil Goyal @ 2022-12-09 4:16 UTC (permalink / raw) To: Thomas Monjalon, Ferruh Yigit, Bruce Richardson Cc: David Marchand, dev@dpdk.org > 08/12/2022 19:14, Akhil Goyal: > > > By default 'test-meson-builds.sh' script clones the repository which the > > > script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') > > > as a reference for ABI check. > > > > > > This patch enables selecting different repository to close for reference > > > using 'DPDK_ABI_REF_SRC' environment variable. > > > > > > It is possible to put these variables to 'devel.config' config file, or > > > provide via command line, like: > > > ` > > > DPDK_ABI_REF_SRC=~/dpdk-stable/ \ > > > DPDK_ABI_REF_VERSION=v22.11.1 \ > > > DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ > > > ./devtools/test-meson-builds.sh > > > ` > > > > > > When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did > > > previously. > > > > > > Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that > > > other repo as a new 'remote' to the exiting git repository. > > > > > > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com> > > > --- > > > > Acked-by: Akhil Goyal <gakhil@marvell.com> > > > > Worked for me, but I still needed to clone the dpdk-stable repo manually. > > I was hoping, test-meson-build.sh would do that by itself. > > Had it been a tag in same repo, it would have been straight forward as before. > > I would still suggest to add a tag v22.11.1 in main branch and all can use that > instead of v22.11. > > First, v22.11.1 exists already in dpdk-stable. > Second, vXX.YY.z tags are supposed to be only in dpdk-stable. May be some other tag name we can think. v22.11.hotfix or something better. I was just asking to give a name to commit, and NOT updating the VERSION file. > > > The fix that we are talking about is a mandatory one for each one to use for > ABI checks, > > dpdk-stable patches are not mandatory for the users. > > You could have dpdk-stable as a remote in your main DPDK directory. > If you don't want to do that, you could refer to the commit SHA1 of the fix I > think. > Adding remote did not solve the issue as the commits are different(version commit). I cloned stable repo separately and it worked for me. Since you refer to use commit SHA, why not give it a name, remembering SHA is not easy. -Akhil ^ permalink raw reply [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] devtools: configure source repo to use as ABI reference 2022-12-06 12:23 ` [PATCH 2/2] devtools: configure source repo to use as ABI reference Ferruh Yigit 2022-12-08 18:14 ` [EXT] " Akhil Goyal @ 2022-12-09 8:22 ` David Marchand 2022-12-09 8:44 ` Ferruh Yigit 1 sibling, 1 reply; 10+ messages in thread From: David Marchand @ 2022-12-09 8:22 UTC (permalink / raw) To: Ferruh Yigit; +Cc: Thomas Monjalon, Bruce Richardson, dev, Akhil Goyal On Tue, Dec 6, 2022 at 1:24 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote: > > By default 'test-meson-builds.sh' script clones the repository which the > script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') > as a reference for ABI check. > > This patch enables selecting different repository to close for reference > using 'DPDK_ABI_REF_SRC' environment variable. > > It is possible to put these variables to 'devel.config' config file, or > provide via command line, like: > ` > DPDK_ABI_REF_SRC=~/dpdk-stable/ \ DPDK_ABI_REF_SRC could be passed as a remote repository. This should remove the need for any "git remote" configuration. $ DPDK_ABI_REF_SRC=https://dpdk.org/git/dpdk-stable DPDK_ABI_REF_VERSION=v22.11.1 ./devtools/test-meson-builds.sh diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 406bf4e184..48f4e52df3 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -18,8 +18,8 @@ srcdir=$(dirname $(readlink -f $0))/.. # # - DPDK_MESON_OPTIONS # -# - DPDK_ABI_REF_SRC # - DPDK_ABI_REF_DIR +# - DPDK_ABI_REF_SRC # - DPDK_ABI_REF_VERSION # # - DPDK_BUILD_TEST_EXAMPLES @@ -186,10 +186,14 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options] if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION if [ ! -d $abirefdir/$targetdir ]; then - abirefsrc=${DPDK_ABI_REF_SRC:-$srcdir} # clone current sources if [ ! -d $abirefdir/src ]; then - git clone --local --no-hardlinks \ + abirefsrc=${DPDK_ABI_REF_SRC:-$srcdir} + abirefcloneopts= + if [ -d $abirefsrc ]; then + abirefcloneopts="--local --no-hardlinks" + fi + git clone $abirefcloneopts \ --single-branch \ -b $DPDK_ABI_REF_VERSION \ $abirefsrc $abirefdir/src > DPDK_ABI_REF_VERSION=v22.11.1 \ > DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ > ./devtools/test-meson-builds.sh > ` > > When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did > previously. > > Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that > other repo as a new 'remote' to the exiting git repository. -- David Marchand ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH 2/2] devtools: configure source repo to use as ABI reference 2022-12-09 8:22 ` David Marchand @ 2022-12-09 8:44 ` Ferruh Yigit 0 siblings, 0 replies; 10+ messages in thread From: Ferruh Yigit @ 2022-12-09 8:44 UTC (permalink / raw) To: David Marchand; +Cc: Thomas Monjalon, Bruce Richardson, dev, Akhil Goyal On 12/9/2022 8:22 AM, David Marchand wrote: > On Tue, Dec 6, 2022 at 1:24 PM Ferruh Yigit <ferruh.yigit@amd.com> wrote: >> >> By default 'test-meson-builds.sh' script clones the repository which the >> script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') >> as a reference for ABI check. >> >> This patch enables selecting different repository to close for reference >> using 'DPDK_ABI_REF_SRC' environment variable. >> >> It is possible to put these variables to 'devel.config' config file, or >> provide via command line, like: >> ` >> DPDK_ABI_REF_SRC=~/dpdk-stable/ \ > > DPDK_ABI_REF_SRC could be passed as a remote repository. > This should remove the need for any "git remote" configuration. > > $ DPDK_ABI_REF_SRC=https://dpdk.org/git/dpdk-stable > DPDK_ABI_REF_VERSION=v22.11.1 ./devtools/test-meson-builds.sh > +1 to 'DPDK_ABI_REF_SRC' accept either folder or remote git repo. Can you send a v2 with your sign off added, or do you want me send a v2? > > diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh > index 406bf4e184..48f4e52df3 100755 > --- a/devtools/test-meson-builds.sh > +++ b/devtools/test-meson-builds.sh > @@ -18,8 +18,8 @@ srcdir=$(dirname $(readlink -f $0))/.. > # > # - DPDK_MESON_OPTIONS > # > -# - DPDK_ABI_REF_SRC > # - DPDK_ABI_REF_DIR > +# - DPDK_ABI_REF_SRC > # - DPDK_ABI_REF_VERSION > # > # - DPDK_BUILD_TEST_EXAMPLES > @@ -186,10 +186,14 @@ build () # <directory> <target cc | cross file> > <ABI check> [meson options] > if [ -n "$DPDK_ABI_REF_VERSION" -a "$abicheck" = ABI ] ; then > abirefdir=${DPDK_ABI_REF_DIR:-reference}/$DPDK_ABI_REF_VERSION > if [ ! -d $abirefdir/$targetdir ]; then > - abirefsrc=${DPDK_ABI_REF_SRC:-$srcdir} > # clone current sources > if [ ! -d $abirefdir/src ]; then > - git clone --local --no-hardlinks \ > + abirefsrc=${DPDK_ABI_REF_SRC:-$srcdir} > + abirefcloneopts= > + if [ -d $abirefsrc ]; then > + abirefcloneopts="--local --no-hardlinks" > + fi > + git clone $abirefcloneopts \ > --single-branch \ > -b $DPDK_ABI_REF_VERSION \ > $abirefsrc $abirefdir/src > > >> DPDK_ABI_REF_VERSION=v22.11.1 \ >> DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ >> ./devtools/test-meson-builds.sh >> ` >> >> When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did >> previously. >> >> Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that >> other repo as a new 'remote' to the exiting git repository. > > > ^ permalink raw reply [flat|nested] 10+ messages in thread
* [PATCH v2 1/2] devtools: document test meson script config options 2022-12-06 12:23 [PATCH 1/2] devtools: document test meson script config options Ferruh Yigit 2022-12-06 12:23 ` [PATCH 2/2] devtools: configure source repo to use as ABI reference Ferruh Yigit @ 2022-12-09 9:02 ` David Marchand 2022-12-09 9:02 ` [PATCH v2 2/2] devtools: configure source repo to use as ABI reference David Marchand 1 sibling, 1 reply; 10+ messages in thread From: David Marchand @ 2022-12-09 9:02 UTC (permalink / raw) To: dev; +Cc: thomas, bruce.richardson, gakhil, Ferruh Yigit From: Ferruh Yigit <ferruh.yigit@amd.com> Document config options of script that can be provided by 'devel.config' config file. Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com> --- devtools/test-meson-builds.sh | 10 ++++++++++ 1 file changed, 10 insertions(+) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 7efd5576fc..02541c19aa 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -12,6 +12,16 @@ PIPEFAIL="" set -o | grep -q pipefail && set -o pipefail && PIPEFAIL=1 srcdir=$(dirname $(readlink -f $0))/.. + +# Load config options: +# - DPDK_BUILD_TEST_DIR +# +# - DPDK_MESON_OPTIONS +# +# - DPDK_ABI_REF_DIR +# - DPDK_ABI_REF_VERSION +# +# - DPDK_BUILD_TEST_EXAMPLES . $srcdir/devtools/load-devel-config MESON=${MESON:-meson} -- 2.38.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* [PATCH v2 2/2] devtools: configure source repo to use as ABI reference 2022-12-09 9:02 ` [PATCH v2 1/2] devtools: document test meson script config options David Marchand @ 2022-12-09 9:02 ` David Marchand 2022-12-21 15:02 ` David Marchand 0 siblings, 1 reply; 10+ messages in thread From: David Marchand @ 2022-12-09 9:02 UTC (permalink / raw) To: dev; +Cc: thomas, bruce.richardson, gakhil, Ferruh Yigit From: Ferruh Yigit <ferruh.yigit@amd.com> By default 'test-meson-builds.sh' script clones the repository which the script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') as a reference for ABI check. This patch enables selecting different repository to clone for reference using 'DPDK_ABI_REF_SRC' environment variable. 'DPDK_ABI_REF_SRC' may refer to a directory containing a cloned git repository, or a remote git repository. It is possible to put these variables to 'devel.config' config file, or provide via command line, like: ` DPDK_ABI_REF_SRC=https://dpdk.org/git/dpdk-stable \ DPDK_ABI_REF_VERSION=v22.11.1 \ DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ ./devtools/test-meson-builds.sh ` When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did previously. Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that other repo as a new 'remote' to the exiting git repository. Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com> Acked-by: Akhil Goyal <gakhil@marvell.com> Signed-off-by: David Marchand <david.marchand@redhat.com> --- Changes since v1: - expanded DPDK_ABI_REF_SRC usage to "non-local" sources, --- devtools/test-meson-builds.sh | 10 ++++++++-- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh index 02541c19aa..48f4e52df3 100755 --- a/devtools/test-meson-builds.sh +++ b/devtools/test-meson-builds.sh @@ -19,6 +19,7 @@ srcdir=$(dirname $(readlink -f $0))/.. # - DPDK_MESON_OPTIONS # # - DPDK_ABI_REF_DIR +# - DPDK_ABI_REF_SRC # - DPDK_ABI_REF_VERSION # # - DPDK_BUILD_TEST_EXAMPLES @@ -187,10 +188,15 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options] if [ ! -d $abirefdir/$targetdir ]; then # clone current sources if [ ! -d $abirefdir/src ]; then - git clone --local --no-hardlinks \ + abirefsrc=${DPDK_ABI_REF_SRC:-$srcdir} + abirefcloneopts= + if [ -d $abirefsrc ]; then + abirefcloneopts="--local --no-hardlinks" + fi + git clone $abirefcloneopts \ --single-branch \ -b $DPDK_ABI_REF_VERSION \ - $srcdir $abirefdir/src + $abirefsrc $abirefdir/src fi rm -rf $abirefdir/build -- 2.38.1 ^ permalink raw reply related [flat|nested] 10+ messages in thread
* Re: [PATCH v2 2/2] devtools: configure source repo to use as ABI reference 2022-12-09 9:02 ` [PATCH v2 2/2] devtools: configure source repo to use as ABI reference David Marchand @ 2022-12-21 15:02 ` David Marchand 0 siblings, 0 replies; 10+ messages in thread From: David Marchand @ 2022-12-21 15:02 UTC (permalink / raw) To: dev; +Cc: thomas, bruce.richardson, gakhil, Ferruh Yigit On Fri, Dec 9, 2022 at 10:02 AM David Marchand <david.marchand@redhat.com> wrote: > > From: Ferruh Yigit <ferruh.yigit@amd.com> > > By default 'test-meson-builds.sh' script clones the repository which the > script is in, and selects a configured branch ('DPDK_ABI_REF_VERSION') > as a reference for ABI check. > > This patch enables selecting different repository to clone for reference > using 'DPDK_ABI_REF_SRC' environment variable. > 'DPDK_ABI_REF_SRC' may refer to a directory containing a cloned git > repository, or a remote git repository. > > It is possible to put these variables to 'devel.config' config file, or > provide via command line, like: > ` > DPDK_ABI_REF_SRC=https://dpdk.org/git/dpdk-stable \ > DPDK_ABI_REF_VERSION=v22.11.1 \ > DPDK_ABI_REF_DIR=/tmp/dpdk-abiref \ > ./devtools/test-meson-builds.sh > ` > > When 'DPDK_ABI_REF_SRC' is not defined, script behaves as it did > previously. > > Other alternative to using 'DPDK_ABI_REF_SRC' variable is adding that > other repo as a new 'remote' to the exiting git repository. > > Signed-off-by: Ferruh Yigit <ferruh.yigit@amd.com> > Acked-by: Akhil Goyal <gakhil@marvell.com> > Signed-off-by: David Marchand <david.marchand@redhat.com> > --- > Changes since v1: > - expanded DPDK_ABI_REF_SRC usage to "non-local" sources, Series applied, thanks. -- David Marchand ^ permalink raw reply [flat|nested] 10+ messages in thread
end of thread, other threads:[~2022-12-21 15:02 UTC | newest] Thread overview: 10+ messages (download: mbox.gz follow: Atom feed -- links below jump to the message on this page -- 2022-12-06 12:23 [PATCH 1/2] devtools: document test meson script config options Ferruh Yigit 2022-12-06 12:23 ` [PATCH 2/2] devtools: configure source repo to use as ABI reference Ferruh Yigit 2022-12-08 18:14 ` [EXT] " Akhil Goyal 2022-12-08 19:43 ` Thomas Monjalon 2022-12-09 4:16 ` Akhil Goyal 2022-12-09 8:22 ` David Marchand 2022-12-09 8:44 ` Ferruh Yigit 2022-12-09 9:02 ` [PATCH v2 1/2] devtools: document test meson script config options David Marchand 2022-12-09 9:02 ` [PATCH v2 2/2] devtools: configure source repo to use as ABI reference David Marchand 2022-12-21 15:02 ` David Marchand
This is a public inbox, see mirroring instructions for how to clone and mirror all data and code used for this inbox