From: Thomas Monjalon <thomas@monjalon.net>
To: Lukasz Wojciechowski <l.wojciechow@partner.samsung.com>,
Anoob Joseph <anoobj@marvell.com>
Cc: Akhil Goyal <akhil.goyal@nxp.com>,
Declan Doherty <declan.doherty@intel.com>,
Aviad Yehezkel <aviadye@mellanox.com>,
Boris Pismenny <borisp@mellanox.com>,
Radu Nicolau <radu.nicolau@intel.com>,
Anoob Joseph <anoob.joseph@caviumnetworks.com>,
"dev@dpdk.org" <dev@dpdk.org>,
"stable@dpdk.org" <stable@dpdk.org>
Subject: Re: [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters
Date: Wed, 08 Apr 2020 15:26:38 +0200 [thread overview]
Message-ID: <8635541.CDJkKcVGEf@thomas> (raw)
In-Reply-To: <MN2PR18MB28771B123F21BDFF4CFA6331DFC00@MN2PR18MB2877.namprd18.prod.outlook.com>
08/04/2020 15:02, Anoob Joseph:
> Hi Thomas,
>
> > 08/04/2020 05:13, Lukasz Wojciechowski:
> > > This patch adds verification of the parameters to the ret_security API
> > > functions. All required parameters are checked if they are not NULL.
> > [...]
> > > --- a/config/common_base
> > > +++ b/config/common_base
> > > CONFIG_RTE_LIBRTE_SECURITY=y
> > > +CONFIG_RTE_LIBRTE_SECURITY_DEBUG=n
> >
> > Is it a leftover?
> >
>
> [Anoob] It is similar to 'RTE_LIBRTE_ETHDEV_DEBUG' for usage in datapath. Like in, http://code.dpdk.org/dpdk/latest/source/lib/librte_ethdev/rte_ethdev.h#L4378
1/ I don't see it used in this patch
2/ Adding makefile-only option is weird
3/ Adding new compile-time options is discouraged
next prev parent reply other threads:[~2020-04-08 13:26 UTC|newest]
Thread overview: 80+ messages / expand[flat|nested] mbox.gz Atom feed top
[not found] <CGME20200312151708eucas1p2a80bb2ac0556c7d7efb3aedd83923e52@eucas1p2.samsung.com>
2020-03-12 15:16 ` [dpdk-dev] [PATCH 00/13] Fixes and unit tests for librte_security Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 01/13] librte_security: fix verification of parameters Lukasz Wojciechowski
2020-03-17 12:59 ` Anoob Joseph
2020-04-03 18:36 ` Lukasz Wojciechowski
2020-04-05 12:54 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-04-06 18:49 ` Lukasz Wojciechowski
2020-04-07 6:20 ` Anoob Joseph
2020-04-08 3:25 ` Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 02/13] librte_security: fix return types in documentation Lukasz Wojciechowski
2020-03-17 16:34 ` Anoob Joseph
2020-03-12 15:16 ` [dpdk-dev] [PATCH 03/13] librte_security: fix session counter Lukasz Wojciechowski
2020-03-17 17:08 ` Anoob Joseph
2020-03-12 15:16 ` [dpdk-dev] [PATCH 04/13] app/test: fix macro definition Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 05/13] app/test: introduce librte_security tests Lukasz Wojciechowski
2020-04-01 17:09 ` Akhil Goyal
2020-04-01 17:51 ` Thomas Monjalon
2020-04-02 19:49 ` Lukasz Wojciechowski
2020-04-02 20:51 ` Thomas Monjalon
2020-04-03 19:24 ` Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 06/13] app/test: add rte_security_session_update tests Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 07/13] app/test: add rte_security_session_get_size tests Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 08/13] app/test: add rte_security_session_stats_get tests Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 09/13] app/test: add rte_security_session_destroy tests Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 10/13] app/test: add rte_security_set_pkt_metadata tests Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 11/13] app/test: add rte_security_get_userdata tests Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 12/13] app/test: add rte_security_capabilities_get tests Lukasz Wojciechowski
2020-03-12 15:16 ` [dpdk-dev] [PATCH 13/13] app/test: add rte_security_capability_get tests Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 00/13] Fixes and unit tests for librte_security Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 01/13] security: fix verification of parameters Lukasz Wojciechowski
2020-04-08 12:54 ` Thomas Monjalon
2020-04-08 13:02 ` Anoob Joseph
2020-04-08 13:26 ` Thomas Monjalon [this message]
2020-04-08 14:44 ` [dpdk-dev] [EXT] " Anoob Joseph
2020-04-08 15:49 ` Lukasz Wojciechowski
2020-04-08 17:51 ` Thomas Monjalon
2020-04-09 10:14 ` Bruce Richardson
2020-04-09 10:54 ` Thomas Monjalon
2020-04-09 11:13 ` Bruce Richardson
2020-04-09 14:07 ` Lukasz Wojciechowski
2020-04-09 14:21 ` Lukasz Wojciechowski
2020-04-09 15:22 ` Thomas Monjalon
2020-04-09 16:10 ` Lukasz Wojciechowski
2020-04-10 8:45 ` Bruce Richardson
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 02/13] security: fix return types in documentation Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 03/13] security: fix session counter Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 04/13] app/test: fix macro definition Lukasz Wojciechowski
2020-04-08 12:53 ` Thomas Monjalon
2020-04-08 16:15 ` Lukasz Wojciechowski
2020-04-08 17:47 ` Thomas Monjalon
2020-04-09 14:10 ` Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 05/13] app/test: introduce librte security tests Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 06/13] app/test: add rte security session update tests Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 07/13] app/test: add rte security session get size tests Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 08/13] app/test: add rte security session stats get tests Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 09/13] app/test: add rte security session destroy tests Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 10/13] app/test: add rte security set pkt metadata tests Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 11/13] app/test: add rte security get userdata tests Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 12/13] app/test: add rte security capabilities get tests Lukasz Wojciechowski
2020-04-08 3:13 ` [dpdk-dev] [PATCH v2 13/13] app/test: add rte security capability " Lukasz Wojciechowski
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security Lukasz Wojciechowski
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 01/13] security: fix verification of parameters Lukasz Wojciechowski
2020-04-13 15:42 ` Anoob Joseph
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 02/13] security: fix return types in documentation Lukasz Wojciechowski
2020-04-13 15:43 ` Anoob Joseph
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 03/13] security: fix session counter Lukasz Wojciechowski
2020-04-13 15:48 ` Anoob Joseph
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 04/13] app/test: remove macro definition Lukasz Wojciechowski
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 05/13] app/test: introduce librte security tests Lukasz Wojciechowski
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 06/13] app/test: add rte security session update tests Lukasz Wojciechowski
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 07/13] app/test: add rte security session get size tests Lukasz Wojciechowski
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 08/13] app/test: add rte security session stats get tests Lukasz Wojciechowski
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 09/13] app/test: add rte security session destroy tests Lukasz Wojciechowski
2020-04-09 17:24 ` [dpdk-dev] [PATCH v3 10/13] app/test: add rte security set pkt metadata tests Lukasz Wojciechowski
2020-04-09 17:25 ` [dpdk-dev] [PATCH v3 11/13] app/test: add rte security get userdata tests Lukasz Wojciechowski
2020-04-09 17:25 ` [dpdk-dev] [PATCH v3 12/13] app/test: add rte security capabilities get tests Lukasz Wojciechowski
2020-04-09 17:25 ` [dpdk-dev] [PATCH v3 13/13] app/test: add rte security capability " Lukasz Wojciechowski
2020-04-17 19:46 ` [dpdk-dev] [PATCH v3 00/13] Fixes and unit tests for librte_security Akhil Goyal
2020-04-17 20:14 ` Lukasz Wojciechowski
2020-04-17 20:21 ` Akhil Goyal
2020-04-17 20:39 ` Lukasz Wojciechowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=8635541.CDJkKcVGEf@thomas \
--to=thomas@monjalon.net \
--cc=akhil.goyal@nxp.com \
--cc=anoob.joseph@caviumnetworks.com \
--cc=anoobj@marvell.com \
--cc=aviadye@mellanox.com \
--cc=borisp@mellanox.com \
--cc=declan.doherty@intel.com \
--cc=dev@dpdk.org \
--cc=l.wojciechow@partner.samsung.com \
--cc=radu.nicolau@intel.com \
--cc=stable@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox