* ice driver compiler warning
@ 2026-08-01 9:00 Morten Brørup
2026-08-01 15:22 ` Stephen Hemminger
2026-08-13 11:15 ` [PATCH] net/ice/base: allow array bounds warnings Bruce Richardson
0 siblings, 2 replies; 4+ messages in thread
From: Morten Brørup @ 2026-08-01 9:00 UTC (permalink / raw)
To: bruce.richardson, Anatoly Burakov; +Cc: dev
ice driver maintainers,
Is the ice base driver still defining structure fields with [0], or has it been updated to use []?
Maybe the workaround in meson.build is not required anymore:
# Bugzilla ID: 678
if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
error_cflags += ['-Wno-array-bounds']
endif
Ref:
https://github.com/DPDK/dpdk/blob/main/drivers/net/intel/ice/base/meson.build#L49
Venlig hilsen / Kind regards,
-Morten Brørup
^ permalink raw reply [flat|nested] 4+ messages in thread
* Re: ice driver compiler warning
2026-08-01 9:00 ice driver compiler warning Morten Brørup
@ 2026-08-01 15:22 ` Stephen Hemminger
2026-08-13 11:15 ` [PATCH] net/ice/base: allow array bounds warnings Bruce Richardson
1 sibling, 0 replies; 4+ messages in thread
From: Stephen Hemminger @ 2026-08-01 15:22 UTC (permalink / raw)
To: Morten Brørup; +Cc: bruce.richardson, Anatoly Burakov, dev
On Sat, 1 Aug 2026 11:00:38 +0200
Morten Brørup <mb@smartsharesystems.com> wrote:
> ice driver maintainers,
>
> Is the ice base driver still defining structure fields with [0], or has it been updated to use []?
> Maybe the workaround in meson.build is not required anymore:
>
> # Bugzilla ID: 678
> if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
> error_cflags += ['-Wno-array-bounds']
> endif
>
> Ref:
> https://github.com/DPDK/dpdk/blob/main/drivers/net/intel/ice/base/meson.build#L49
>
>
> Venlig hilsen / Kind regards,
> -Morten Brørup
>
>
Looks like it could be dropped. I see no errors with Gcc 18
^ permalink raw reply [flat|nested] 4+ messages in thread
* [PATCH] net/ice/base: allow array bounds warnings
2026-08-01 9:00 ice driver compiler warning Morten Brørup
2026-08-01 15:22 ` Stephen Hemminger
@ 2026-08-13 11:15 ` Bruce Richardson
2026-08-13 11:48 ` Morten Brørup
1 sibling, 1 reply; 4+ messages in thread
From: Bruce Richardson @ 2026-08-13 11:15 UTC (permalink / raw)
To: dev; +Cc: stephen, mb, Bruce Richardson
Since there are no zero-length arrays in the base code any more, remove
the -Wno-array-bounds build flag.
Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
---
drivers/net/intel/ice/base/meson.build | 5 -----
1 file changed, 5 deletions(-)
diff --git a/drivers/net/intel/ice/base/meson.build b/drivers/net/intel/ice/base/meson.build
index fd079c41cf..da961f0752 100644
--- a/drivers/net/intel/ice/base/meson.build
+++ b/drivers/net/intel/ice/base/meson.build
@@ -44,11 +44,6 @@ else
]
endif
-# Bugzilla ID: 678
-if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
- error_cflags += ['-Wno-array-bounds']
-endif
-
foreach flag: error_cflags
if cc.has_argument(flag)
base_cflags += flag
--
2.53.0
^ permalink raw reply related [flat|nested] 4+ messages in thread
* RE: [PATCH] net/ice/base: allow array bounds warnings
2026-08-13 11:15 ` [PATCH] net/ice/base: allow array bounds warnings Bruce Richardson
@ 2026-08-13 11:48 ` Morten Brørup
0 siblings, 0 replies; 4+ messages in thread
From: Morten Brørup @ 2026-08-13 11:48 UTC (permalink / raw)
To: Bruce Richardson, dev; +Cc: stephen
> From: Bruce Richardson [mailto:bruce.richardson@intel.com]
> Sent: Thursday, 13 August 2026 13.15
>
> Since there are no zero-length arrays in the base code any more, remove
> the -Wno-array-bounds build flag.
>
> Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> ---
> drivers/net/intel/ice/base/meson.build | 5 -----
> 1 file changed, 5 deletions(-)
>
> diff --git a/drivers/net/intel/ice/base/meson.build
> b/drivers/net/intel/ice/base/meson.build
> index fd079c41cf..da961f0752 100644
> --- a/drivers/net/intel/ice/base/meson.build
> +++ b/drivers/net/intel/ice/base/meson.build
> @@ -44,11 +44,6 @@ else
> ]
> endif
>
> -# Bugzilla ID: 678
> -if (toolchain == 'gcc' and cc.version().version_compare('>=11.0.0'))
> - error_cflags += ['-Wno-array-bounds']
> -endif
> -
Good catch!
Consequential workarounds like this are often overlooked when the workaround is not necessary anymore.
Patchwork should have a "fixed/workaround" state for tracking workarounds, so they can be properly cleaned up like this.
The root cause has been fixed, so by removing this last detail of the workaround the bug is truly "fixed/resolved".
Acked-by: Morten Brørup <mb@smartsharesystems.com>
^ permalink raw reply [flat|nested] 4+ messages in thread
end of thread, other threads:[~2026-08-13 11:48 UTC | newest]
Thread overview: 4+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-08-01 9:00 ice driver compiler warning Morten Brørup
2026-08-01 15:22 ` Stephen Hemminger
2026-08-13 11:15 ` [PATCH] net/ice/base: allow array bounds warnings Bruce Richardson
2026-08-13 11:48 ` Morten Brørup
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox