From: "Burakov, Anatoly" <anatoly.burakov@intel.com>
To: Shaiq Wani <shaiq.wani@intel.com>, <dev@dpdk.org>,
<bruce.richardson@intel.com>, <aman.deep.singh@intel.com>
Subject: Re: [PATCH 4/7] net/ice: fix bare L2TPv2 flow rule deletion
Date: Fri, 5 Jun 2026 16:50:13 +0200 [thread overview]
Message-ID: <9ad57494-eabb-43a2-9372-77e8d5b82108@intel.com> (raw)
In-Reply-To: <20260427023115.1225843-5-shaiq.wani@intel.com>
On 4/27/2026 4:31 AM, Shaiq Wani wrote:
> Bare L2TPv2 flow rules (no inner PPP) fail on deletion because
> ice_fdir_is_tunnel_profile() forces a 2-segment profile with an empty
> inner segment the NIC cannot remove. Reset tunnel_type to NONE when
> no inner fields are present so a single-segment profile is used.
>
> Also normalize L2TPv2 flags_version in the SW hash key to only the
> CTRL/LEN/VER bits, preventing delete lookup mismatches when S/O/P
> bits differ from the create path.
>
> Fixes: 733640dae75e ("net/ice: support L2TPv2 flow pattern matching")
> Signed-off-by: Shaiq Wani <shaiq.wani@intel.com>
> ---
Needs rebase on account of memcpy changes, but easy enough to apply
manually.
Acked-by: Anatoly Burakov <anatoly.burakov@intel.com>
--
Thanks,
Anatoly
next prev parent reply other threads:[~2026-06-05 14:50 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-04-27 2:31 [PATCH 0/7] net/ice: L2TPv2 flow rule fixes Shaiq Wani
2026-04-27 2:31 ` [PATCH 1/7] net/ice: use granular PTYPEs for L2TPv2 PPP Shaiq Wani
2026-06-05 14:44 ` Burakov, Anatoly
2026-04-27 2:31 ` [PATCH 2/7] net/ice: add tunnel inset bits to flow input set map Shaiq Wani
2026-06-05 14:45 ` Burakov, Anatoly
2026-04-27 2:31 ` [PATCH 3/7] net/ice: fix L2TPv2 inner segment header setup Shaiq Wani
2026-06-05 14:47 ` Burakov, Anatoly
2026-04-27 2:31 ` [PATCH 4/7] net/ice: fix bare L2TPv2 flow rule deletion Shaiq Wani
2026-06-05 14:50 ` Burakov, Anatoly [this message]
2026-04-27 2:31 ` [PATCH 5/7] net/ice: fix GTP-U failure due to wrong tunnel profile Shaiq Wani
2026-06-05 14:51 ` Burakov, Anatoly
2026-04-27 2:31 ` [PATCH 6/7] net/ice: fix stale profile after L2TPv2 subtype change Shaiq Wani
2026-06-05 14:52 ` Burakov, Anatoly
2026-04-27 2:31 ` [PATCH 7/7] net/ice: pin outer Ethertype for L2TPv2 flow rules Shaiq Wani
2026-04-27 9:13 ` 回复: " Jiale, SongX
2026-06-05 14:54 ` Burakov, Anatoly
2026-06-05 15:20 ` [PATCH 0/7] net/ice: L2TPv2 flow rule fixes Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=9ad57494-eabb-43a2-9372-77e8d5b82108@intel.com \
--to=anatoly.burakov@intel.com \
--cc=aman.deep.singh@intel.com \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=shaiq.wani@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox