From: Thomas Monjalon <thomas@monjalon.net>
To: "Morten Brørup" <mb@smartsharesystems.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
Bruce Richardson <bruce.richardson@intel.com>,
Vipin Varghese <vipin.varghese@amd.com>,
Stephen Hemminger <stephen@networkplumber.org>,
Konstantin Ananyev <konstantin.ananyev@huawei.com>
Subject: Re: [PATCH v4] eal/x86: fix memcpy alignment mask definition
Date: Wed, 23 Sep 2026 18:52:17 +0200 [thread overview]
Message-ID: <AsJq5ADXSsikHxOP9jPwbg@monjalon.net> (raw)
In-Reply-To: <71bcbf4789914a059ccfd11758d72bb7@huawei.com>
> > An alignment mask (ALIGNMENT_MASK) is temporarily defined for internal
> > purposes, but it is publicly exposed when including the header file,
> > potentially colliding with existing definitions with the same name.
> > Fixed this potential issue by adding the RTE_MEMCPY_ prefix to the
> > definition.
> >
> > Furthermore, the superfluous function declaration at the top of the file
> > was removed, and its description was moved to the function definition,
> > to improve search results with source code browsers.
> >
> > Also, changed "!(addrs & MASK)" to "(addrs & MASK) == 0" to follow DPDK
> > coding style.
> >
> > None of these changes should have any practical effect.
> >
> > Fixes: f5472703c0bd ("eal: optimize aligned memcpy on x86")
> >
> > Signed-off-by: Morten Brørup <mb@smartsharesystems.com>
> > Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Konstantin Ananyev <konstantin.ananyev@huawei.com>
Applied, thanks.
prev parent reply other threads:[~2026-09-23 16:52 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-04 9:20 [PATCH] eal/x86: fix memcpy alignment mask definition Morten Brørup
2026-09-04 11:19 ` [PATCH v2] " Morten Brørup
2026-09-04 11:25 ` Bruce Richardson
2026-09-04 11:28 ` Morten Brørup
2026-09-04 11:31 ` [PATCH v3] " Morten Brørup
2026-09-04 11:34 ` [PATCH v4] " Morten Brørup
2026-09-07 14:10 ` Konstantin Ananyev
2026-09-23 16:52 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=AsJq5ADXSsikHxOP9jPwbg@monjalon.net \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=konstantin.ananyev@huawei.com \
--cc=mb@smartsharesystems.com \
--cc=stephen@networkplumber.org \
--cc=vipin.varghese@amd.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox