From: "Robin Jarry" <rjarry@redhat.com>
To: "Andrey Yudin" <Andrey.Yudin@infotecs.ru>,
"Jerin Jacob" <jerinj@marvell.com>,
"Kiran Kumar K" <kirankumark@marvell.com>,
"Nithin Dabilpuram" <ndabilpuram@marvell.com>,
"Zhirun Yan" <yanzhirun_163@163.com>,
"Pavan Nikhilesh" <pbhagavatula@marvell.com>
Cc: <dev@dpdk.org>, <stable@dpdk.org>
Subject: Re: [PATCH] graph: fix xstats of cloned nodes
Date: Wed, 08 Jul 2026 11:21:42 +0200 [thread overview]
Message-ID: <DJT2VEID22MV.563K8JCQL152@redhat.com> (raw)
In-Reply-To: <20260708081420.1100574-1-Andrey.Yudin@infotecs.ru>
Andrey Yudin, Jul 08, 2026 at 10:14:
> When cloning a node with xstats enabled, xstat_desc entries are copied
> into the rte_node_register structure, but the nb_xstats field is not.
>
> As a result, the cloned node reports zero available xstats,
> making xstats unusable.
>
> Copy the nb_xstats field when cloning the node so that cloned nodes
> preserve the xstats configuration of the original node.
>
> Fixes: 070db97e017b ("graph: support node xstats")
> Cc: stable@dpdk.org
> Signed-off-by: Andrey Yudin <Andrey.Yudin@infotecs.ru>
> ---
> lib/graph/node.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/graph/node.c b/lib/graph/node.c
> index 1fce3e6632..bb39c616de 100644
> --- a/lib/graph/node.c
> +++ b/lib/graph/node.c
> @@ -208,6 +208,7 @@ node_clone(struct node *node, const char *name)
> goto free;
> }
>
> + reg->xstats->nb_xstats = node->xstats->nb_xstats;
> for (i = 0; i < node->xstats->nb_xstats; i++)
> if (rte_strscpy(reg->xstats->xstat_desc[i], node->xstats->xstat_desc[i],
> RTE_NODE_XSTAT_DESC_SIZE) < 0)
Reviewed-by: Robin Jarry <rjarry@redhat.com>
prev parent reply other threads:[~2026-07-08 9:21 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-07-08 8:14 [PATCH] graph: fix xstats of cloned nodes Andrey Yudin
2026-07-08 9:21 ` Robin Jarry [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=DJT2VEID22MV.563K8JCQL152@redhat.com \
--to=rjarry@redhat.com \
--cc=Andrey.Yudin@infotecs.ru \
--cc=dev@dpdk.org \
--cc=jerinj@marvell.com \
--cc=kirankumark@marvell.com \
--cc=ndabilpuram@marvell.com \
--cc=pbhagavatula@marvell.com \
--cc=stable@dpdk.org \
--cc=yanzhirun_163@163.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox