* [PATCH] graph: fix xstats of cloned nodes
@ 2026-07-08 8:14 Andrey Yudin
2026-07-08 9:21 ` Robin Jarry
0 siblings, 1 reply; 2+ messages in thread
From: Andrey Yudin @ 2026-07-08 8:14 UTC (permalink / raw)
To: Jerin Jacob, Kiran Kumar K, Nithin Dabilpuram, Zhirun Yan,
Pavan Nikhilesh, Robin Jarry
Cc: dev, Andrey Yudin, stable
When cloning a node with xstats enabled, xstat_desc entries are copied
into the rte_node_register structure, but the nb_xstats field is not.
As a result, the cloned node reports zero available xstats,
making xstats unusable.
Copy the nb_xstats field when cloning the node so that cloned nodes
preserve the xstats configuration of the original node.
Fixes: 070db97e017b ("graph: support node xstats")
Cc: stable@dpdk.org
Signed-off-by: Andrey Yudin <Andrey.Yudin@infotecs.ru>
---
lib/graph/node.c | 1 +
1 file changed, 1 insertion(+)
diff --git a/lib/graph/node.c b/lib/graph/node.c
index 1fce3e6632..bb39c616de 100644
--- a/lib/graph/node.c
+++ b/lib/graph/node.c
@@ -208,6 +208,7 @@ node_clone(struct node *node, const char *name)
goto free;
}
+ reg->xstats->nb_xstats = node->xstats->nb_xstats;
for (i = 0; i < node->xstats->nb_xstats; i++)
if (rte_strscpy(reg->xstats->xstat_desc[i], node->xstats->xstat_desc[i],
RTE_NODE_XSTAT_DESC_SIZE) < 0)
--
2.47.3
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] graph: fix xstats of cloned nodes
2026-07-08 8:14 [PATCH] graph: fix xstats of cloned nodes Andrey Yudin
@ 2026-07-08 9:21 ` Robin Jarry
0 siblings, 0 replies; 2+ messages in thread
From: Robin Jarry @ 2026-07-08 9:21 UTC (permalink / raw)
To: Andrey Yudin, Jerin Jacob, Kiran Kumar K, Nithin Dabilpuram,
Zhirun Yan, Pavan Nikhilesh
Cc: dev, stable
Andrey Yudin, Jul 08, 2026 at 10:14:
> When cloning a node with xstats enabled, xstat_desc entries are copied
> into the rte_node_register structure, but the nb_xstats field is not.
>
> As a result, the cloned node reports zero available xstats,
> making xstats unusable.
>
> Copy the nb_xstats field when cloning the node so that cloned nodes
> preserve the xstats configuration of the original node.
>
> Fixes: 070db97e017b ("graph: support node xstats")
> Cc: stable@dpdk.org
> Signed-off-by: Andrey Yudin <Andrey.Yudin@infotecs.ru>
> ---
> lib/graph/node.c | 1 +
> 1 file changed, 1 insertion(+)
>
> diff --git a/lib/graph/node.c b/lib/graph/node.c
> index 1fce3e6632..bb39c616de 100644
> --- a/lib/graph/node.c
> +++ b/lib/graph/node.c
> @@ -208,6 +208,7 @@ node_clone(struct node *node, const char *name)
> goto free;
> }
>
> + reg->xstats->nb_xstats = node->xstats->nb_xstats;
> for (i = 0; i < node->xstats->nb_xstats; i++)
> if (rte_strscpy(reg->xstats->xstat_desc[i], node->xstats->xstat_desc[i],
> RTE_NODE_XSTAT_DESC_SIZE) < 0)
Reviewed-by: Robin Jarry <rjarry@redhat.com>
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-07-08 11:36 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-07-08 8:14 [PATCH] graph: fix xstats of cloned nodes Andrey Yudin
2026-07-08 9:21 ` Robin Jarry
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox