From: Thomas Monjalon <thomas@monjalon.net>
To: Stephen Hemminger <stephen@networkplumber.org>
Cc: dev@dpdk.org, stable@dpdk.org,
Bruce Richardson <bruce.richardson@intel.com>,
Jack Bond-Preston <jack.bond-preston@foss.arm.com>,
Pablo de Lara <pablo.de.lara.guarch@intel.com>,
Gavin Hu <gahu@nvidia.com>,
Honnappa Nagarahalli <honnappa.nagarahalli@arm.com>
Subject: Re: [PATCH v2] eal: silence -Wconstant-logical-operand in RTE_IS_POWER_OF_2
Date: Wed, 27 May 2026 10:41:16 +0200 [thread overview]
Message-ID: <JhREl7PiSzmieUUiQra_4A@monjalon.net> (raw)
In-Reply-To: <20260519135046.367128-1-stephen@networkplumber.org>
19/05/2026 15:49, Stephen Hemminger:
> Newer GCC warns when a non-boolean constant is an operand of &&, which
> trips whenever RTE_IS_POWER_OF_2 is used in a static_assert with a
> power-of-two literal. Make the zero check explicit.
>
> Fixes: 7c872b96983a ("hash: validate hash bucket entries while compiling")
> Cc: stable@dpdk.org
>
> Signed-off-by: Stephen Hemminger <stephen@networkplumber.org>
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>
> Acked-by: Jack Bond-Preston <jack.bond-preston@foss.arm.com>
> ---
> v2 - use suggestion to make both sides comparisons
Applied, thanks.
prev parent reply other threads:[~2026-05-27 8:41 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-05-18 16:33 [PATCH] eal: silence -Wconstant-logical-operand in RTE_IS_POWER_OF_2 Stephen Hemminger
2026-05-18 16:56 ` Bruce Richardson
2026-05-18 17:10 ` Stephen Hemminger
2026-05-19 9:26 ` Jack Bond-Preston
2026-05-19 13:49 ` [PATCH v2] " Stephen Hemminger
2026-05-27 8:41 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=JhREl7PiSzmieUUiQra_4A@monjalon.net \
--to=thomas@monjalon.net \
--cc=bruce.richardson@intel.com \
--cc=dev@dpdk.org \
--cc=gahu@nvidia.com \
--cc=honnappa.nagarahalli@arm.com \
--cc=jack.bond-preston@foss.arm.com \
--cc=pablo.de.lara.guarch@intel.com \
--cc=stable@dpdk.org \
--cc=stephen@networkplumber.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox