* [PATCH] net/iavf: remove redundant assignment in FDIR parser
@ 2026-09-15 9:50 Evgeny Sokolov
2026-09-25 12:45 ` Burakov, Anatoly
0 siblings, 1 reply; 2+ messages in thread
From: Evgeny Sokolov @ 2026-09-15 9:50 UTC (permalink / raw)
To: Vladimir Medvedkin; +Cc: dev, stable, jia.guo, Sokolov Evgeny
From: Sokolov Evgeny <Evgeny.Sokolov@infotecs.ru>
The assignment to next_type in the <case> branch is redundant since
the value is never used afterwards.
Remove the leftover assignment, which appears to have been copied from
another parser branch, to avoid confusing readers.
Found by InfoTeCS on behalf of Linux Verification Center (linuxtesting.org) with SVACE.
Signed-off-by: Sokolov Evgeny <Evgeny.Sokolov@infotecs.ru>
---
drivers/net/intel/iavf/iavf_fdir.c | 1 -
1 file changed, 1 deletion(-)
diff --git a/drivers/net/intel/iavf/iavf_fdir.c b/drivers/net/intel/iavf/iavf_fdir.c
index ea620863ca..a5fe90283f 100644
--- a/drivers/net/intel/iavf/iavf_fdir.c
+++ b/drivers/net/intel/iavf/iavf_fdir.c
@@ -711,7 +711,6 @@ iavf_fdir_parse_pattern(__rte_unused struct iavf_adapter *ad,
ipv4_spec = item->spec;
ipv4_last = item->last;
ipv4_mask = item->mask;
- next_type = (item + 1)->type;
hdr = &hdrs->proto_hdr[layer];
--
2.30.2
^ permalink raw reply related [flat|nested] 2+ messages in thread
* Re: [PATCH] net/iavf: remove redundant assignment in FDIR parser
2026-09-15 9:50 [PATCH] net/iavf: remove redundant assignment in FDIR parser Evgeny Sokolov
@ 2026-09-25 12:45 ` Burakov, Anatoly
0 siblings, 0 replies; 2+ messages in thread
From: Burakov, Anatoly @ 2026-09-25 12:45 UTC (permalink / raw)
To: Evgeny Sokolov, Vladimir Medvedkin; +Cc: dev, stable, jia.guo
On 9/15/2026 11:50 AM, Evgeny Sokolov wrote:
> From: Sokolov Evgeny <Evgeny.Sokolov@infotecs.ru>
>
> The assignment to next_type in the <case> branch is redundant since
> the value is never used afterwards.
>
> Remove the leftover assignment, which appears to have been copied from
> another parser branch, to avoid confusing readers.
>
> Found by InfoTeCS on behalf of Linux Verification Center (linuxtesting.org) with SVACE.
>
> Signed-off-by: Sokolov Evgeny <Evgeny.Sokolov@infotecs.ru>
> ---
This patch looks related to the other one [1] that you have submitted,
and my comments for that patch apply here as well.
Also, please do not put advertisements in commit message, thank you.
[1]
https://patches.dpdk.org/project/dpdk/patch/20260915104617.467149-1-Evgeny.Sokolov@infotecs.ru/
--
Thanks,
Anatoly
^ permalink raw reply [flat|nested] 2+ messages in thread
end of thread, other threads:[~2026-09-25 12:46 UTC | newest]
Thread overview: 2+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2026-09-15 9:50 [PATCH] net/iavf: remove redundant assignment in FDIR parser Evgeny Sokolov
2026-09-25 12:45 ` Burakov, Anatoly
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox