DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>
Cc: "Mandal, Anurag" <anurag.mandal@intel.com>,
	"dev@dpdk.org" <dev@dpdk.org>,
	 "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Subject: Re: [PATCH v2 2/7] net/iavf: defer device start when PF VSI not ready
Date: Thu, 13 Aug 2026 14:17:34 +0100	[thread overview]
Message-ID: <an3D7tNkwtS9RADr@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <IA4PR11MB92787BA8C6BB190A0EE0F31C8EDB2@IA4PR11MB9278.namprd11.prod.outlook.com>

On Thu, Aug 13, 2026 at 02:12:54PM +0100, Loftus, Ciara wrote:
> > Subject: [PATCH v2 2/7] net/iavf: defer device start when PF VSI not ready
> > 
> > During reset recovery iavf_dev_start() might fail (typically -EIO
> > from VIRTCHNL_OP_CONFIG_VSI_QUEUES) because the PF VSI is not yet
> > active, leaving the VF down and requiring manual intervention
> > to recover.
> > 
> > Added a start_pending flag: when device start fails during recovery,
> > defer it instead of erroring out and resume it from newly added
> > iavf_resume_pending_start() on the next link-up event, so the
> > VF comes back automatically.
> > 
> > Fixes: 105d9fcefbee ("net/iavf: fix race condition on link status change")
> 
> I don't think this is the correct Fixes tag. It seems like an issue that has
> been present since the recovery path was introduced. Maybe:
> 3e6a5d2d310a ("net/iavf: add devargs to enable VF auto-reset") ?
> 
> > 
> > Signed-off-by: Anurag Mandal <anurag.mandal@intel.com>
> > ---
>

If the rest of the series is ok, I can fix up things like fixes tags and
log message changes on commit, so no need to do up a new version just for
this alone 

/Bruce

  reply	other threads:[~2026-08-13 13:17 UTC|newest]

Thread overview: 47+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-08-06  8:26 [PATCH 0/5] net/iavf: harden reset recovery and data path on link flap Anurag Mandal
2026-08-06  8:26 ` [PATCH 1/5] net/iavf: discard empty AdminQ descriptors on reset Anurag Mandal
2026-08-07 10:10   ` Loftus, Ciara
2026-08-06  8:26 ` [PATCH 2/5] net/iavf: defer device start when PF VSI not ready Anurag Mandal
2026-08-07 10:46   ` Loftus, Ciara
2026-08-06  8:26 ` [PATCH 3/5] net/iavf: drain in-flight Tx before reset Anurag Mandal
2026-08-07 10:51   ` Loftus, Ciara
2026-08-06  8:26 ` [PATCH 4/5] net/iavf: change no_poll flag to atomic Anurag Mandal
2026-08-07 10:56   ` Loftus, Ciara
2026-08-06  8:26 ` [PATCH 5/5] net/iavf: improve VF reset detection on fast ARQ flip Anurag Mandal
2026-08-07 11:08   ` Loftus, Ciara
2026-08-13 10:45 ` [PATCH v2 0/7] net/iavf: harden reset recovery and data path on link flap Anurag Mandal
2026-08-13 10:45   ` [PATCH v2 1/7] net/iavf: discard empty AdminQ descriptors on reset Anurag Mandal
2026-08-13 13:01     ` Loftus, Ciara
2026-08-13 10:45   ` [PATCH v2 2/7] net/iavf: defer device start when PF VSI not ready Anurag Mandal
2026-08-13 13:12     ` Loftus, Ciara
2026-08-13 13:17       ` Bruce Richardson [this message]
2026-08-13 10:45   ` [PATCH v2 3/7] net/iavf: drain in-flight Tx before reset Anurag Mandal
2026-08-13 13:24     ` Loftus, Ciara
2026-08-13 10:45   ` [PATCH v2 4/7] net/iavf: change no_poll flag to atomic Anurag Mandal
2026-08-13 10:45   ` [PATCH v2 5/7] net/iavf: improve VF reset detection on fast ARQ flip Anurag Mandal
2026-08-13 13:48     ` Loftus, Ciara
2026-08-13 10:45   ` [PATCH v2 6/7] net/iavf: keep watchdog armed for the whole reset window Anurag Mandal
2026-08-13 13:54     ` Loftus, Ciara
2026-08-13 10:45   ` [PATCH v2 7/7] net/iavf: skip flow flush during PF-initiated reset Anurag Mandal
2026-08-13 13:56     ` Loftus, Ciara
2026-08-17  6:48 ` [PATCH v3 0/7] net/iavf: harden reset recovery and data path on link flap Anurag Mandal
2026-08-17  6:48   ` [PATCH v3 1/7] net/iavf: discard empty AdminQ descriptors on reset Anurag Mandal
2026-08-17  6:55     ` Mandal, Anurag
2026-08-17  6:48   ` [PATCH v3 2/7] net/iavf: defer device start when PF VSI not ready Anurag Mandal
2026-08-17  9:33     ` Loftus, Ciara
2026-08-17  6:48   ` [PATCH v3 3/7] net/iavf: drain in-flight Tx before reset Anurag Mandal
2026-08-17 10:46     ` Bruce Richardson
2026-08-17  6:48   ` [PATCH v3 4/7] net/iavf: change no_poll flag to atomic Anurag Mandal
2026-08-17  6:48   ` [PATCH v3 5/7] net/iavf: improve VF reset detection on fast ARQ flip Anurag Mandal
2026-08-17  6:48   ` [PATCH v3 6/7] net/iavf: keep watchdog armed for the whole reset window Anurag Mandal
2026-08-17  9:34     ` Loftus, Ciara
2026-08-17  6:48   ` [PATCH v3 7/7] net/iavf: skip flow flush during PF-initiated reset Anurag Mandal
2026-08-18  4:57 ` [PATCH v4 0/7] net/iavf: harden reset recovery and data path on link flap Anurag Mandal
2026-08-18  4:57   ` [PATCH v4 1/7] net/iavf: discard empty AdminQ descriptors on reset Anurag Mandal
2026-08-18  4:57   ` [PATCH v4 2/7] net/iavf: defer device start when PF VSI not ready Anurag Mandal
2026-08-18  4:57   ` [PATCH v4 3/7] net/iavf: drain in-flight Tx before reset Anurag Mandal
2026-08-18  4:57   ` [PATCH v4 4/7] net/iavf: change no_poll flag to atomic Anurag Mandal
2026-08-18  4:57   ` [PATCH v4 5/7] net/iavf: improve VF reset detection on fast ARQ flip Anurag Mandal
2026-08-18  4:57   ` [PATCH v4 6/7] net/iavf: keep watchdog armed for the whole reset window Anurag Mandal
2026-08-18  4:57   ` [PATCH v4 7/7] net/iavf: skip flow flush during PF-initiated reset Anurag Mandal
2026-08-18 14:32   ` [PATCH v4 0/7] net/iavf: harden reset recovery and data path on link flap Bruce Richardson

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=an3D7tNkwtS9RADr@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anurag.mandal@intel.com \
    --cc=ciara.loftus@intel.com \
    --cc=dev@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox