From: Bruce Richardson <bruce.richardson@intel.com>
To: Anurag Mandal <anurag.mandal@intel.com>
Cc: <dev@dpdk.org>, <vladimir.medvedkin@intel.com>, <ciara.loftus@intel.com>
Subject: Re: [PATCH v3 3/7] net/iavf: drain in-flight Tx before reset
Date: Mon, 17 Aug 2026 11:46:12 +0100 [thread overview]
Message-ID: <aoLmdIZKxCpA4V84@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <dad85e16c65b7966dcf767eee5000d8d5d127d06.1786948817.git.anurag.mandal@intel.com>
On Mon, Aug 17, 2026 at 06:48:42AM +0000, Anurag Mandal wrote:
> On a link-down or impending PF reset, in-flight Tx descriptors
> were left pending when the queues were torn down, which could
> trigger Malicious Driver Detection (MDD) events and
> leak descriptors.
>
I agree that this is a good idea on reset, but what about on link down? In
most of our drivers, if the link goes down, the Tx packets are left in the
descriptor ring to be sent when the link comes back up again. Can we manage
without the cleanup on link down? If the link is down to reconfigure,
the cleanup should be done as part of the reconfigure, I would think.
Am I missing something?
Also, if this prevents MDD events should it have a fixes tag and be
backported?
/Bruce
next prev parent reply other threads:[~2026-08-17 10:46 UTC|newest]
Thread overview: 47+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-06 8:26 [PATCH 0/5] net/iavf: harden reset recovery and data path on link flap Anurag Mandal
2026-08-06 8:26 ` [PATCH 1/5] net/iavf: discard empty AdminQ descriptors on reset Anurag Mandal
2026-08-07 10:10 ` Loftus, Ciara
2026-08-06 8:26 ` [PATCH 2/5] net/iavf: defer device start when PF VSI not ready Anurag Mandal
2026-08-07 10:46 ` Loftus, Ciara
2026-08-06 8:26 ` [PATCH 3/5] net/iavf: drain in-flight Tx before reset Anurag Mandal
2026-08-07 10:51 ` Loftus, Ciara
2026-08-06 8:26 ` [PATCH 4/5] net/iavf: change no_poll flag to atomic Anurag Mandal
2026-08-07 10:56 ` Loftus, Ciara
2026-08-06 8:26 ` [PATCH 5/5] net/iavf: improve VF reset detection on fast ARQ flip Anurag Mandal
2026-08-07 11:08 ` Loftus, Ciara
2026-08-13 10:45 ` [PATCH v2 0/7] net/iavf: harden reset recovery and data path on link flap Anurag Mandal
2026-08-13 10:45 ` [PATCH v2 1/7] net/iavf: discard empty AdminQ descriptors on reset Anurag Mandal
2026-08-13 13:01 ` Loftus, Ciara
2026-08-13 10:45 ` [PATCH v2 2/7] net/iavf: defer device start when PF VSI not ready Anurag Mandal
2026-08-13 13:12 ` Loftus, Ciara
2026-08-13 13:17 ` Bruce Richardson
2026-08-13 10:45 ` [PATCH v2 3/7] net/iavf: drain in-flight Tx before reset Anurag Mandal
2026-08-13 13:24 ` Loftus, Ciara
2026-08-13 10:45 ` [PATCH v2 4/7] net/iavf: change no_poll flag to atomic Anurag Mandal
2026-08-13 10:45 ` [PATCH v2 5/7] net/iavf: improve VF reset detection on fast ARQ flip Anurag Mandal
2026-08-13 13:48 ` Loftus, Ciara
2026-08-13 10:45 ` [PATCH v2 6/7] net/iavf: keep watchdog armed for the whole reset window Anurag Mandal
2026-08-13 13:54 ` Loftus, Ciara
2026-08-13 10:45 ` [PATCH v2 7/7] net/iavf: skip flow flush during PF-initiated reset Anurag Mandal
2026-08-13 13:56 ` Loftus, Ciara
2026-08-17 6:48 ` [PATCH v3 0/7] net/iavf: harden reset recovery and data path on link flap Anurag Mandal
2026-08-17 6:48 ` [PATCH v3 1/7] net/iavf: discard empty AdminQ descriptors on reset Anurag Mandal
2026-08-17 6:55 ` Mandal, Anurag
2026-08-17 6:48 ` [PATCH v3 2/7] net/iavf: defer device start when PF VSI not ready Anurag Mandal
2026-08-17 9:33 ` Loftus, Ciara
2026-08-17 6:48 ` [PATCH v3 3/7] net/iavf: drain in-flight Tx before reset Anurag Mandal
2026-08-17 10:46 ` Bruce Richardson [this message]
2026-08-17 6:48 ` [PATCH v3 4/7] net/iavf: change no_poll flag to atomic Anurag Mandal
2026-08-17 6:48 ` [PATCH v3 5/7] net/iavf: improve VF reset detection on fast ARQ flip Anurag Mandal
2026-08-17 6:48 ` [PATCH v3 6/7] net/iavf: keep watchdog armed for the whole reset window Anurag Mandal
2026-08-17 9:34 ` Loftus, Ciara
2026-08-17 6:48 ` [PATCH v3 7/7] net/iavf: skip flow flush during PF-initiated reset Anurag Mandal
2026-08-18 4:57 ` [PATCH v4 0/7] net/iavf: harden reset recovery and data path on link flap Anurag Mandal
2026-08-18 4:57 ` [PATCH v4 1/7] net/iavf: discard empty AdminQ descriptors on reset Anurag Mandal
2026-08-18 4:57 ` [PATCH v4 2/7] net/iavf: defer device start when PF VSI not ready Anurag Mandal
2026-08-18 4:57 ` [PATCH v4 3/7] net/iavf: drain in-flight Tx before reset Anurag Mandal
2026-08-18 4:57 ` [PATCH v4 4/7] net/iavf: change no_poll flag to atomic Anurag Mandal
2026-08-18 4:57 ` [PATCH v4 5/7] net/iavf: improve VF reset detection on fast ARQ flip Anurag Mandal
2026-08-18 4:57 ` [PATCH v4 6/7] net/iavf: keep watchdog armed for the whole reset window Anurag Mandal
2026-08-18 4:57 ` [PATCH v4 7/7] net/iavf: skip flow flush during PF-initiated reset Anurag Mandal
2026-08-18 14:32 ` [PATCH v4 0/7] net/iavf: harden reset recovery and data path on link flap Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoLmdIZKxCpA4V84@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anurag.mandal@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox