From: Thomas Monjalon <thomas@monjalon.net>
To: Kai Ji <kai.ji@intel.com>
Cc: dev@dpdk.org, Gowrishankar Muthukrishnan <gmuthukrishn@marvell.com>
Subject: Re: [dpdk-dev v11 0/2] app: add cryptodev validation applications
Date: Thu, 12 Nov 2026 19:42:12 +0100 [thread overview]
Message-ID: <aoLxq0f-RTCUdgN0nuzopA@monjalon.net> (raw)
In-Reply-To: <20261106161441.3818963-1-kai.ji@intel.com>
> Kai Ji (2):
> app: move FIPS validation under app/
> app: add Wycheproof validation app
>
> rename doc/guides/sample_app_ug/{fips_validation.rst => crypto_validation.rst} (70%)
The directory for the doc must be doc/guides/tools/.
I've fixed it and the dependency check message.
Applied to make progress.
A quick AI pass shows some issues in the code:
- bad timeout handling
- MAC validation
and in the doc:
- no mention of the Jansson dependency
- no link to the Wycheproof vectors repository
- no coverage details
Please address in following patches, thanks.
prev parent reply other threads:[~2026-11-12 18:42 UTC|newest]
Thread overview: 29+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-15 15:51 [PATCH] examples: add Wycheproof validation app Kai Ji
2026-09-15 16:58 ` Stephen Hemminger
2026-09-15 18:28 ` Stephen Hemminger
2026-09-17 15:34 ` [PATCH v3] " Kai Ji
2026-09-21 12:05 ` [EXTERNAL] " Gowrishankar Muthukrishnan
2026-09-21 16:41 ` Stephen Hemminger
2026-09-22 14:47 ` [PATCH v4] " Kai Ji
2026-09-22 16:05 ` [PATCH v5] " Kai Ji
2026-09-22 16:26 ` Stephen Hemminger
2026-09-23 10:50 ` [PATCH v6] " Kai Ji
2026-09-23 15:04 ` [PATCH v7] " Kai Ji
2026-09-24 14:35 ` [EXTERNAL] " Akhil Goyal
2026-09-24 15:01 ` Ji, Kai
2026-09-24 18:00 ` Akhil Goyal
2026-09-25 16:32 ` Thomas Monjalon
2026-09-29 16:12 ` Ji, Kai
2026-09-29 18:21 ` Akhil Goyal
2026-10-13 15:20 ` [PATCH v8] " Kai Ji
2026-10-13 15:43 ` [PATCH v9] " Kai Ji
2026-10-26 18:21 ` [EXTERNAL] " Akhil Goyal
2026-10-28 5:52 ` Akhil Goyal
2026-11-05 16:31 ` [dpdk-dev v10 0/2] app: add cryptodev validation applications Kai Ji
2026-11-05 16:31 ` [dpdk-dev v10 1/2] app: move FIPS validation under app/ Kai Ji
2026-11-05 16:31 ` [dpdk-dev v10 2/2] app: add Wycheproof validation app Kai Ji
2026-11-06 16:14 ` [dpdk-dev v11 0/2] app: add cryptodev validation applications Kai Ji
2026-11-06 16:14 ` [dpdk-dev v11 1/2] app: move FIPS validation under app/ Kai Ji
2026-11-09 16:00 ` Ji, Kai
2026-11-06 16:14 ` [dpdk-dev v11 2/2] app: add Wycheproof validation app Kai Ji
2026-11-12 18:42 ` Thomas Monjalon [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aoLxq0f-RTCUdgN0nuzopA@monjalon.net \
--to=thomas@monjalon.net \
--cc=dev@dpdk.org \
--cc=gmuthukrishn@marvell.com \
--cc=kai.ji@intel.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox