DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: David Marchand <david.marchand@redhat.com>
Cc: <dev@dpdk.org>, Aaron Conole <aconole@redhat.com>
Subject: Re: [PATCH v2 8/9] ci: make ABI reference generation faster
Date: Fri, 18 Sep 2026 16:32:32 +0100	[thread overview]
Message-ID: <aq1ZkPhvlVCRH-B8@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260723125559.3087579-9-david.marchand@redhat.com>

On Thu, Jul 23, 2026 at 02:55:57PM +0200, David Marchand wrote:
> Regenerating ABI is not something we do often, but when working on ABI
> topics, a lot of time may be wasted on waiting for the reference being
> generated.
> 
> We only care about shared libraries, avoid building final applications
> or examples.
> And we don't need to double check headers in the ABI reference.
> 
> Signed-off-by: David Marchand <david.marchand@redhat.com>
> ---
>  .ci/linux-build.sh            | 11 ++++++++++-
>  devtools/test-meson-builds.sh |  5 ++++-
>  2 files changed, 14 insertions(+), 2 deletions(-)
> 
> diff --git a/.ci/linux-build.sh b/.ci/linux-build.sh
> index e0b914a142..a5e602ed83 100755
> --- a/.ci/linux-build.sh
> +++ b/.ci/linux-build.sh
> @@ -201,9 +201,18 @@ if [ "$ABI_CHECKS" = "true" ]; then
>      fi
>  
>      if [ ! -d reference ]; then
> +        REF_OPTS="$OPTS"
> +        # We only care about the drivers and libs, disable developer checks and
> +        # don't try to link apps.
> +        REF_OPTS="$REF_OPTS -Dcheck_includes=false"
> +        REF_OPTS="$REF_OPTS -Ddeveloper_mode=disabled"
> +        REF_OPTS="$REF_OPTS -Ddisable_apps=*"
> +        REF_OPTS="$REF_OPTS -Denable_docs=false"
> +        REF_OPTS="$REF_OPTS -Dexamples="
> +        REF_OPTS="$REF_OPTS -Dtests=false"

Minor nit, but this shouldn't be necessary, as it will now be covered under
the disable_apps wildcard AFAIK.

A number of these are already the default, but I suppose explicitly stating
them is harmless (as is setting tests=false).

>          refsrcdir=$(readlink -f $(pwd)/../dpdk-$REF_GIT_TAG)
>          git clone --single-branch -b "$REF_GIT_TAG" $REF_GIT_REPO $refsrcdir
> -        meson setup $OPTS -Dexamples= $refsrcdir $refsrcdir/build
> +        meson setup $REF_OPTS $refsrcdir $refsrcdir/build
>          ninja -C $refsrcdir/build
>          DESTDIR=$(pwd)/reference meson install -C $refsrcdir/build
>          find reference/usr/local -name '*.a' -delete
> diff --git a/devtools/test-meson-builds.sh b/devtools/test-meson-builds.sh
> index 11e4be3f88..8ca7091b47 100755
> --- a/devtools/test-meson-builds.sh
> +++ b/devtools/test-meson-builds.sh
> @@ -206,8 +206,11 @@ build () # <directory> <target cc | cross file> <ABI check> [meson options]
>  			fi
>  
>  			rm -rf $abirefdir/build
> +			# We only care about the drivers and libs, disable
> +			# developer checks and don't try to link apps.
>  			config $abirefdir/src $abirefdir/build ABI $cross \
> -				-Dexamples= $*
> +				$* -Dcheck_includes=false -Ddeveloper_mode=disabled \
> +				-Ddisable_apps=* -Dexamples= -Dtests=false
>  			compile $abirefdir/build
>  			install_target $abirefdir/build $abirefdir/$targetdir
>  

Acked-by: Bruce Richardson <bruce.richardson@intel.com>


  reply	other threads:[~2026-09-18 15:32 UTC|newest]

Thread overview: 68+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-07-17  9:29 [PATCH 00/10] Limit usage of internal API in tests David Marchand
2026-07-17  9:29 ` [PATCH 01/10] bbdev: fix stats aggregation from queues David Marchand
2026-07-17 17:22   ` Chautru, Nicolas
2026-07-18  7:47     ` David Marchand
2026-07-17  9:29 ` [PATCH 02/10] bbdev: add per-queue statistics API David Marchand
2026-07-17  9:29 ` [PATCH 03/10] hash: fix GFNI stubs export David Marchand
2026-07-17  9:38   ` Bruce Richardson
2026-07-17  9:55   ` Konstantin Ananyev
2026-07-17  9:29 ` [PATCH 04/10] test: uninline helper for forking David Marchand
2026-07-17  9:39   ` Bruce Richardson
2026-07-17  9:30 ` [PATCH 05/10] test/bonding: get MAC address with public API David Marchand
2026-07-17  9:30 ` [PATCH 06/10] test/devargs: check driver presence " David Marchand
2026-07-17  9:55   ` Bruce Richardson
2026-07-17 10:08     ` David Marchand
2026-07-17 10:14       ` Bruce Richardson
2026-07-17 12:34         ` David Marchand
2026-07-17 12:56           ` Thomas Monjalon
2026-07-17  9:30 ` [PATCH 07/10] test/vdev: find device " David Marchand
2026-07-17  9:30 ` [PATCH 08/10] test: limit internal API usage David Marchand
2026-07-17  9:30 ` [PATCH 09/10] ci: make ABI reference generation faster David Marchand
2026-07-17  9:30 ` [PATCH 10/10] ci: run reference unit tests against ABI David Marchand
2026-07-17  9:35 ` [PATCH 00/10] Limit usage of internal API in tests David Marchand
2026-07-23 12:55 ` [PATCH v2 0/9] " David Marchand
2026-07-23 12:55   ` [PATCH v2 1/9] bbdev: add per-queue statistics API David Marchand
2026-09-18 15:29     ` Bruce Richardson
2026-07-23 12:55   ` [PATCH v2 2/9] hash: fix GFNI stubs export David Marchand
2026-07-23 12:55   ` [PATCH v2 3/9] test: uninline helper for forking David Marchand
2026-07-23 12:55   ` [PATCH v2 4/9] test/bonding: get MAC address with public API David Marchand
2026-07-23 13:30     ` Bruce Richardson
2026-07-23 12:55   ` [PATCH v2 5/9] test/devargs: rely on net null driver David Marchand
2026-07-23 13:31     ` Bruce Richardson
2026-07-23 12:55   ` [PATCH v2 6/9] test/vdev: find device with public API David Marchand
2026-09-18 15:30     ` Bruce Richardson
2026-07-23 12:55   ` [PATCH v2 7/9] test: limit internal API usage David Marchand
2026-07-23 13:33     ` Bruce Richardson
2026-07-23 15:04     ` Morten Brørup
2026-07-23 12:55   ` [PATCH v2 8/9] ci: make ABI reference generation faster David Marchand
2026-09-18 15:32     ` Bruce Richardson [this message]
2026-07-23 12:55   ` [PATCH v2 9/9] ci: run reference binaries against current ABI David Marchand
2026-09-18 15:41     ` Bruce Richardson
2026-09-21 11:47 ` [PATCH v3 0/9] Limit usage of internal API in tests David Marchand
2026-09-21 11:47   ` [PATCH v3 1/9] bbdev: add per-queue statistics API David Marchand
2026-09-21 11:47   ` [PATCH v3 2/9] hash: fix GFNI stubs export David Marchand
2026-09-21 11:47   ` [PATCH v3 3/9] test: uninline helper for forking David Marchand
2026-09-21 11:47   ` [PATCH v3 4/9] test/bonding: get MAC address with public API David Marchand
2026-09-21 11:47   ` [PATCH v3 5/9] test/devargs: rely on net null driver David Marchand
2026-09-21 16:38     ` Stephen Hemminger
2026-09-21 11:47   ` [PATCH v3 6/9] test/vdev: find device with public API David Marchand
2026-09-21 16:39     ` Stephen Hemminger
2026-09-21 11:47   ` [PATCH v3 7/9] test: limit internal API usage David Marchand
2026-09-21 11:47   ` [PATCH v3 8/9] ci: make ABI reference generation faster David Marchand
2026-09-21 11:47   ` [PATCH v3 9/9] ci: run reference binaries against current ABI David Marchand
2026-09-21 16:39     ` Stephen Hemminger
2026-09-22  7:38       ` David Marchand
2026-09-22  9:40 ` [PATCH v4 0/9] Limit usage of internal API in tests David Marchand
2026-09-22  9:40   ` [PATCH v4 1/9] bbdev: add per-queue statistics API David Marchand
2026-09-22  9:40   ` [PATCH v4 2/9] hash: fix GFNI stubs export David Marchand
2026-09-22  9:40   ` [PATCH v4 3/9] test: uninline helper for forking David Marchand
2026-09-22  9:40   ` [PATCH v4 4/9] test/bonding: get MAC address with public API David Marchand
2026-09-22  9:40   ` [PATCH v4 5/9] test/devargs: rely on net null driver David Marchand
2026-09-22  9:40   ` [PATCH v4 6/9] test/vdev: find device with public API David Marchand
2026-09-22  9:40   ` [PATCH v4 7/9] test: limit internal API usage David Marchand
2026-09-22  9:40   ` [PATCH v4 8/9] ci: make ABI reference generation faster David Marchand
2026-09-22  9:40   ` [PATCH v4 9/9] ci: run reference binaries against current ABI David Marchand
2026-09-22 10:03     ` Bruce Richardson
2026-09-29 13:38   ` [PATCH v4 0/9] Limit usage of internal API in tests David Marchand
2026-09-29 19:50   ` Stephen Hemminger
2026-09-30  7:32     ` David Marchand

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=aq1ZkPhvlVCRH-B8@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=aconole@redhat.com \
    --cc=david.marchand@redhat.com \
    --cc=dev@dpdk.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox