From: Bruce Richardson <bruce.richardson@intel.com>
To: Zhang Tengfei <zhtfdev@gmail.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>,
Vladimir Medvedkin <vladimir.medvedkin@intel.com>, <dev@dpdk.org>
Subject: Re: [PATCH v2] net/ixgbe: add fdir_buffer_size devarg
Date: Fri, 11 Sep 2026 16:21:12 +0100 [thread overview]
Message-ID: <aqQcaApthiWR-T_W@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <20260910155812.127658-1-zhtfdev@gmail.com>
On Thu, Sep 10, 2026 at 11:58:12PM +0800, Zhang Tengfei wrote:
> After public fdir_conf was removed from rte_eth_conf, the private
> pballoc field stays at the 64K default. Add a probe-time devarg so
> applications can select 128K or 256K Flow Director table size.
>
> Reject Flow Director with DCB in ixgbe_fdir_configure(), since FDIR
> steals Rx packet buffer space that DCB also uses.
>
> Signed-off-by: Zhang Tengfei <zhtfdev@gmail.com>
> ---
> v2:
> * rename fdir_pballoc to fdir_buffer_size
> * reject Flow Director when DCB is enabled in ixgbe_fdir_configure()
> * document the DCB limitation as an RST note
> * keep the original indent of ixgbe_parse_devargs
>
> doc/guides/nics/ixgbe.rst | 26 ++++++++++++
> doc/guides/rel_notes/release_26_11.rst | 5 +++
> drivers/net/intel/ixgbe/ixgbe_ethdev.c | 55 ++++++++++++++++++++++----
> drivers/net/intel/ixgbe/ixgbe_ethdev.h | 2 +-
> drivers/net/intel/ixgbe/ixgbe_fdir.c | 13 +++++-
> drivers/net/intel/ixgbe/ixgbe_flow.c | 7 +++-
> 6 files changed, 98 insertions(+), 10 deletions(-)
>
Acked-by: Bruce Richardson <bruce.richardson@intel.com>
next prev parent reply other threads:[~2026-09-11 15:21 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-08 15:58 [PATCH] net/ixgbe: add FDIR pballoc devarg Zhang Tengfei
2026-09-10 13:47 ` Bruce Richardson
2026-09-10 15:58 ` [PATCH v2] net/ixgbe: add fdir_buffer_size devarg Zhang Tengfei
2026-09-11 15:21 ` Bruce Richardson [this message]
2026-09-11 15:38 ` Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqQcaApthiWR-T_W@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=dev@dpdk.org \
--cc=vladimir.medvedkin@intel.com \
--cc=zhtfdev@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox