From: Bruce Richardson <bruce.richardson@intel.com>
To: "Loftus, Ciara" <ciara.loftus@intel.com>
Cc: "dev@dpdk.org" <dev@dpdk.org>,
"Burakov, Anatoly" <anatoly.burakov@intel.com>
Subject: Re: [PATCH 08/13] net/ice: use common descriptor creation functions
Date: Mon, 14 Sep 2026 18:02:32 +0100 [thread overview]
Message-ID: <aqgoqHouylf6Y7nJ@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <IA4PR11MB927882EEB505228A110F5F298EBB2@IA4PR11MB9278.namprd11.prod.outlook.com>
On Mon, Sep 14, 2026 at 03:15:04PM +0100, Loftus, Ciara wrote:
> > Subject: [PATCH 08/13] net/ice: use common descriptor creation functions
> >
> > Update ice driver to use the descriptor creation functions from common
> > rather than having it maintain its own copies of them.
> >
> > Signed-off-by: Bruce Richardson <bruce.richardson@intel.com>
> > ---
> > drivers/net/intel/ice/ice_rxtx_vec_avx2.c | 73 ++-------------------
> > drivers/net/intel/ice/ice_rxtx_vec_avx512.c | 64 ++----------------
> > drivers/net/intel/ice/ice_rxtx_vec_common.h | 59 -----------------
> > 3 files changed, 12 insertions(+), 184 deletions(-)
> >
> > diff --git a/drivers/net/intel/ice/ice_rxtx_vec_avx2.c
> > b/drivers/net/intel/ice/ice_rxtx_vec_avx2.c
> > index b72f69a47b..68401560ce 100644
> > --- a/drivers/net/intel/ice/ice_rxtx_vec_avx2.c
> > +++ b/drivers/net/intel/ice/ice_rxtx_vec_avx2.c
> > @@ -5,6 +5,7 @@
> > #include "ice_rxtx_vec_common.h"
> >
> > #include "../common/rx_vec_x86.h"
> > +#include "../common/tx_vec_x86.h"
> >
> > #include <rte_vect.h>
> >
> > @@ -773,70 +774,6 @@ ice_recv_scattered_pkts_vec_avx2_offload(void
> > *rx_queue,
> > true);
> > }
> >
> > -static __rte_always_inline void
> > -ice_vtx1(volatile struct ci_tx_desc *txdp,
> > - struct rte_mbuf *pkt, uint64_t flags, bool offload)
> > -{
> > - uint64_t high_qw = (CI_TX_DESC_DTYPE_DATA |
> > - ((uint64_t)flags << CI_TXD_QW1_CMD_S) |
> > - ((uint64_t)pkt->data_len << CI_TXD_QW1_TX_BUF_SZ_S));
> > - if (offload)
> > - ice_txd_enable_offload(pkt, &high_qw);
> > -
> > - __m128i descriptor = _mm_set_epi64x(high_qw,
> > rte_pktmbuf_iova(pkt));
>
> AI caught this for me on review, and I was able to reproduce it:
> When you build with -Denable_iova_as_pa=false the ice driver build will fail.
> "require_iova_in_mbuf = false" is set in the ice meson.build file. So either
> that needs to be flipped to true, or ice needs to keep using rte_pktmbuf_iova.
>
Good catch by the AI. Changing the code to use the proper macro not only
ensure ice isn't broken, but also allows us to enable iavf builds when the
iova-in-mbuf setting is disabled. Will fix in next version.
/Bruce
next prev parent reply other threads:[~2026-09-14 17:02 UTC|newest]
Thread overview: 69+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-09-03 17:01 [PATCH 00/13] Consolidate ice and iavf vector Tx paths Bruce Richardson
2026-09-03 17:01 ` [PATCH 01/13] net/iavf: remove unnecessary alignment calls Bruce Richardson
2026-09-14 14:20 ` Loftus, Ciara
2026-09-03 17:01 ` [PATCH 02/13] net/intel: make Tx context flag common Bruce Richardson
2026-09-14 14:21 ` Loftus, Ciara
2026-09-03 17:01 ` [PATCH 03/13] net/iavf: use separate params for VLAN and QinQ position Bruce Richardson
2026-09-14 14:24 ` Loftus, Ciara
2026-09-03 17:01 ` [PATCH 04/13] net/iavf: deduplicate tunnel field fill functions Bruce Richardson
2026-09-04 7:01 ` David Marchand
2026-09-03 17:01 ` [PATCH 05/13] net/intel: define common macros for tunneling bit-shifts Bruce Richardson
2026-09-14 14:25 ` Loftus, Ciara
2026-09-03 17:01 ` [PATCH 06/13] net/intel: move iavf descriptor writing functions to common Bruce Richardson
2026-09-14 14:34 ` Loftus, Ciara
2026-09-03 17:01 ` [PATCH 07/13] net/intel: use function callback for lldp Bruce Richardson
2026-09-03 17:01 ` [PATCH 08/13] net/ice: use common descriptor creation functions Bruce Richardson
2026-09-14 14:15 ` Loftus, Ciara
2026-09-14 17:02 ` Bruce Richardson [this message]
2026-09-03 17:01 ` [PATCH 09/13] net/intel: move vector Tx paths to common Bruce Richardson
2026-09-14 14:38 ` Loftus, Ciara
2026-09-03 17:03 ` [PATCH 10/13] net/ice: use common AVX Tx functions Bruce Richardson
2026-09-14 14:41 ` Loftus, Ciara
2026-09-03 17:04 ` [PATCH 11/13] net/intel: add common vector Tx fns with context handling Bruce Richardson
2026-09-14 14:57 ` Loftus, Ciara
2026-09-03 17:04 ` [PATCH 12/13] net/intel: improve Tx path selection logic Bruce Richardson
2026-09-14 14:59 ` Loftus, Ciara
2026-09-03 17:04 ` [PATCH 13/13] net/ice: enable context desc offloads for vector Tx Bruce Richardson
2026-09-14 14:18 ` Loftus, Ciara
2026-09-14 16:35 ` Bruce Richardson
2026-09-04 7:10 ` [PATCH 00/13] Consolidate ice and iavf vector Tx paths David Marchand
2026-09-15 13:36 ` [PATCH v2 00/15] consolidate ice and iavf Tx vector paths Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 01/15] net/iavf: remove unnecessary alignment calls Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 02/15] net/intel: make Tx context flag common Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 03/15] net/iavf: use separate params for VLAN and QinQ position Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 04/15] net/iavf: deduplicate tunnel field fill functions Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 05/15] net/intel: define common macros for tunneling bit-shifts Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 06/15] net/intel: move iavf descriptor writing functions to common Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 07/15] net/intel: use function callback for lldp Bruce Richardson
2026-09-16 8:56 ` Loftus, Ciara
2026-09-15 13:36 ` [PATCH v2 08/15] net/intel: allow building without IOVA in mbuf Bruce Richardson
2026-09-16 8:57 ` Loftus, Ciara
2026-09-15 13:36 ` [PATCH v2 09/15] net/ice: use common descriptor creation functions Bruce Richardson
2026-09-16 8:58 ` Loftus, Ciara
2026-09-15 13:36 ` [PATCH v2 10/15] net/intel: move vector Tx paths to common Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 11/15] net/ice: use common AVX Tx functions Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 12/15] net/intel: add common vector Tx fns with context handling Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 13/15] net/intel: improve Tx path selection logic Bruce Richardson
2026-09-15 13:36 ` [PATCH v2 14/15] net/ice: enable context desc offloads for vector Tx Bruce Richardson
2026-09-16 9:03 ` Loftus, Ciara
2026-09-15 13:36 ` [PATCH v2 15/15] net/intel: consolidate Tx vector offload path checks Bruce Richardson
2026-09-16 9:02 ` Loftus, Ciara
2026-09-16 10:36 ` [PATCH v3 00/15] consolidate ice and iavf Tx vector paths Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 01/15] net/iavf: remove unnecessary alignment calls Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 02/15] net/intel: make Tx context flag common Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 03/15] net/iavf: use separate params for VLAN and QinQ position Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 04/15] net/iavf: deduplicate tunnel field fill functions Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 05/15] net/intel: define common macros for tunneling bit-shifts Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 06/15] net/intel: move iavf descriptor writing functions to common Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 07/15] net/intel: use function callback for lldp Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 08/15] net/intel: allow building without IOVA in mbuf Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 09/15] net/ice: use common descriptor creation functions Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 10/15] net/intel: move vector Tx paths to common Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 11/15] net/ice: use common AVX Tx functions Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 12/15] net/intel: add common vector Tx fns with context handling Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 13/15] net/intel: improve Tx path selection logic Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 14/15] net/ice: enable context desc offloads for vector Tx Bruce Richardson
2026-09-16 13:00 ` Loftus, Ciara
2026-09-16 13:06 ` Bruce Richardson
2026-09-16 10:36 ` [PATCH v3 15/15] net/intel: consolidate Tx vector offload path checks Bruce Richardson
2026-09-16 13:09 ` [PATCH v3 00/15] consolidate ice and iavf Tx vector paths Bruce Richardson
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=aqgoqHouylf6Y7nJ@bricha3-mobl1.ger.corp.intel.com \
--to=bruce.richardson@intel.com \
--cc=anatoly.burakov@intel.com \
--cc=ciara.loftus@intel.com \
--cc=dev@dpdk.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox