DPDK-dev Archive on lore.kernel.org
 help / color / mirror / Atom feed
From: Bruce Richardson <bruce.richardson@intel.com>
To: "Medvedkin, Vladimir" <vladimir.medvedkin@intel.com>
Cc: Anatoly Burakov <anatoly.burakov@intel.com>, <dev@dpdk.org>
Subject: Re: [PATCH v1 1/1] net/iavf: remove dead code
Date: Thu, 15 Oct 2026 18:27:38 +0100	[thread overview]
Message-ID: <atENCiK1eHgP9MF5@bricha3-mobl1.ger.corp.intel.com> (raw)
In-Reply-To: <8128e56e-6e70-476d-871f-bf6849055f7f@intel.com>

On Thu, Oct 15, 2026 at 03:56:33PM +0100, Medvedkin, Vladimir wrote:
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> 
> On 10/15/2026 3:42 PM, Anatoly Burakov wrote:
> > When configuring Rx queue interrupts, there is dead code in one of the
> > banches. Remove it.
> > 
> > Suggested-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> >   drivers/net/intel/iavf/iavf_ethdev.c | 4 ----
> >   1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c
> > index 6abdabfb94..937b1fdad3 100644
> > --- a/drivers/net/intel/iavf/iavf_ethdev.c
> > +++ b/drivers/net/intel/iavf/iavf_ethdev.c
> > @@ -901,10 +901,6 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
> >   				       (0 << IAVF_VFINT_DYN_CTLN1_ITR_INDX_SHIFT) |
> >   				       IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK |
> >   				       (2UL << IAVF_VFINT_DYN_CTLN1_INTERVAL_SHIFT));
> > -			/* debug - check for success! the return value
> > -			 * should be 2, offset is 0x2800
> > -			 */
> > -			/* IAVF_READ_REG(hw, IAVF_VFINT_ITRN1(0, 0)); */
> >   		} else {
> >   			/* If no WB_ON_ITR offload flags, need to set
> >   			 * interrupt for descriptor write back.
> 
Patch applied to dpdk-next-net-intel
Thanks,
/Bruce

      reply	other threads:[~2026-10-15 17:29 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2026-10-15 14:42 [PATCH v1 1/1] net/iavf: remove dead code Anatoly Burakov
2026-10-15 14:56 ` Medvedkin, Vladimir
2026-10-15 17:27   ` Bruce Richardson [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=atENCiK1eHgP9MF5@bricha3-mobl1.ger.corp.intel.com \
    --to=bruce.richardson@intel.com \
    --cc=anatoly.burakov@intel.com \
    --cc=dev@dpdk.org \
    --cc=vladimir.medvedkin@intel.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox