[PATCH v1 1/1] net/iavf: remove dead code

[PATCH v1 1/1] net/iavf: remove dead code

[Anatoly Burakov]

When configuring Rx queue interrupts, there is dead code in one of the
banches. Remove it.

Suggested-by: David Marchand <david.marchand@redhat.com>
Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
---
 drivers/net/intel/iavf/iavf_ethdev.c | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c
index 6abdabfb94..937b1fdad3 100644
--- a/drivers/net/intel/iavf/iavf_ethdev.c
+++ b/drivers/net/intel/iavf/iavf_ethdev.c
@@ -901,10 +901,6 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
 				       (0 << IAVF_VFINT_DYN_CTLN1_ITR_INDX_SHIFT) |
 				       IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK |
 				       (2UL << IAVF_VFINT_DYN_CTLN1_INTERVAL_SHIFT));
-			/* debug - check for success! the return value
-			 * should be 2, offset is 0x2800
-			 */
-			/* IAVF_READ_REG(hw, IAVF_VFINT_ITRN1(0, 0)); */
 		} else {
 			/* If no WB_ON_ITR offload flags, need to set
 			 * interrupt for descriptor write back.
-- 
2.52.0

Re: [PATCH v1 1/1] net/iavf: remove dead code

[Medvedkin, Vladimir]

Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>

On 10/15/2026 3:42 PM, Anatoly Burakov wrote:
> When configuring Rx queue interrupts, there is dead code in one of the
> banches. Remove it.
>
> Suggested-by: David Marchand <david.marchand@redhat.com>
> Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> ---
>   drivers/net/intel/iavf/iavf_ethdev.c | 4 ----
>   1 file changed, 4 deletions(-)
>
> diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c
> index 6abdabfb94..937b1fdad3 100644
> --- a/drivers/net/intel/iavf/iavf_ethdev.c
> +++ b/drivers/net/intel/iavf/iavf_ethdev.c
> @@ -901,10 +901,6 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
>   				       (0 << IAVF_VFINT_DYN_CTLN1_ITR_INDX_SHIFT) |
>   				       IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK |
>   				       (2UL << IAVF_VFINT_DYN_CTLN1_INTERVAL_SHIFT));
> -			/* debug - check for success! the return value
> -			 * should be 2, offset is 0x2800
> -			 */
> -			/* IAVF_READ_REG(hw, IAVF_VFINT_ITRN1(0, 0)); */
>   		} else {
>   			/* If no WB_ON_ITR offload flags, need to set
>   			 * interrupt for descriptor write back.

-- 
Regards,
Vladimir

Re: [PATCH v1 1/1] net/iavf: remove dead code

[Bruce Richardson]

On Thu, Oct 15, 2026 at 03:56:33PM +0100, Medvedkin, Vladimir wrote:
> Acked-by: Vladimir Medvedkin <vladimir.medvedkin@intel.com>
> 
> On 10/15/2026 3:42 PM, Anatoly Burakov wrote:
> > When configuring Rx queue interrupts, there is dead code in one of the
> > banches. Remove it.
> > 
> > Suggested-by: David Marchand <david.marchand@redhat.com>
> > Signed-off-by: Anatoly Burakov <anatoly.burakov@intel.com>
> > ---
> >   drivers/net/intel/iavf/iavf_ethdev.c | 4 ----
> >   1 file changed, 4 deletions(-)
> > 
> > diff --git a/drivers/net/intel/iavf/iavf_ethdev.c b/drivers/net/intel/iavf/iavf_ethdev.c
> > index 6abdabfb94..937b1fdad3 100644
> > --- a/drivers/net/intel/iavf/iavf_ethdev.c
> > +++ b/drivers/net/intel/iavf/iavf_ethdev.c
> > @@ -901,10 +901,6 @@ static int iavf_config_rx_queues_irqs(struct rte_eth_dev *dev,
> >   				       (0 << IAVF_VFINT_DYN_CTLN1_ITR_INDX_SHIFT) |
> >   				       IAVF_VFINT_DYN_CTLN1_WB_ON_ITR_MASK |
> >   				       (2UL << IAVF_VFINT_DYN_CTLN1_INTERVAL_SHIFT));
> > -			/* debug - check for success! the return value
> > -			 * should be 2, offset is 0x2800
> > -			 */
> > -			/* IAVF_READ_REG(hw, IAVF_VFINT_ITRN1(0, 0)); */
> >   		} else {
> >   			/* If no WB_ON_ITR offload flags, need to set
> >   			 * interrupt for descriptor write back.
> 
Patch applied to dpdk-next-net-intel
Thanks,
/Bruce