[PATCH 0/2] fix minimum virtchnl API version logs

[PATCH 0/2] fix minimum virtchnl API version logs

[Sandeep Penigalapati]

The iavf and ice DCF version checks compare against the minimum
minor version, but both error logs pass the major macro twice.
Both minima are 1 today, so the printed text is still 1.1.
The logs would be wrong if a minor minimum ever diverged.

Sandeep Penigalapati (2):
  net/iavf: fix minimum API version log
  net/ice: fix DCF minimum API version log

 drivers/net/intel/iavf/iavf_vchnl.c | 2 +-
 drivers/net/intel/ice/ice_dcf.c     | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

-- 
2.34.1

[PATCH 1/2] net/iavf: fix minimum API version log

[Sandeep Penigalapati]

The error path that rejects a VIRTCHNL API version below the
minimum supported by Adaptive VF passes
VIRTCHNL_VERSION_MAJOR_START for both the major and the minor
format arguments. The logged minimum therefore repeats the
major number. Pass VIRTCHNL_VERSION_MINOR_START as the minor
version.

Fixes: 22b123a36d07 ("net/avf: initialize PMD")
Cc: stable@dpdk.org

Signed-off-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
---
 drivers/net/intel/iavf/iavf_vchnl.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/intel/iavf/iavf_vchnl.c b/drivers/net/intel/iavf/iavf_vchnl.c
index 34961fe654..f1354648cf 100644
--- a/drivers/net/intel/iavf/iavf_vchnl.c
+++ b/drivers/net/intel/iavf/iavf_vchnl.c
@@ -778,7 +778,7 @@ iavf_check_api_version(struct iavf_adapter *adapter)
 		PMD_INIT_LOG(ERR, "VIRTCHNL API version should not be lower"
 			     " than (%u.%u) to support Adaptive VF",
 			     VIRTCHNL_VERSION_MAJOR_START,
-			     VIRTCHNL_VERSION_MAJOR_START);
+			     VIRTCHNL_VERSION_MINOR_START);
 		return -1;
 	} else if (vf->virtchnl_version.major > VIRTCHNL_VERSION_MAJOR ||
 		   (vf->virtchnl_version.major == VIRTCHNL_VERSION_MAJOR &&
-- 
2.34.1

Re: [PATCH 1/2] net/iavf: fix minimum API version log

[Bruce Richardson]

On Mon, Nov 09, 2026 at 12:45:23PM +0000, Sandeep Penigalapati wrote:
> The error path that rejects a VIRTCHNL API version below the
> minimum supported by Adaptive VF passes
> VIRTCHNL_VERSION_MAJOR_START for both the major and the minor
> format arguments. The logged minimum therefore repeats the
> major number. Pass VIRTCHNL_VERSION_MINOR_START as the minor
> version.
> 
> Fixes: 22b123a36d07 ("net/avf: initialize PMD")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
> ---
>  drivers/net/intel/iavf/iavf_vchnl.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

[PATCH 2/2] net/ice: fix DCF minimum API version log

[Sandeep Penigalapati]

The DCF error path that rejects a VIRTCHNL API version below
the minimum passes ICE_CPF_VIRTCHNL_VERSION_MAJOR_START for
both the major and the minor format arguments. The logged
minimum therefore repeats the major number. Pass
ICE_CPF_VIRTCHNL_VERSION_MINOR_START as the minor version.

Fixes: 7564d5509611 ("net/ice: add DCF hardware initialization")
Cc: stable@dpdk.org

Signed-off-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
---
 drivers/net/intel/ice/ice_dcf.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/drivers/net/intel/ice/ice_dcf.c b/drivers/net/intel/ice/ice_dcf.c
index 976f2ed260..48a5b9667c 100644
--- a/drivers/net/intel/ice/ice_dcf.c
+++ b/drivers/net/intel/ice/ice_dcf.c
@@ -334,7 +334,7 @@ ice_dcf_init_check_api_version(struct ice_dcf_hw *hw)
 		PMD_INIT_LOG(ERR,
 			     "VIRTCHNL API version should not be lower than (%u.%u)",
 			     ICE_CPF_VIRTCHNL_VERSION_MAJOR_START,
-			     ICE_CPF_VIRTCHNL_VERSION_MAJOR_START);
+			     ICE_CPF_VIRTCHNL_VERSION_MINOR_START);
 		return -1;
 	} else if (pver->major > VIRTCHNL_VERSION_MAJOR ||
 		   (pver->major == VIRTCHNL_VERSION_MAJOR &&
-- 
2.34.1

Re: [PATCH 2/2] net/ice: fix DCF minimum API version log

[Bruce Richardson]

On Mon, Nov 09, 2026 at 12:45:24PM +0000, Sandeep Penigalapati wrote:
> The DCF error path that rejects a VIRTCHNL API version below
> the minimum passes ICE_CPF_VIRTCHNL_VERSION_MAJOR_START for
> both the major and the minor format arguments. The logged
> minimum therefore repeats the major number. Pass
> ICE_CPF_VIRTCHNL_VERSION_MINOR_START as the minor version.
> 
> Fixes: 7564d5509611 ("net/ice: add DCF hardware initialization")
> Cc: stable@dpdk.org
> 
> Signed-off-by: Sandeep Penigalapati <sandeep.penigalapati@intel.com>
> ---
>  drivers/net/intel/ice/ice_dcf.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Re: [PATCH 0/2] fix minimum virtchnl API version logs

[Bruce Richardson]

On Mon, Nov 09, 2026 at 12:45:22PM +0000, Sandeep Penigalapati wrote:
> The iavf and ice DCF version checks compare against the minimum
> minor version, but both error logs pass the major macro twice.
> Both minima are 1 today, so the printed text is still 1.1.
> The logs would be wrong if a minor minimum ever diverged.
> 
> Sandeep Penigalapati (2):
>   net/iavf: fix minimum API version log
>   net/ice: fix DCF minimum API version log
> 
>  drivers/net/intel/iavf/iavf_vchnl.c | 2 +-
>  drivers/net/intel/ice/ice_dcf.c     | 2 +-
>  2 files changed, 2 insertions(+), 2 deletions(-)
> 
Series applied to dpdk-next-net-intel.

Thanks,
/Bruce